Files
SVSimServer/SVSim.BattleNode/Bridge/MatchingBridge.cs
gamer147 f19da481c3 fix(battle-node): MatchingBridge avoids Math.Abs(int.MinValue) overflow
Cast GetHashCode() result to long before Math.Abs to prevent OverflowException
on the ~1-in-4B case where GetHashCode returns int.MinValue. Adds a regression
test pinning the 12-digit decimal format end-to-end.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-31 22:33:35 -04:00

25 lines
856 B
C#

using SVSim.BattleNode.Sessions;
namespace SVSim.BattleNode.Bridge;
public sealed class MatchingBridge : IMatchingBridge
{
private readonly IBattleSessionStore _store;
private readonly BattleNodeOptions _options;
public MatchingBridge(IBattleSessionStore store, BattleNodeOptions options)
{
_store = store;
_options = options;
}
public PendingMatch RegisterPendingBattle(long viewerId)
{
// 12-digit decimal battle id mirrors the captures (e.g. "975695075012").
// Cast to long before Math.Abs to avoid OverflowException on int.MinValue.
var battleId = (Math.Abs((long)Guid.NewGuid().GetHashCode()) % 1_000_000_000_000L).ToString("D12");
_store.RegisterPending(new PendingBattle(battleId, viewerId));
return new PendingMatch(battleId, _options.NodeServerUrl);
}
}