SVSim/SVSimServer
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix(battle-node): MatchingBridge avoids Math.Abs(int.MinValue) overflow

Browse Source 
Cast GetHashCode() result to long before Math.Abs to prevent OverflowException
on the ~1-in-4B case where GetHashCode returns int.MinValue. Adds a regression
test pinning the 12-digit decimal format end-to-end.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
gamer147
2026-05-31 22:33:35 -04:00
parent d3c4b3083e
commit f19da481c3
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
SVSim.BattleNode/Bridge/MatchingBridge.cs
View File

@@ -16,7 +16,8 @@ public sealed class MatchingBridge : IMatchingBridge
public PendingMatch RegisterPendingBattle(long viewerId)
{
// 12-digit decimal battle id mirrors the captures (e.g. "975695075012").
var battleId = (Math.Abs(Guid.NewGuid().GetHashCode()) % 1_000_000_000_000L).ToString("D12");
// Cast to long before Math.Abs to avoid OverflowException on int.MinValue.
var battleId = (Math.Abs((long)Guid.NewGuid().GetHashCode()) % 1_000_000_000_000L).ToString("D12");
_store.RegisterPending(new PendingBattle(battleId, viewerId));
return new PendingMatch(battleId, _options.NodeServerUrl);
}

11
SVSim.UnitTests/BattleNode/Bridge/MatchingBridgeTests.cs
View File

@@ -32,4 +32,15 @@ public class MatchingBridgeTests
Assert.That(a.BattleId, Is.Not.EqualTo(b.BattleId));
}
[Test]
public void RegisterPendingBattle_ProducesTwelveDigitDecimalBattleId()
{
var bridge = new MatchingBridge(new InMemoryBattleSessionStore(), new BattleNodeOptions());
var match = bridge.RegisterPendingBattle(viewerId: 1);
Assert.That(match.BattleId, Has.Length.EqualTo(12));
Assert.That(match.BattleId, Does.Match("^[0-9]{12}$"));
}
}