SVSim/SVSimServer
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

test(admin): update MissionMeta round-trip test to new wire types

Browse Source 
Two test callsites in AdminControllerTests still constructed ImportMissionMeta
with the pre-fix types (bool HasReceivedPickTwoMission, long MissionChangeTime),
which compiled locally against the stale test binaries under --no-build but
tripped CS0029 in CI on a clean build. Switch to wire-shape values (int 1,
"yyyy-MM-dd HH:mm:ss" string) and adjust the round-trip assertion to compare
against the parsed-UTC DateTime rather than the Unix conversion.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
gamer147
2026-07-04 19:51:31 -04:00
parent eecad64655
commit 4b5c3b905e
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
SVSim.UnitTests/Controllers/AdminControllerTests.cs
View File

@@ -467,9 +467,9 @@ public class AdminControllerTests
SteamId = steamId,
MissionMeta = new ImportMissionMeta
{
HasReceivedPickTwoMission = true,
HasReceivedPickTwoMission = 1, // wire "1"/"0"; controller normalizes to bool
MissionReceiveType = 2,
MissionChangeTime = 1_700_000_000L
MissionChangeTime = "2023-11-14 22:13:20" // wire "yyyy-MM-dd HH:mm:ss"; parsed as UTC
}
});
resp.EnsureSuccessStatusCode();
@@ -484,9 +484,10 @@ public class AdminControllerTests
Assert.That(viewer.MissionData, Is.Not.Null);
Assert.That(viewer.MissionData!.HasReceivedPickTwoMission, Is.True);
Assert.That(viewer.MissionData.MissionReceiveType, Is.EqualTo(2));
// MissionChangeTime is DateTime in storage; verify it survives the round-trip from unix seconds.
// MissionChangeTime is DateTime in storage; the datetime string parses as UTC
// (AssumeUniversal | AdjustToUniversal in AdminController.Pass A).
Assert.That(viewer.MissionData.MissionChangeTime,
Is.EqualTo(DateTimeOffset.FromUnixTimeSeconds(1_700_000_000L).UtcDateTime));
Is.EqualTo(new DateTime(2023, 11, 14, 22, 13, 20, DateTimeKind.Utc)));
}
[Test]
@@ -1051,7 +1052,7 @@ public class AdminControllerTests
var req = new ImportViewerRequest
{
SteamId = steamId,
MissionMeta = new ImportMissionMeta { HasReceivedPickTwoMission = true, MissionReceiveType = 1, MissionChangeTime = 1L },
MissionMeta = new ImportMissionMeta { HasReceivedPickTwoMission = 1, MissionReceiveType = 1, MissionChangeTime = "2023-01-01 00:00:00" },
Missions = new List<ImportMission> { new() { MissionId = 8001, MissionStatus = 1, TotalCount = 5 } },
Achievements = new List<ImportAchievement> { new() { AchievementType = 800, Level = 1, NowAchievedLevel = 1, ResultAnnounceSawLevel = 0, TotalCount = 9 } },
StoryProgress = new List<ImportStoryProgress> { new() { StoryApiType = 1, StoryId = 50, IsFinish = true } }