From 4b5c3b905ea061e59b5b4a26f2a472d53dc8bdcb Mon Sep 17 00:00:00 2001 From: gamer147 Date: Sat, 4 Jul 2026 19:51:31 -0400 Subject: [PATCH] test(admin): update MissionMeta round-trip test to new wire types Two test callsites in AdminControllerTests still constructed ImportMissionMeta with the pre-fix types (bool HasReceivedPickTwoMission, long MissionChangeTime), which compiled locally against the stale test binaries under --no-build but tripped CS0029 in CI on a clean build. Switch to wire-shape values (int 1, "yyyy-MM-dd HH:mm:ss" string) and adjust the round-trip assertion to compare against the parsed-UTC DateTime rather than the Unix conversion. Co-Authored-By: Claude Opus 4.7 --- SVSim.UnitTests/Controllers/AdminControllerTests.cs | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/SVSim.UnitTests/Controllers/AdminControllerTests.cs b/SVSim.UnitTests/Controllers/AdminControllerTests.cs index 1af38478..ceb7ce2d 100644 --- a/SVSim.UnitTests/Controllers/AdminControllerTests.cs +++ b/SVSim.UnitTests/Controllers/AdminControllerTests.cs @@ -467,9 +467,9 @@ public class AdminControllerTests SteamId = steamId, MissionMeta = new ImportMissionMeta { - HasReceivedPickTwoMission = true, + HasReceivedPickTwoMission = 1, // wire "1"/"0"; controller normalizes to bool MissionReceiveType = 2, - MissionChangeTime = 1_700_000_000L + MissionChangeTime = "2023-11-14 22:13:20" // wire "yyyy-MM-dd HH:mm:ss"; parsed as UTC } }); resp.EnsureSuccessStatusCode(); @@ -484,9 +484,10 @@ public class AdminControllerTests Assert.That(viewer.MissionData, Is.Not.Null); Assert.That(viewer.MissionData!.HasReceivedPickTwoMission, Is.True); Assert.That(viewer.MissionData.MissionReceiveType, Is.EqualTo(2)); - // MissionChangeTime is DateTime in storage; verify it survives the round-trip from unix seconds. + // MissionChangeTime is DateTime in storage; the datetime string parses as UTC + // (AssumeUniversal | AdjustToUniversal in AdminController.Pass A). Assert.That(viewer.MissionData.MissionChangeTime, - Is.EqualTo(DateTimeOffset.FromUnixTimeSeconds(1_700_000_000L).UtcDateTime)); + Is.EqualTo(new DateTime(2023, 11, 14, 22, 13, 20, DateTimeKind.Utc))); } [Test] @@ -1051,7 +1052,7 @@ public class AdminControllerTests var req = new ImportViewerRequest { SteamId = steamId, - MissionMeta = new ImportMissionMeta { HasReceivedPickTwoMission = true, MissionReceiveType = 1, MissionChangeTime = 1L }, + MissionMeta = new ImportMissionMeta { HasReceivedPickTwoMission = 1, MissionReceiveType = 1, MissionChangeTime = "2023-01-01 00:00:00" }, Missions = new List { new() { MissionId = 8001, MissionStatus = 1, TotalCount = 5 } }, Achievements = new List { new() { AchievementType = 800, Level = 1, NowAchievedLevel = 1, ResultAnnounceSawLevel = 0, TotalCount = 9 } }, StoryProgress = new List { new() { StoryApiType = 1, StoryId = 50, IsFinish = true } }