SVSim/SVSimServer
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

feat(battle-engine-port): M2 COMPLETE — vanilla follower resolves headless (go/no-go = GO)

Browse Source 
First green: a zero-skill vanilla follower (100011010, neutral 1/2) resolves to
correct authoritative state HEADLESS via IsForecast/IsRecovery + ActionProcessor.
PlayCard (DP4), no Unity runtime. §5 oracle passes (PP-cost; hand->in-play;
atk/health == CardCSVData base; opponent unchanged; no exception). VERDICT: the
port approach is validated through the resolution path, not just M1's compile path.

VanillaFollowerOracleTests.Vanilla_follower_resolves_to_correct_state — GREEN.
HeadlessCardMaster now loads the follower's real id from cards.json.

Resolution-path shim/engine gaps closed (all mechanical no-op fills or data seams,
never a Unity/logic wall):
- M1 mis-cut copies (DP1/DP3 — pure no-op logic wrongly stubbed to null):
  Engine/Wizard.Battle.View.Vfx/NullCardVfxCreator.cs (its GetInstance() singleton
  was nulled) + its dep NotEmptyNullVfx.cs. Deleted the generated NullCardVfxCreator
  stub + its _IfaceImpl block; both manifested, check_drift clean.
- _IfaceImpl explicit-impl shadow: interface-typed view/mgr calls dispatch to the
  explicit impls (which returned default!), shadowing public stubs. Fixed
  IBattlePlayerView.GetSideLogControl (SkillProcessor side-log tail) to return a
  non-null no-op. KEY M3+ learning: fix _IfaceImpl.g.cs for interface-typed NREs.

(GameMgr/component-model/Resources/IClassBattleCardView shim fills + CardIconControl
copy + the SVSim.BattleEngine.Tests project landed in the prior commit 2b50657.)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
gamer147
2026-06-06 01:57:15 -04:00
parent 2b506574e7
commit 171f07ec74
7 changed files with 370 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
SVSim.BattleEngine/Engine/Wizard.Battle.View.Vfx/NotEmptyNullVfx.cs Normal file
View File

@@ -0,0 +1,21 @@
namespace Wizard.Battle.View.Vfx;
public class NotEmptyNullVfx : VfxBase
{
private static NotEmptyNullVfx _instance;
public override bool IsEnd => true;
public static NotEmptyNullVfx GetInstance()
{
if (_instance == null)
{
_instance = new NotEmptyNullVfx();
}
return _instance;
}
protected NotEmptyNullVfx()
{
}
}

236
SVSim.BattleEngine/Engine/Wizard.Battle.View.Vfx/NullCardVfxCreator.cs Normal file
View File

@@ -0,0 +1,236 @@
using UnityEngine;
namespace Wizard.Battle.View.Vfx;
public class NullCardVfxCreator : ICardVfxCreator
{
private static NullCardVfxCreator m_instance;
public static NullCardVfxCreator GetInstance()
{
if (m_instance == null)
{
m_instance = new NullCardVfxCreator();
}
return m_instance;
}
private NullCardVfxCreator()
{
}
public VfxBase CreateDraw(Vector3 pos, bool isCardRare)
{
return NullVfx.GetInstance();
}
public VfxBase CreatePick()
{
return NullVfx.GetInstance();
}
public VfxBase CreateDestroy(BattleCardBase.DeathTypeInformation deathTypes, BattlePlayerBase battlePlayerBase)
{
return NullVfx.GetInstance();
}
public VfxBase CreateDestroyHand(BattleCardBase.DeathTypeInformation deathTypes, BattlePlayerBase battlePlayerBase)
{
return NullVfx.GetInstance();
}
public VfxBase CreateBanish(BattleCardBase.DeathTypeInformation deathTypes, BattlePlayerBase battlePlayerBase)
{
return NullVfx.GetInstance();
}
public VfxWithLoading CreateBanishHand(BattleCardBase.DeathTypeInformation deathTypes, BattlePlayerBase battlePlayerBase)
{
return NullVfxWithLoading.GetInstance();
}
public VfxBase CreateGeton(Transform vehicleCardTrans, IBattleCardView vehicleCardView, BattleCardBase.DeathTypeInformation deathTypes, BattlePlayerBase battlePlayerBase)
{
return NullVfxWithLoading.GetInstance();
}
public VfxWithLoading CreateFusionHand(BattlePlayerBase battlePlayerBase, IBattleCardView fusionCard, bool isFusionMetamorphose)
{
return NullVfxWithLoading.GetInstance();
}
public VfxBase CreateParameterChange(BattleCardBase.ParameterChangeInformation parameterChangeInfo, bool isDead, bool isEvolve, bool skipWait)
{
return NullVfx.GetInstance();
}
public VfxBase CreateBuffStart(BattleCardBase.ParameterChangeInformation parameterChangeInfo, bool useWait = true)
{
return NullVfx.GetInstance();
}
public VfxBase CreateBuffStop(BattleCardBase.ParameterChangeInformation parameterChangeInfo, bool useWait = true)
{
return NullVfx.GetInstance();
}
public VfxBase CreateDebuffStart(BattleCardBase.ParameterChangeInformation parameterChangeInfo, bool useWait = true)
{
return NullVfx.GetInstance();
}
public VfxBase CreateDebuffStop(BattleCardBase.ParameterChangeInformation parameterChangeInfo, bool useWait = true)
{
return NullVfx.GetInstance();
}
public VfxBase CreateBuffStartInHand(BattleCardBase.ParameterChangeInformation parameterChangeInfo, bool useWait = true, bool isDebuff = false)
{
return NullVfx.GetInstance();
}
public VfxBase CreateGuardStart()
{
return NullVfx.GetInstance();
}
public VfxBase CreateGuardStop()
{
return NullVfx.GetInstance();
}
public VfxBase CreateKillerStart()
{
return NullVfx.GetInstance();
}
public VfxBase CreateKillerStop()
{
return NullVfx.GetInstance();
}
public VfxBase CreateProtectionStart(ProtectionColorType tyep)
{
return NullVfx.GetInstance();
}
public VfxBase CreateProtectionStop()
{
return NullVfx.GetInstance();
}
public VfxBase CreateNotBeAttackedStart()
{
return NullVfx.GetInstance();
}
public VfxBase CreateNotBeAttackedStop()
{
return NullVfx.GetInstance();
}
public VfxBase CreateUntouchableStart()
{
return NullVfx.GetInstance();
}
public VfxBase CreateUntouchableStop()
{
return NullVfx.GetInstance();
}
public VfxBase CreateQuick(bool hasAttacksRemaining, bool isCardUnableToAttackClass)
{
return NullVfx.GetInstance();
}
public VfxBase CreateSneakStart()
{
return NullVfx.GetInstance();
}
public VfxBase CreateSneakStop()
{
return NullVfx.GetInstance();
}
public VfxBase CreateForceCantAttackStart()
{
return NullVfx.GetInstance();
}
public VfxBase CreateForceCantAttackStop()
{
return NullVfx.GetInstance();
}
public VfxBase CreateDrainStart()
{
return NullVfx.GetInstance();
}
public VfxBase CreateDrainStop()
{
return NullVfx.GetInstance();
}
public VfxBase CreateAttack(IBattleCardView attackCardView, IBattleCardView attackTargetCardView)
{
return NullVfx.GetInstance();
}
public VfxBase CreateAttackFloatUp()
{
return NullVfx.GetInstance();
}
public VfxBase CreateAttackFloatDown(bool isAttacker, bool isDead, int attackableCount)
{
return NullVfx.GetInstance();
}
public VfxBase CreateMoving(Vector3 pos)
{
return NullVfx.GetInstance();
}
public VfxBase CreateDamage(int damage, int currentHealth, int maxHealth, int baseHealth, bool isReflectedDamage, bool IsSkillDamage)
{
return NotEmptyNullVfx.GetInstance();
}
public VfxBase CreateHealing(int healAmount, int currentHealth, int maxHealth, int baseHealth)
{
return NullVfx.GetInstance();
}
public VfxBase CreateMaskCardInPlay()
{
return NullVfx.GetInstance();
}
public VfxBase CreateReflectionStart()
{
return NullVfx.GetInstance();
}
public VfxBase CreateReflectionStop()
{
return NullVfx.GetInstance();
}
public VfxBase CreateHeavenlyAegisStart()
{
return NullVfx.GetInstance();
}
public VfxBase CreateHeavenlyAegisStop()
{
return NullVfx.GetInstance();
}
public VfxBase CreateChangeAffiliation(BattleCardBase card, CardBasePrm.ClanType clan, bool showEffect)
{
return NullVfx.GetInstance();
}
}