para - Mattstop Git

para merged pull request TeamLucker/LuckerGame#2

2023-08-07 05:13:13 +00:00

feature/Lucker-misc_RoundFramework

para commented on pull request TeamLucker/LuckerGame#2

2023-08-07 05:12:22 +00:00

feature/Lucker-misc_RoundFramework

Woops thought it was close -> merge and not the other way around

para reopened pull request TeamLucker/LuckerGame#2

2023-08-07 05:11:49 +00:00

feature/Lucker-misc_RoundFramework

para closed pull request TeamLucker/LuckerGame#2

2023-08-07 05:11:43 +00:00

feature/Lucker-misc_RoundFramework

para commented on pull request TeamLucker/LuckerGame#2

2023-08-07 05:11:35 +00:00

feature/Lucker-misc_RoundFramework

LGTM merging. I've never done this before but I'm assuming we use the default option and not squash or whatever.

para commented on pull request TeamLucker/LuckerGame#2

2023-08-07 05:05:36 +00:00

feature/Lucker-misc_RoundFramework

Yeah that's what I thought. I asked it and it just confidently lies about it and doesn't admit it's wrong. [I found this stack overflow article on the topic and they just suggest a setValue()…

para approved TeamLucker/LuckerGame#3

2023-08-05 04:52:23 +00:00

fixed-camera

LGTM

para deleted branch fps-test from TeamLucker/LuckerGame

2023-08-05 04:12:22 +00:00

para suggested changes for TeamLucker/LuckerGame#2

2023-08-05 04:02:49 +00:00

feature/Lucker-misc_RoundFramework

Couple questions and actionable comments

para commented on pull request TeamLucker/LuckerGame#2

2023-08-05 03:59:40 +00:00

feature/Lucker-misc_RoundFramework

Can we iron out the definition of Round now?

para commented on pull request TeamLucker/LuckerGame#2

2023-08-05 03:59:40 +00:00

feature/Lucker-misc_RoundFramework

Shouldn't this be on MinigamesPerRound and not MinigamesLeftInRound?

para commented on pull request TeamLucker/LuckerGame#2

2023-08-05 03:59:40 +00:00

feature/Lucker-misc_RoundFramework

Should we clear InvolvedPlayers here?

para commented on pull request TeamLucker/LuckerGame#2

2023-08-05 03:59:40 +00:00

feature/Lucker-misc_RoundFramework

nit: more readable on separate lines

para commented on pull request TeamLucker/LuckerGame#2

2023-08-05 03:59:40 +00:00

feature/Lucker-misc_RoundFramework

I think this correctly caches the Lucker list when the minigame is created, which is nice. Although I'm wondering how we deal with Luckers who leave before a minigame is ended. If there's other logic that deletes a Lucker in response to the client disconnecting, will the logic in CleanupPlayerPawns() fail / crash?