TeamLucker/LuckerGame
3
0
Fork 0
Code Issues 2 Pull Requests 1 Projects Releases Wiki Activity

start_round with minigame name #1

Merged
conco merged 3 commits from terry-races into master 2023-08-03 06:15:15 +00:00
Conversation 1 Commits 3 Files Changed 2 +26 -18
fork commented 2023-08-03 05:57:33 +00:00
Member
Copy Link

Adding ability to start minigame round from console by providing the Library name of the minigame's class.

IE: start_round mg_russian_roulette

Adding ability to start minigame round from console by providing the Library name of the minigame's class. IE: `start_round mg_russian_roulette`
fork added 2 commits 2023-08-03 05:57:34 +00:00
start_round by minigame name 5c0a454b79
getting rid of unnecessary lines 35be78c341
conco requested changes 2023-08-03 06:06:13 +00:00
code/Entities/RoundManager.cs Outdated
@@ -122,2 +122,3 @@
Players = All.OfType<Lucker>().ToList();
MinigameManager.StartRandomMinigame( Players );
if ( string.IsNullOrEmpty( minigameName ) )
conco commented 2023-08-03 05:59:53 +00:00
Owner
Copy Link

Just pass in minigameName, we check if it's null so either it's null and we pass null or we dont pass null and it's stil null.

Just pass in minigameName, we check if it's null so either it's null and we pass null or we dont pass null and it's stil null.
fork commented 2023-08-03 06:12:52 +00:00
Author
Member
Copy Link

DONE

DONE
fork marked this conversation as resolved
fork added 1 commit 2023-08-03 06:12:36 +00:00
shortening StartRound ef88c51454
fork requested review from conco 2023-08-03 06:13:04 +00:00
fork changed title from WIP: terry-races to WIP: start_round with minigame name 2023-08-03 06:14:49 +00:00
fork changed title from WIP: start_round with minigame name to start_round with minigame name 2023-08-03 06:14:52 +00:00
conco merged commit 39b9f71801 into master 2023-08-03 06:15:15 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
conco
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
conco fork para
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: TeamLucker/LuckerGame#1
Delete Branch "terry-races"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?