- IBattleXpService.GrantAsync mutates viewer.Classes in place; caller SaveChanges - Resolves win/loss amount from per-mode override or global XpPerWin/XpPerLoss - Story mode ignores isWin, uses StoryXpPerClear ?? XpPerWin - Level-up loop consults curve[row.Level].NecessaryExp; carries overflow - Saturates at max curve level (excess piles in Exp) - Unknown classId → no-op returning (0, 0, 1), logs Warning - 10 unit tests (Moq-backed curve stub); DI registered next to InventoryService - GameConfigurationJsonbTests baseline updated (19 sections) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
37 lines
1.6 KiB
C#
37 lines
1.6 KiB
C#
using SVSim.Database.Models;
|
|
|
|
namespace SVSim.Database.Services.BattleXp;
|
|
|
|
/// <summary>
|
|
/// Amounts returned to callers after a class-XP grant. <see cref="TotalXp"/> and
|
|
/// <see cref="Level"/> are POST-grant, POST-level-up (matching the wire shape's
|
|
/// <c>class_experience</c> + <c>class_level</c> post-state semantics).
|
|
/// </summary>
|
|
public sealed record BattleXpGrantResult(int GetXp, int TotalXp, int Level);
|
|
|
|
public interface IBattleXpService
|
|
{
|
|
/// <summary>
|
|
/// Grants class XP for a battle finish. Caller supplies a viewer loaded via
|
|
/// <see cref="Repositories.Viewer.IViewerRepository.LoadForBattleXpGrantAsync"/>
|
|
/// (or equivalent, with <c>.Include(v => v.Classes).ThenInclude(c => c.Class)</c>).
|
|
/// Caller <c>SaveChangesAsync</c> after this returns.
|
|
/// <para>
|
|
/// Amount resolution: mode-specific config override if non-null, else global
|
|
/// <c>XpPerWin</c>/<c>XpPerLoss</c>. Story ignores <paramref name="isWin"/> (always
|
|
/// treated as a clear).
|
|
/// </para>
|
|
/// <para>
|
|
/// Level-up: loops on <c>ClassExpEntry</c> curve; <c>row.Exp</c> stores level-relative
|
|
/// XP and carries overflow after each level-up. Saturates at curve max level (excess
|
|
/// piles in <c>Exp</c>).
|
|
/// </para>
|
|
/// <para>
|
|
/// Guardrail: viewer has no <see cref="ViewerClassData"/> row for
|
|
/// <paramref name="classId"/> → returns <c>(0, 0, 1)</c>, no mutation, logs Warning.
|
|
/// </para>
|
|
/// </summary>
|
|
Task<BattleXpGrantResult> GrantAsync(
|
|
Viewer viewer, int classId, bool isWin, BattleXpMode mode, CancellationToken ct = default);
|
|
}
|