Files
SVSimServer/SVSim.BattleEngine/Engine/Wizard/InCompleteDeckDecideDialog.cs
gamer147 2d9a6eea4b engine cleanup passes 4-7 + multi-instancing ambient rip
Squashes 146 commits from battle-engine-extraction. Net: 2,045 files changed,
+11,896 / -158,687 lines. Ships engine passes 4-7 (dead-code cull, view-layer
stub, receive-path shrink) plus the Phase-5 AsyncLocal ambient deletion that
turns concurrent battles into a type-system property rather than a scope
contract.

## What landed

**Passes 4-7 (chunks 1-34):** Extended the Phase-4 const-false collapse into a
cascading cull across the skill graph, view layer, and receive-path periphery.
Six mode flags (IsWatchBattle/IsReplayBattle/IsAdmin/IsAdminWatch/IsPuzzleQuest/
IsAINetwork) became `const false`, every guarded block deleted. Field*.cs
subclass ctors + BackGroundBase + ObjectChecker culled to no-ops. Mulligan
family reworked to take a mgr param through IMulliganMgr.InitMulligan.
Emotion/Recovery/Resource clusters null-stubbed. Prediction/OperationSimulator/
skill filters converted from static ambient reads to per-mgr reads via
SkillPrm.ownerCard.SelfBattlePlayer.BattleMgr / ins.BattleMgr / this.BattleMgr.

**Phase-5 ambient rip (chunks 35-47):** Deleted BattleAmbient / BattleAmbient-
Context / TestBattleScope in full. Every per-battle mutable slot now lives on
the mgr instance itself:
  mgr.InstanceIsForecast / InstanceIsRandomDraw / InstanceRecoveryInfo /
  InstanceViewerId / InstanceNetworkAgent / GameMgr
BattleManagerBase.GetIns() returns null unconditionally; the residual static
flags + 3 façades (Certification.ViewerId, Data.BattleRecoveryInfo,
ToolboxGame.RealTimeNetworkAgent) are null-tolerant defaults kept for the
handful of engine-internal readers that still reference their types. Zero
BattleAmbient references anywhere in engine + node + tests.

Added pre-seeded GameMgr ctor overload threaded through the mgr chain
(BattleManagerBase → SingleBattleMgr / NetworkBattleManagerBase → NetworkStandard-
BattleMgr → HeadlessBattleMgr / HeadlessNetworkBattleMgr). Fixtures build a
GameMgr, seed it via HeadlessEngineEnv.SeedCharaIds/SeedNetUser, and pass it
to the mgr's ctor — no ambient reach.

Node side (SVSim.BattleNode/SessionBattleEngine): _ctx replaced with a plain
GameMgr field; 34 `using var _ambient = BattleAmbient.Enter(_ctx)` scope wraps
ripped from every accessor and mutator; EngineGlobalInit.WirePerSessionGameMgr
takes GameMgr as a param and runs from SessionBattleEngine.SetupInternal
BEFORE mgr construction.

Test side: TestBattleScope deleted; 18 fixture [SetUp]s migrated to
`HeadlessEngineEnv.EnsureProcessGlobals()`; MultiInstanceEngineTests rewritten
around per-mgr construction (GetIns() → null is the pinned invariant).

## Regression fixes

- **chunk-48** (MulliganCtrl): chunk-35's `= null` stubs on card lookups broke
  the live receive-driven Deal path (BattlePlayerBase.DrawCard NRE'd downstream
  of NetworkPlayerMulliganCtrl.StartMulliganVfx). Restored the three lookups
  via `_battlePlayer.BattleMgr.GetBattleCardIdx`. Engine tests were satisfied
  by the WireMulliganPhase seam; unit tests exposed the live-path gap.

## Ship state

- SVSim.BattleEngine.Tests: 56/56 pass, 2 skip
- SVSim.UnitTests: 1554/1554 pass (was 1523/31-fail before chunk 48)
- Solution build: 0 source warnings (40 pre-existing NU1902 MessagePack CVEs
  in SVSim.EmulatedEntrypoint, unrelated)
- Sequential PVP smoke: verified live (two back-to-back battles, no regression
  on cleanup/spinup)
- Concurrent PVP smoke: verified live

Adds tools/engine-port/ClosureAnalyzer/ — the Roslyn transitive-type-closure
analyzer needed to make future cascade cleanup safe (per feedback memory
"Engine cleanup needs closure tool" from the 2026-06-28 pass-3 failure).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-07-03 19:18:54 -04:00

116 lines
4.2 KiB
C#

using System;
using Cute;
using Wizard.DeckCardEdit;
namespace Wizard;
public static class InCompleteDeckDecideDialog
{
public static void Create(DialogBase dialogDeckList, DeckData deck, ConventionDeckList conventionDeckList = null, bool canUseNonPossessionCard = false, Action<UIManager.ViewScene> unusableDeckChangeViewSceneAction = null)
{
DeckData.UnusableReason reason;
if (deck.IsNoCard())
{
Action onStartChangeViewScene = delegate
{
dialogDeckList.CloseWithoutSelect();
};
DeckCreateMenuUI.ShowDeckCreateMenu(deck, conventionDeckList, onStartChangeViewScene);
}
else if (!deck.IsUsable(out reason, canUseNonPossessionCard))
{
CreateUnusableDeckDialog(deck, conventionDeckList, reason, unusableDeckChangeViewSceneAction, dialogDeckList);
}
}
private static void CreateUnusableDeckDialog(DeckData deck, ConventionDeckList conventionDeckList, DeckData.UnusableReason unusableReason, Action<UIManager.ViewScene> changeViewSceneAction, DialogBase dialogDeckList)
{
if (unusableReason == DeckData.UnusableReason.MaintenanceCard && deck.IsRentalDeck)
{
DialogBase dialogBase = UIManager.GetInstance().CreateConfirmationDialog(Data.SystemText.Get("Story_0060"));
dialogBase.SetButtonLayout(DialogBase.ButtonLayout.CloseBtn);
dialogBase.SetTitleLabel(Data.SystemText.Get("System_0022"));
dialogBase.SetPanelDepth(100);
return;
}
(string, string) textsUnusableDeckDialog = GetTextsUnusableDeckDialog(unusableReason);
DialogBase dialogBase2 = UIManager.GetInstance().CreateDialogClose();
dialogBase2.SetTitleLabel(textsUnusableDeckDialog.Item1);
dialogBase2.SetText(textsUnusableDeckDialog.Item2);
dialogBase2.SetButtonLayout(DialogBase.ButtonLayout.BlueBtn_CancelBtn);
dialogBase2.SetButtonText(Data.SystemText.Get("Dia_DeckSelect_002_Button"));
dialogBase2.onPushButton1 = delegate
{
if (Data.MaintenanceCodeList.Contains(NetworkDefine.MAINTENANCE_TYPE.DECK_MAINTENANCE))
{
}
else
{
DeckCardEditUI.SetDeckEditParameter(deck, conventionDeckList);
dialogDeckList.CloseWithoutSelect();
if (changeViewSceneAction != null)
{
changeViewSceneAction(UIManager.ViewScene.DeckCardEdit);
}
else
{
UIManager.ChangeViewSceneParam param = new UIManager.ChangeViewSceneParam
{
IsUpdateFooterMenuTexture = true
};
UIManager.GetInstance().ChangeViewScene(UIManager.ViewScene.DeckCardEdit, param);
}
}
};
dialogBase2.ClickSe_Btn1 = 0;
dialogBase2.SetPanelDepth(100);
}
private static (string title, string body) GetTextsUnusableDeckDialog(DeckData.UnusableReason unusableReason)
{
string item = string.Empty;
string item2 = string.Empty;
switch (unusableReason)
{
case DeckData.UnusableReason.MaintenanceCard:
item = Data.SystemText.Get("System_0022");
item2 = Data.SystemText.Get("System_0039");
break;
case DeckData.UnusableReason.FormatRestrictCard:
item = Data.SystemText.Get("Dia_DeckSelect_004_Title");
item2 = Data.SystemText.Get("Card_0192");
break;
case DeckData.UnusableReason.TooLittleCards:
item = Data.SystemText.Get("Dia_DeckSelect_002_Title");
item2 = Data.SystemText.Get("Card_0069");
break;
case DeckData.UnusableReason.TooMuchCards:
item = Data.SystemText.Get("Dia_DeckSelect_003_Title");
item2 = Data.SystemText.Get("Card_0140");
break;
case DeckData.UnusableReason.NonPossessionCard:
item = Data.SystemText.Get("Dia_DeckSelect_004_Title");
item2 = Data.SystemText.Get("Card_0254");
break;
case DeckData.UnusableReason.ShortageMainClassCards:
item = Data.SystemText.Get("Dia_DeckSelect_005_Title");
item2 = Data.SystemText.Get("Card_0289");
break;
case DeckData.UnusableReason.ShortageSubClassCards:
item = Data.SystemText.Get("Dia_DeckSelect_006_Title");
item2 = Data.SystemText.Get("Card_0290");
break;
case DeckData.UnusableReason.ShortageBothClassCards:
item = Data.SystemText.Get("Dia_DeckSelect_007_Title");
item2 = Data.SystemText.Get("Card_0291");
break;
case DeckData.UnusableReason.Unknown:
Debug.LogError("unknown deck unusable reason.");
break;
}
return (title: item, body: item2);
}
}