e98bd10dbe
Live two-client run (data_dumps/captures/battle_test) exposed a turn-handover
stall: ending a turn on client A made BOTH clients show A's turn again; the
opponent never got a turn. Root cause: JudgeHandler routed the {spin:0} Judge to
ctx.Other. The client rule is 'receive opponent TurnEnd -> SendJudge', so the
PASSIVE player (the one taking over the turn) is the Judge sender, and 'receive
Judge -> ControlTurnStartPlayer' starts the RECEIVER's turn. Routing to ctx.Other
delivered the Judge to the player who had just ended their turn, restarting it in
a closed loop while the taker-over sat on 'Opponent's Turn'.
Fix: the PvP Judge {spin} reflects back to ctx.From (the sender / turn taker-over),
matching the Bot arm's existing 'Judge to sender only' handover. The sender then
emits TurnStart, which relays to the opponent as {spin}. Updated the dispatch unit
test and the PvpHandshakeAndGameplay integration test to the real handover order
(passive sends Judge -> receives it back -> sends TurnStart -> opponent sees it).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
SVSim.BattleNode
Socket.IO node-server emulation for in-battle real-time traffic — the second of prod's 4-server
topology. Handles Matched / BattleStart / Deal / per-action PlayActions / Echo /
TurnEnd between a client and a server-side opponent, for TK2 PvP and AI rank battles.
Documentation lives in the outer repo
This project's canonical reference is a single hub doc in the outer SVSim repo (this directory is an inner git repo, so the doc isn't tracked alongside the code):
→ docs/battle-node.md (from the SVSim root) — architecture, the dispatch matrix by battle
type, connect handshake + crypto, BattleFinish wire-result semantics, SIO/EIO event coverage,
reliability (pubSeq/playSeq/Gungnir), wire-format gotchas, where-to-extend, the manual smoke
walkthrough, and the consolidated open-items list.
Relative path from here: ../../../docs/battle-node.md.
Detailed per-URI wire shapes are in docs/api-spec/in-battle/; the hub links into them.
Keep docs/battle-node.md updated in the same change whenever you alter node behavior.