feat(battle-node): add OutboundSequencer.Clear() for terminate cascade

Audit Md11 (part 2 of 2). Adds an explicit Clear() so BattleSession can
release the archive at battle-end instead of waiting for the participant to
be GC'd. _next is intentionally NOT reset — a post-Clear emit is a bug per
the design, but the seq stream must stay monotonic if it does happen.

Tests cover empty archive after Clear, _next preservation across Clear,
and Clear-on-empty no-op. The BattleSession integration that calls Clear
lands in the next commit.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
gamer147
2026-06-02 13:07:00 -04:00
parent 3991bcc653
commit 10d9f74d05
2 changed files with 46 additions and 0 deletions

View File

@@ -24,4 +24,13 @@ public sealed class OutboundSequencer
public MsgEnvelope WrapNoStock(MsgEnvelope envelope) =>
envelope with { PlaySeq = null };
/// <summary>
/// Drop all archived envelopes. Called from BattleSession's terminate cascade so
/// the archive — the heavy state — is released the moment the battle ends, rather
/// than waiting for the participant to be GC'd. <c>_next</c> is left untouched:
/// a participant emitting after Clear is a bug, not a recovery case, but the seq
/// stream stays monotonic so a stray emit doesn't silently re-use a playSeq value.
/// </summary>
public void Clear() => _archive.Clear();
}

View File

@@ -49,4 +49,41 @@ public class OutboundSequencerTests
Assert.That(seq.Archive.Keys, Is.EquivalentTo(new[] { 1L, 2L }));
Assert.That(seq.Archive[1L].Uri, Is.EqualTo(NetworkBattleUri.Matched));
}
[Test]
public void Clear_empties_archive()
{
var seq = new OutboundSequencer();
seq.AssignAndArchive(MakeEnvelope(NetworkBattleUri.Matched));
seq.AssignAndArchive(MakeEnvelope(NetworkBattleUri.BattleStart));
seq.Clear();
Assert.That(seq.Archive, Is.Empty);
}
[Test]
public void Clear_does_not_reset_next_seq()
{
// A post-Clear emit is a bug per the design (terminate has already fired),
// but the impl must keep the seq stream monotonic if it does happen — no
// silent re-use of playSeq=1 against a different envelope.
var seq = new OutboundSequencer();
seq.AssignAndArchive(MakeEnvelope(NetworkBattleUri.Matched)); // playSeq=1
seq.AssignAndArchive(MakeEnvelope(NetworkBattleUri.BattleStart)); // playSeq=2
seq.Clear();
var post = seq.AssignAndArchive(MakeEnvelope(NetworkBattleUri.Deal));
Assert.That(post.PlaySeq, Is.EqualTo(3), "_next must continue, not reset, after Clear.");
}
[Test]
public void Clear_on_empty_sequencer_is_noop()
{
var seq = new OutboundSequencer();
Assert.DoesNotThrow(() => seq.Clear());
Assert.That(seq.Archive, Is.Empty);
}
}