Files
SVSimServer/SVSim.BattleEngine/Engine/SlideObjectReceiveControl.cs
gamer147 2d9a6eea4b engine cleanup passes 4-7 + multi-instancing ambient rip
Squashes 146 commits from battle-engine-extraction. Net: 2,045 files changed,
+11,896 / -158,687 lines. Ships engine passes 4-7 (dead-code cull, view-layer
stub, receive-path shrink) plus the Phase-5 AsyncLocal ambient deletion that
turns concurrent battles into a type-system property rather than a scope
contract.

## What landed

**Passes 4-7 (chunks 1-34):** Extended the Phase-4 const-false collapse into a
cascading cull across the skill graph, view layer, and receive-path periphery.
Six mode flags (IsWatchBattle/IsReplayBattle/IsAdmin/IsAdminWatch/IsPuzzleQuest/
IsAINetwork) became `const false`, every guarded block deleted. Field*.cs
subclass ctors + BackGroundBase + ObjectChecker culled to no-ops. Mulligan
family reworked to take a mgr param through IMulliganMgr.InitMulligan.
Emotion/Recovery/Resource clusters null-stubbed. Prediction/OperationSimulator/
skill filters converted from static ambient reads to per-mgr reads via
SkillPrm.ownerCard.SelfBattlePlayer.BattleMgr / ins.BattleMgr / this.BattleMgr.

**Phase-5 ambient rip (chunks 35-47):** Deleted BattleAmbient / BattleAmbient-
Context / TestBattleScope in full. Every per-battle mutable slot now lives on
the mgr instance itself:
  mgr.InstanceIsForecast / InstanceIsRandomDraw / InstanceRecoveryInfo /
  InstanceViewerId / InstanceNetworkAgent / GameMgr
BattleManagerBase.GetIns() returns null unconditionally; the residual static
flags + 3 façades (Certification.ViewerId, Data.BattleRecoveryInfo,
ToolboxGame.RealTimeNetworkAgent) are null-tolerant defaults kept for the
handful of engine-internal readers that still reference their types. Zero
BattleAmbient references anywhere in engine + node + tests.

Added pre-seeded GameMgr ctor overload threaded through the mgr chain
(BattleManagerBase → SingleBattleMgr / NetworkBattleManagerBase → NetworkStandard-
BattleMgr → HeadlessBattleMgr / HeadlessNetworkBattleMgr). Fixtures build a
GameMgr, seed it via HeadlessEngineEnv.SeedCharaIds/SeedNetUser, and pass it
to the mgr's ctor — no ambient reach.

Node side (SVSim.BattleNode/SessionBattleEngine): _ctx replaced with a plain
GameMgr field; 34 `using var _ambient = BattleAmbient.Enter(_ctx)` scope wraps
ripped from every accessor and mutator; EngineGlobalInit.WirePerSessionGameMgr
takes GameMgr as a param and runs from SessionBattleEngine.SetupInternal
BEFORE mgr construction.

Test side: TestBattleScope deleted; 18 fixture [SetUp]s migrated to
`HeadlessEngineEnv.EnsureProcessGlobals()`; MultiInstanceEngineTests rewritten
around per-mgr construction (GetIns() → null is the pinned invariant).

## Regression fixes

- **chunk-48** (MulliganCtrl): chunk-35's `= null` stubs on card lookups broke
  the live receive-driven Deal path (BattlePlayerBase.DrawCard NRE'd downstream
  of NetworkPlayerMulliganCtrl.StartMulliganVfx). Restored the three lookups
  via `_battlePlayer.BattleMgr.GetBattleCardIdx`. Engine tests were satisfied
  by the WireMulliganPhase seam; unit tests exposed the live-path gap.

## Ship state

- SVSim.BattleEngine.Tests: 56/56 pass, 2 skip
- SVSim.UnitTests: 1554/1554 pass (was 1523/31-fail before chunk 48)
- Solution build: 0 source warnings (40 pre-existing NU1902 MessagePack CVEs
  in SVSim.EmulatedEntrypoint, unrelated)
- Sequential PVP smoke: verified live (two back-to-back battles, no regression
  on cleanup/spinup)
- Concurrent PVP smoke: verified live

Adds tools/engine-port/ClosureAnalyzer/ — the Roslyn transitive-type-closure
analyzer needed to make future cascade cleanup safe (per feedback memory
"Engine cleanup needs closure tool" from the 2026-06-28 pass-3 failure).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-07-03 19:18:54 -04:00

121 lines
4.6 KiB
C#

using System.Collections;
using UnityEngine;
using Wizard.Battle.View;
using Wizard.Battle.View.Vfx;
public class SlideObjectReceiveControl
{
private NetworkBattleManagerBase _networkBattleMgr;
private GameObject _slideStartObject;
private GameObject _slideEndObject;
private NetworkBattleSender.SLIDE_OBJECT_TYPE _slideObjectType;
private IEnumerator _slideCoroutine;
public SlideObjectReceiveControl(NetworkBattleManagerBase networkBattleMgr)
{
_networkBattleMgr = networkBattleMgr;
}
public void SlideObjectReceiveAction(NetworkBattleReceiver.ReceiveData receivedData)
{
bool isSelf = receivedData.isSelf;
switch (receivedData._slideObjectType)
{
case NetworkBattleSender.SLIDE_OBJECT_TYPE.Cancel:
CancelSlide();
break;
case NetworkBattleSender.SLIDE_OBJECT_TYPE.Attack:
{
BattlePlayerBase battlePlayer2 = _networkBattleMgr.GetBattlePlayer(isSelf);
BattlePlayerBase battlePlayer3 = _networkBattleMgr.GetBattlePlayer(!isSelf);
BattleCardBase indexToCardBase2 = NetworkBattleGenericTool.GetIndexToCardBase(_networkBattleMgr, battlePlayer2, receivedData.idx);
BattleCardBase indexToCardBase3 = NetworkBattleGenericTool.GetIndexToCardBase(_networkBattleMgr, battlePlayer3, receivedData._selectedCardIndex);
if (_slideStartObject != indexToCardBase2.BattleCardView.GameObject)
{
IBattleCardView battleCardView = indexToCardBase2.BattleCardView;
_networkBattleMgr.VfxMgr.RegisterImmediateVfx(SequentialVfxPlayer.Create(NullVfx.GetInstance(), NullVfx.GetInstance()));
_networkBattleMgr.VfxMgr.RegisterSequentialVfx(WaitVfx.Create(0.5f));
}
StartSlide(indexToCardBase2.BattleCardView.GameObject, indexToCardBase3.BattleCardView.GameObject, receivedData._slideObjectType, isSelf, isEvol: false);
break;
}
case NetworkBattleSender.SLIDE_OBJECT_TYPE.Evolve:
{
BattlePlayerBase battlePlayer = _networkBattleMgr.GetBattlePlayer(isSelf);
BattleCardBase indexToCardBase = NetworkBattleGenericTool.GetIndexToCardBase(_networkBattleMgr, battlePlayer, receivedData._selectedCardIndex);
StartSlide(battlePlayer.BattleView.EpIcon, indexToCardBase.BattleCardView.GameObject, receivedData._slideObjectType, isSelf, isEvol: true);
break;
}
default:
Debug.LogError("Invalid Slide Object Type: " + receivedData._slideObjectType);
break;
}
}
public void CancelSlide()
{
if (!(_slideStartObject == null))
{
_networkBattleMgr.VfxMgr.RegisterImmediateVfx(NullVfx.GetInstance());
_networkBattleMgr.VfxMgr.RegisterImmediateVfx(NullVfx.GetInstance());
_slideStartObject = null;
BattleCoroutine.GetInstance().StopCoroutine(_slideCoroutine);
_slideCoroutine = null;
_networkBattleMgr.VfxMgr.RegisterImmediateVfx(NullVfx.GetInstance());
_networkBattleMgr.GameMgr.GetEffectMgr().Stop(GetSlideLockOnEffect());
}
}
private void StartSlide(GameObject startObject, GameObject endObject, NetworkBattleSender.SLIDE_OBJECT_TYPE slideObjectType, bool isTargettingEnemy, bool isEvol)
{
if (_slideStartObject != null && _slideStartObject != startObject)
{
CancelSlide();
}
_slideEndObject = endObject;
if (_slideStartObject == null)
{
_slideStartObject = startObject;
_slideObjectType = slideObjectType;
_slideCoroutine = SlideToTarget();
BattlePlayerBase battlePlayer = _networkBattleMgr.GetBattlePlayer(isTargettingEnemy);
if (isEvol)
{
_networkBattleMgr.VfxMgr.RegisterImmediateVfx(NullVfx.GetInstance());
}
_networkBattleMgr.BattlePlayer.PlayerBattleView.DragArrowStart(_networkBattleMgr, startObject, _networkBattleMgr.AttackArrowHead, isTargettingEnemy);
BattleCoroutine.GetInstance().StartCoroutine(_slideCoroutine);
}
EffectMgr.EffectType slideLockOnEffect = GetSlideLockOnEffect();
_networkBattleMgr.GameMgr.GetEffectMgr().Stop(slideLockOnEffect);
_networkBattleMgr.GameMgr.GetEffectMgr().Start(slideLockOnEffect, endObject.transform.position, endObject);
}
private IEnumerator SlideToTarget()
{
while (_slideStartObject != null)
{
_networkBattleMgr.BattlePlayer.PlayerBattleView.DragArrow(_networkBattleMgr, _networkBattleMgr.AttackArrowHead, _slideEndObject.transform.position);
yield return null;
}
}
private EffectMgr.EffectType GetSlideLockOnEffect()
{
switch (_slideObjectType)
{
case NetworkBattleSender.SLIDE_OBJECT_TYPE.Attack:
return EffectMgr.EffectType.CMN_CARD_TARGET_1;
case NetworkBattleSender.SLIDE_OBJECT_TYPE.Evolve:
return EffectMgr.EffectType.CMN_CARD_TARGET_2;
default:
Debug.LogError("Invalid Slide Object Type: " + _slideObjectType);
return EffectMgr.EffectType.CMN_CARD_TARGET_1;
}
}
}