Files
SVSimServer/SVSim.BattleEngine/Engine/BattleFinishResponsProcessing.cs
gamer147 2d9a6eea4b engine cleanup passes 4-7 + multi-instancing ambient rip
Squashes 146 commits from battle-engine-extraction. Net: 2,045 files changed,
+11,896 / -158,687 lines. Ships engine passes 4-7 (dead-code cull, view-layer
stub, receive-path shrink) plus the Phase-5 AsyncLocal ambient deletion that
turns concurrent battles into a type-system property rather than a scope
contract.

## What landed

**Passes 4-7 (chunks 1-34):** Extended the Phase-4 const-false collapse into a
cascading cull across the skill graph, view layer, and receive-path periphery.
Six mode flags (IsWatchBattle/IsReplayBattle/IsAdmin/IsAdminWatch/IsPuzzleQuest/
IsAINetwork) became `const false`, every guarded block deleted. Field*.cs
subclass ctors + BackGroundBase + ObjectChecker culled to no-ops. Mulligan
family reworked to take a mgr param through IMulliganMgr.InitMulligan.
Emotion/Recovery/Resource clusters null-stubbed. Prediction/OperationSimulator/
skill filters converted from static ambient reads to per-mgr reads via
SkillPrm.ownerCard.SelfBattlePlayer.BattleMgr / ins.BattleMgr / this.BattleMgr.

**Phase-5 ambient rip (chunks 35-47):** Deleted BattleAmbient / BattleAmbient-
Context / TestBattleScope in full. Every per-battle mutable slot now lives on
the mgr instance itself:
  mgr.InstanceIsForecast / InstanceIsRandomDraw / InstanceRecoveryInfo /
  InstanceViewerId / InstanceNetworkAgent / GameMgr
BattleManagerBase.GetIns() returns null unconditionally; the residual static
flags + 3 façades (Certification.ViewerId, Data.BattleRecoveryInfo,
ToolboxGame.RealTimeNetworkAgent) are null-tolerant defaults kept for the
handful of engine-internal readers that still reference their types. Zero
BattleAmbient references anywhere in engine + node + tests.

Added pre-seeded GameMgr ctor overload threaded through the mgr chain
(BattleManagerBase → SingleBattleMgr / NetworkBattleManagerBase → NetworkStandard-
BattleMgr → HeadlessBattleMgr / HeadlessNetworkBattleMgr). Fixtures build a
GameMgr, seed it via HeadlessEngineEnv.SeedCharaIds/SeedNetUser, and pass it
to the mgr's ctor — no ambient reach.

Node side (SVSim.BattleNode/SessionBattleEngine): _ctx replaced with a plain
GameMgr field; 34 `using var _ambient = BattleAmbient.Enter(_ctx)` scope wraps
ripped from every accessor and mutator; EngineGlobalInit.WirePerSessionGameMgr
takes GameMgr as a param and runs from SessionBattleEngine.SetupInternal
BEFORE mgr construction.

Test side: TestBattleScope deleted; 18 fixture [SetUp]s migrated to
`HeadlessEngineEnv.EnsureProcessGlobals()`; MultiInstanceEngineTests rewritten
around per-mgr construction (GetIns() → null is the pinned invariant).

## Regression fixes

- **chunk-48** (MulliganCtrl): chunk-35's `= null` stubs on card lookups broke
  the live receive-driven Deal path (BattlePlayerBase.DrawCard NRE'd downstream
  of NetworkPlayerMulliganCtrl.StartMulliganVfx). Restored the three lookups
  via `_battlePlayer.BattleMgr.GetBattleCardIdx`. Engine tests were satisfied
  by the WireMulliganPhase seam; unit tests exposed the live-path gap.

## Ship state

- SVSim.BattleEngine.Tests: 56/56 pass, 2 skip
- SVSim.UnitTests: 1554/1554 pass (was 1523/31-fail before chunk 48)
- Solution build: 0 source warnings (40 pre-existing NU1902 MessagePack CVEs
  in SVSim.EmulatedEntrypoint, unrelated)
- Sequential PVP smoke: verified live (two back-to-back battles, no regression
  on cleanup/spinup)
- Concurrent PVP smoke: verified live

Adds tools/engine-port/ClosureAnalyzer/ — the Roslyn transitive-type-closure
analyzer needed to make future cascade cleanup safe (per feedback memory
"Engine cleanup needs closure tool" from the 2026-06-28 pass-3 failure).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-07-03 19:18:54 -04:00

126 lines
4.7 KiB
C#

using LitJson;
using Wizard;
public class BattleFinishResponsProcessing
{
public void Processing(JsonData ResponseData, MatchFinishBase matchFinishData)
{
matchFinishData.IsProcessed = true;
if (false /* Pre-Phase-5b: no BattleType headless */ && Data.CurrentFormat != Format.Crossover)
{
if (ResponseData["data"].Keys.Contains("target_grand_master_point"))
{
UserRank.IsGrandMasterAvailability = true;
}
else
{
UserRank.IsGrandMasterAvailability = false;
}
}
Data.RedEtherCampaignResultData = null;
if (false /* Pre-Phase-5b: no BattleType headless */)
{
Data.ArenaData.ColosseumData.ResultEffect = ArenaColosseum.eResultEffect.None;
}
RankMatchFinishDetail rankMatchFinishDetail = matchFinishData as RankMatchFinishDetail;
matchFinishData._responseData = ResponseData;
JsonData jsonData = ResponseData["data"];
foreach (string key in jsonData.Keys)
{
JsonData jsonData2 = jsonData[key.ToString()];
if (jsonData2 == null)
{
if (key.ToString() == "user_promotion_match" && UserRank.IsGrandMasterAvailability && PlayerStaticData.IsMasterRankCurrentFormat())
{
Data.Load.data._userRank[(int)Data.CurrentFormat].user_promotion_match.is_promotion = false;
}
continue;
}
switch (key.ToString())
{
case "battle_result":
switch (jsonData2.ToInt())
{
case 0:
matchFinishData.battleResult = BattleManagerBase.BATTLE_RESULT_TYPE.LOSE;
break;
case 1:
matchFinishData.battleResult = BattleManagerBase.BATTLE_RESULT_TYPE.WIN;
break;
case 2:
matchFinishData.battleResult = BattleManagerBase.BATTLE_RESULT_TYPE.CONSISTENCY;
break;
}
/* Pre-Phase-5b: BattleResultType write dropped */
break;
case "get_class_experience":
matchFinishData.get_class_chara_experience = jsonData2.ToInt();
break;
case "class_experience":
matchFinishData.class_chara_experience = jsonData2.ToInt();
break;
case "class_level":
matchFinishData.class_chara_level = jsonData2.ToInt();
break;
case "achieved_info":
matchFinishData.AchievedInfo.Read(jsonData2);
break;
case "is_master_rank":
Data.Load.data._userRank[(int)Data.CurrentFormat].is_master_rank = jsonData2.ToInt() != 0;
break;
case "is_grand_master_rank":
Data.Load.data._userRank[(int)Data.CurrentFormat].is_grand_master_rank = jsonData2.ToInt() != 0;
break;
case "user_promotion_match":
Data.Load.data._userRank[(int)Data.CurrentFormat].user_promotion_match.match_count = jsonData2["match_count"].ToInt();
Data.Load.data._userRank[(int)Data.CurrentFormat].user_promotion_match.battle_result = jsonData2["battle_result"].ToInt();
Data.Load.data._userRank[(int)Data.CurrentFormat].user_promotion_match.win = jsonData2["win"].ToInt();
Data.Load.data._userRank[(int)Data.CurrentFormat].user_promotion_match.lose = jsonData2["lose"].ToInt();
Data.Load.data._userRank[(int)Data.CurrentFormat].user_promotion_match.is_promotion = jsonData2["is_promotion"].ToBoolean();
break;
case "current_grand_master_point":
Data.Load.data._userRank[(int)Data.CurrentFormat].grandMasterData.currentMasterPoint = jsonData2.ToInt();
UserRank.IsGrandMasterAvailability = true;
break;
case "target_grand_master_point":
Data.Load.data._userRank[(int)Data.CurrentFormat].grandMasterData.targetMasterPoint = jsonData2.ToInt();
UserRank.IsGrandMasterAvailability = true;
break;
case "reward_list":
PlayerStaticData.UpdateHaveUserGoodsNumByJsonData(jsonData2);
break;
case "colosseum_special_params":
if (jsonData2.Keys.Contains("next_round"))
{
Data.ArenaData.ColosseumData.ResultEffect = ArenaColosseum.eResultEffect.None;
if (jsonData2["next_round"].ToInt() == 2)
{
Data.ArenaData.ColosseumData.ResultEffect = ArenaColosseum.eResultEffect.GroupA;
}
else if (jsonData2["next_round"].ToInt() == 3)
{
Data.ArenaData.ColosseumData.ResultEffect = ArenaColosseum.eResultEffect.Final;
}
}
else if (jsonData2.Keys.Contains("is_champion") && jsonData2["is_champion"].ToBoolean())
{
Data.ArenaData.ColosseumData.ResultEffect = ArenaColosseum.eResultEffect.Clear;
}
break;
case "red_ether_campagin_info":
Data.RedEtherCampaignResultData = new RedEtherCampaignResultData(jsonData2);
break;
case "battle_dialog_list":
if (rankMatchFinishDetail != null)
{
rankMatchFinishDetail.HomeDialogData = new MyPageHomeDialogData(ResponseData["data"], "battle_dialog_list");
}
break;
case "upgrade_treasure_box_info":
matchFinishData.TreasureBoxCpResultInfo.Parse(jsonData2);
break;
}
}
}
}