Replace bare `int RewardType` on 12 catalog/reward entities and GrantedReward
with the existing UserGoodsType enum. Verified against the decompiled client:
every wire reward_type decodes through the single Wizard.UserGoods.Type enum, so
one enum is correct across all endpoint families (item_type is a separate
Item.Type axis, left untouched). EF stores the enum as the same int column, so
there is no migration.
- Importers cast seed int -> UserGoodsType at the ingest boundary.
- New GrantedReward.ToRewardList() extension replaces 8 copy-pasted
GrantedReward -> RewardListEntry projections.
- Fix 3 .ToString() sites that would otherwise emit enum names ("Crystal")
instead of the int wire value ("2").
- Wire DTOs keep int; the enum is widened to int at the wire boundary only.
Build green; 962/962 tests pass.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
42 lines
1.6 KiB
C#
42 lines
1.6 KiB
C#
using Microsoft.EntityFrameworkCore;
|
|
using Microsoft.Extensions.DependencyInjection;
|
|
using SVSim.Database;
|
|
using SVSim.Database.Enums;
|
|
using SVSim.Database.Services.Inventory;
|
|
using SVSim.UnitTests.Infrastructure;
|
|
|
|
namespace SVSim.UnitTests.Services.Inventory;
|
|
|
|
public class InventoryGrantCurrencyTests
|
|
{
|
|
[TestCase(UserGoodsType.Rupy)]
|
|
[TestCase(UserGoodsType.Crystal)]
|
|
[TestCase(UserGoodsType.RedEther)]
|
|
[TestCase(UserGoodsType.SpotCardPoint)]
|
|
public async Task Grant_currency_adds_and_emits_post_state(UserGoodsType type)
|
|
{
|
|
using var factory = new SVSimTestFactory();
|
|
long viewerId = await factory.SeedViewerAsync();
|
|
using var scope = factory.Services.CreateScope();
|
|
var ctx = scope.ServiceProvider.GetRequiredService<SVSimDbContext>();
|
|
var v = await ctx.Viewers.FirstAsync(x => x.Id == viewerId);
|
|
switch (type)
|
|
{
|
|
case UserGoodsType.Rupy: v.Currency.Rupees = 100; break;
|
|
case UserGoodsType.Crystal: v.Currency.Crystals = 100; break;
|
|
case UserGoodsType.RedEther: v.Currency.RedEther = 100; break;
|
|
case UserGoodsType.SpotCardPoint: v.Currency.SpotPoints = 100; break;
|
|
}
|
|
await ctx.SaveChangesAsync();
|
|
|
|
var inv = scope.ServiceProvider.GetRequiredService<IInventoryService>();
|
|
await using var tx = await inv.BeginAsync(viewerId);
|
|
|
|
var granted = await tx.GrantAsync(type, detailId: 0, num: 50);
|
|
|
|
Assert.That(granted, Has.Count.EqualTo(1));
|
|
Assert.That(granted[0].RewardType, Is.EqualTo(type));
|
|
Assert.That(granted[0].RewardNum, Is.EqualTo(150));
|
|
}
|
|
}
|