SVSim/SVSimServer
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

feat(battle-engine): VFX container Create overloads (2202->1692)

Browse Source 
The hand-shim VFX containers only had no-arg Create(); the engine calls them with
collection/params/loading-main args (510 CS1501). Add the real decomp Create overloads
to SequentialVfxPlayer/ParallelVfxPlayer/VfxWithLoading/VfxWithLoadingSequential.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
gamer147
2026-06-05 22:27:51 -04:00
parent 2ddc86943e
commit fce02a6250
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
SVSim.BattleEngine/Shim/View/VfxShim.cs
View File

@@ -50,6 +50,10 @@ namespace Wizard.Battle.View.Vfx
{
protected readonly List<VfxBase> _children = new List<VfxBase>();
public static SequentialVfxPlayer Create() => new SequentialVfxPlayer();
public static SequentialVfxPlayer Create(IEnumerable<VfxBase> vfxCollection)
{ var p = new SequentialVfxPlayer(); if (vfxCollection != null) p._children.AddRange(vfxCollection); return p; }
public static SequentialVfxPlayer Create(params VfxBase[] vfxCollection)
{ var p = new SequentialVfxPlayer(); if (vfxCollection != null) p._children.AddRange(vfxCollection); return p; }
public void Register(VfxBase vfx) { if (vfx != null) _children.Add(vfx); }
public int Count() => _children.Count;
public override bool IsVfxNonEmpty()
@@ -62,11 +66,17 @@ namespace Wizard.Battle.View.Vfx
public class ParallelVfxPlayer : SequentialVfxPlayer
{
public static new ParallelVfxPlayer Create() => new ParallelVfxPlayer();
public static ParallelVfxPlayer Create(IEnumerable<VfxBase> vfxCollection)
{ var p = new ParallelVfxPlayer(); if (vfxCollection != null) p._children.AddRange(vfxCollection); return p; }
public static ParallelVfxPlayer Create(params VfxBase[] vfxCollection)
{ var p = new ParallelVfxPlayer(); if (vfxCollection != null) p._children.AddRange(vfxCollection); return p; }
}
public class VfxWithLoading : SequentialVfxPlayer
{
public static new VfxWithLoading Create() => new VfxWithLoading();
public static VfxWithLoading Create(VfxBase mainVfx) => new VfxWithLoading();
public static VfxWithLoading Create(VfxBase loadingVfx, VfxBase mainVfx) => new VfxWithLoading();
public virtual VfxBase LoadingVfx => NullVfx.GetInstance();
public virtual VfxBase MainVfx => NullVfx.GetInstance();
}
@@ -74,6 +84,7 @@ namespace Wizard.Battle.View.Vfx
public class VfxWithLoadingSequential : VfxWithLoading
{
public static new VfxWithLoadingSequential Create() => new VfxWithLoadingSequential();
public static VfxWithLoadingSequential Create(params VfxBase[] mainVfxCollection) => new VfxWithLoadingSequential();
public override VfxBase LoadingVfx => NullVfx.GetInstance();
public override VfxBase MainVfx => NullVfx.GetInstance();
public void RegisterToLoadingVfx(VfxBase vfxToRegister) { }