SVSim/SVSimServer
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

refactor(inventory): consolidate IsCurrency, skip num=0 grants in history

Browse Source 
- Drop IsWalletCurrency (duplicate of IsCurrency); use IsCurrency in WriteAcquireHistory.
- Add comment on first SaveChangesAsync in CommitAsync explaining the two-phase flush.
- Guard WriteAcquireHistory loop with grant.Num == 0 check so synthetic DebitItem post-state ops do not produce history rows.
- Add InventoryHistoryTests.Commit_writes_no_history_row_for_item_debit to lock in the fix.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
gamer147
2026-06-09 14:37:50 -04:00
parent bea5a1efd4
commit fb1e6829b7
2 changed files with 28 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
SVSim.Database/Services/Inventory/InventoryTransaction.cs
View File

@@ -276,6 +276,7 @@ internal sealed class InventoryTransaction : IInventoryTransaction
{
ThrowIfCommitted();
// Flush entity mutations first so audit-history rows are staged on top of post-commit state.
await _db.SaveChangesAsync(ct);
WriteAcquireHistory();
@@ -298,10 +299,11 @@ internal sealed class InventoryTransaction : IInventoryTransaction
foreach (var op in _ops)
{
if (op is not GrantOp grant) continue;
if (grant.Num == 0) continue; // skip synthetic post-state grants (e.g. DebitItem)
var rowSource = grant.IsCascade ? GrantSource.CardCosmeticCascade : _source;
var rowMessage = grant.IsCascade ? cascadeMessage : primaryMessage;
var detailId = IsWalletCurrency(grant.Type) ? 0L : grant.DetailId;
var detailId = IsCurrency(grant.Type) ? 0L : grant.DetailId;
_db.ViewerAcquireHistory.Add(new ViewerAcquireHistoryEntry
{
@@ -316,12 +318,6 @@ internal sealed class InventoryTransaction : IInventoryTransaction
}
}
private static bool IsWalletCurrency(UserGoodsType type) => type
is UserGoodsType.Crystal
or UserGoodsType.Rupy
or UserGoodsType.RedEther
or UserGoodsType.SpotCardPoint;
private IReadOnlyList<GrantedReward> BuildRewardList()
{
// Pass 1 — for each currency type, find the last op (spend OR grant) that touched it

25
SVSim.UnitTests/Services/Inventory/InventoryHistoryTests.cs
View File

@@ -195,6 +195,31 @@ public class InventoryHistoryTests
Assert.That(rows[1].Message, Is.EqualTo("Card cosmetic"));
}
[Test]
public async Task Commit_writes_no_history_row_for_item_debit()
{
using var factory = new SVSim.UnitTests.Infrastructure.SVSimTestFactory();
long viewerId = await factory.SeedViewerAsync();
// Seed an item the viewer owns so DebitItem has something to spend.
const int itemId = 5550001;
await factory.SeedOwnedItemAsync(viewerId, itemId, 5);
using var scope = factory.Services.CreateScope();
var inv = scope.ServiceProvider.GetRequiredService<SVSim.Database.Services.Inventory.IInventoryService>();
await using (var tx = await inv.BeginAsync(viewerId, configure: c => c.Source = GrantSource.ItemPurchase))
{
await tx.TryDebitAsync(SVSim.Database.Enums.UserGoodsType.Item, itemId, 1);
await tx.CommitAsync();
}
using var verifyScope = factory.Services.CreateScope();
var ctx2 = verifyScope.ServiceProvider.GetRequiredService<SVSim.Database.SVSimDbContext>();
var rows = await ctx2.ViewerAcquireHistory.AsNoTracking()
.Where(h => h.ViewerId == viewerId).ToListAsync();
Assert.That(rows, Is.Empty, "item debit should not produce a history row");
}
[Test]
public async Task Commit_zero_pads_detail_id_for_wallet_currencies()
{