SVSim/SVSimServer
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

feat(battle-engine-port): M3 COMPLETE — fixed-damage spell resolves headless (leader-life-delta oracle passes)

Browse Source 
Card 900124030 (ELF cost-3, when_play damage=3 to enemy leader) resolves to
correct authoritative state headless via the IsForecast/IsRecovery +
ActionProcessor.PlayCard path. New oracle dimension (opponent leader-life delta)
passes; 3/3 tests green; engine still 0 errors; check_drift clean.

Four headless gaps, each mechanical (no logic/Unity wall):
- Data seam: InitLeaderLife (SetupInitialGameState->InitializeClassLife subset);
  leader BaseMaxLife was 0 => game-over => play silently rejected. M2 missed it
  (only asserted leader life unchanged: 0==0).
- Runtime cast: re-attach IClassBattleCardView on the generated
  NullClassBattleCardView stub (members already present; base-clause recovery
  stripped the decl). Compiled fine -> M1 loop never surfaced it.
- M1 mis-cut: copy NullVfxWithLoading verbatim (its GetInstance() lazy singleton
  was stubbed to default!/null). Same pattern as M2 NullCardVfxCreator.
- Card events: CreateHeadlessHandCard now calls SetupCardEvent so a spell's
  OnPlay->RemoveSpellCardFromHand / OnFinishWhenPlaySkill->AddSpellCardToCemetery
  fire (the bare CreateCardWithoutResources seam skips them).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
gamer147
2026-06-06 02:19:54 -04:00
parent 171f07ec74
commit c47ae93027
7 changed files with 180 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
SVSim.BattleEngine/Shim/Generated/NullVfxWithLoading.g.cs
View File

@@ -1,16 +0,0 @@
// AUTO-GENERATED no-op stubs (m1_stub_gen) from Shadowverse_Code_2026-05-23\Wizard.Battle.View.Vfx\NullVfxWithLoading.cs
using System.Collections.Generic;
namespace Wizard.Battle.View.Vfx
{
public partial class NullVfxWithLoading
{
private static NullVfxWithLoading _instance;
public VfxBase LoadingVfx { get; set; }
public VfxBase MainVfx { get; set; }
public bool IsEnd { get; set; }
public static NullVfxWithLoading GetInstance() => default!;
public void Play() { }
public void Update(float dt, List<IEffectVfx> effectVfxList) { }
public bool IsVfxNonEmpty() => default!;
}
}

1
SVSim.BattleEngine/Shim/Generated/_BaseClauses.g.cs
View File

@@ -101,7 +101,6 @@ namespace Wizard.Battle.View { public partial class NullClassBattleCardView : Nu
namespace Wizard.Battle.View { public partial class NullEnemyBattleView : BattleEnemyView { } }
namespace Wizard.Battle.View { public partial class NullFieldBattleCardView : FieldBattleCardView { } }
namespace Wizard.Battle.View { public partial class NullPlayerBattleView : BattlePlayerView { } }
namespace Wizard.Battle.View.Vfx { public partial class NullVfxWithLoading : VfxWithLoading { } }
namespace Wizard.Battle.View.Vfx { public partial class OneShotHeavenlyAegisPlayVfx : SequentialVfxPlayer { } }
namespace Wizard.Battle.View.Vfx { public partial class OpenCardFromHandVfx : SequentialVfxPlayer { } }
namespace Wizard.Battle.View.Vfx { public partial class OpenCardVfx : SequentialVfxPlayer { } }