SVSim/SVSimServer
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

feat(home-dialog): IGlobalsRepository.GetActiveHomeDialogsAsync

Browse Source 
Window is [begin, end) — exclusive upper bound. Ordered priority-DESC
then Id-ASC so the controller can break on the first match.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
gamer147
2026-06-08 18:52:32 -04:00
parent 7a82f4e189
commit 6d60edaa2a
3 changed files with 65 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
SVSim.Database/Repositories/Globals/GlobalsRepository.cs
View File

@@ -65,6 +65,13 @@ public class GlobalsRepository : IGlobalsRepository
public Task<List<BannerEntry>> GetBanners() =>
_dbContext.Banners.AsNoTracking().OrderBy(b => b.Id).ToListAsync();
public async Task<IReadOnlyList<HomeDialogEntry>> GetActiveHomeDialogsAsync(DateTime nowUtc) =>
await _dbContext.HomeDialogEntries.AsNoTracking()
.Where(e => e.BeginTime <= nowUtc && e.EndTime > nowUtc)
.OrderByDescending(e => e.Priority)
.ThenBy(e => e.Id)
.ToListAsync();
public Task<ColosseumConfig?> GetCurrentColosseum() =>
_dbContext.Colosseums.AsNoTracking().FirstOrDefaultAsync(e => e.Id == 1);

1
SVSim.Database/Repositories/Globals/IGlobalsRepository.cs
View File

@@ -21,6 +21,7 @@ public interface IGlobalsRepository
Task<List<BattlePassLevelEntry>> GetBattlePassLevels();
Task<List<DailyLoginBonusEntry>> GetDailyLoginBonus();
Task<List<BannerEntry>> GetBanners();
Task<IReadOnlyList<HomeDialogEntry>> GetActiveHomeDialogsAsync(DateTime nowUtc);
Task<ColosseumConfig?> GetCurrentColosseum();
Task<SealedConfig?> GetCurrentSealedSeason();
Task<MasterPointRankingPeriodEntry?> GetCurrentMasterPointPeriod();

57
SVSim.UnitTests/Repositories/GlobalsRepositoryHomeDialogTests.cs Normal file
View File

@@ -0,0 +1,57 @@
using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.DependencyInjection;
using SVSim.Database;
using SVSim.Database.Models;
using SVSim.Database.Repositories.Globals;
using SVSim.UnitTests.Infrastructure;
namespace SVSim.UnitTests.Repositories;
public class GlobalsRepositoryHomeDialogTests
{
[Test]
public async Task GetActiveHomeDialogsAsync_returns_only_rows_inside_window_ordered_by_priority_desc_then_id_asc()
{
using var factory = new SVSimTestFactory();
using var scope = factory.Services.CreateScope();
var db = scope.ServiceProvider.GetRequiredService<SVSimDbContext>();
var repo = scope.ServiceProvider.GetRequiredService<IGlobalsRepository>();
var now = new DateTime(2026, 6, 8, 12, 0, 0, DateTimeKind.Utc);
db.HomeDialogEntries.AddRange(
new HomeDialogEntry { Id = 1, TitleTextId = "past", Image = "i", BeginTime = now.AddDays(-30), EndTime = now.AddDays(-1), Priority = 0 },
new HomeDialogEntry { Id = 2, TitleTextId = "active-lo", Image = "i", BeginTime = now.AddDays(-1), EndTime = now.AddDays(1), Priority = 5 },
new HomeDialogEntry { Id = 3, TitleTextId = "active-hi", Image = "i", BeginTime = now.AddDays(-1), EndTime = now.AddDays(1), Priority = 10 },
new HomeDialogEntry { Id = 4, TitleTextId = "future", Image = "i", BeginTime = now.AddDays(1), EndTime = now.AddDays(30), Priority = 99 },
new HomeDialogEntry { Id = 5, TitleTextId = "active-mid", Image = "i", BeginTime = now.AddDays(-1), EndTime = now.AddDays(1), Priority = 5 }
);
await db.SaveChangesAsync();
var result = await repo.GetActiveHomeDialogsAsync(now);
Assert.That(result.Select(r => r.Id), Is.EqualTo(new[] { 3, 2, 5 }),
"Expected priority-DESC then Id-ASC ordering; only entries whose window covers `now`.");
}
[Test]
public async Task GetActiveHomeDialogsAsync_excludes_row_whose_end_time_equals_now()
{
// Window is [begin, end) — exclusive on the upper bound.
using var factory = new SVSimTestFactory();
using var scope = factory.Services.CreateScope();
var db = scope.ServiceProvider.GetRequiredService<SVSimDbContext>();
var repo = scope.ServiceProvider.GetRequiredService<IGlobalsRepository>();
var now = new DateTime(2026, 6, 8, 12, 0, 0, DateTimeKind.Utc);
db.HomeDialogEntries.Add(new HomeDialogEntry
{
Id = 1, TitleTextId = "just-expired", Image = "i",
BeginTime = now.AddHours(-1), EndTime = now, Priority = 0,
});
await db.SaveChangesAsync();
var result = await repo.GetActiveHomeDialogsAsync(now);
Assert.That(result, Is.Empty);
}
}