refactor(battlenode): rename mode-id field off BattleType, add BattleModes (§D)

Behavior-preserving; 271 BattleNode/Matching/Services tests green, full solution builds.

"BattleType" meant two things: the Sessions.BattleType enum (Pvp/Bot) and an int
"mode id" field. Renamed the int field on MatchContext AND the BattleStartBody wire
DTO to BattleModeId (wire key stays "battleType" via JsonPropertyName), so BattleType
now means only the enum project-wide.

New Bridge/BattleModes.cs (TakeTwo = 11) replaces every 11 literal — both prod
MatchContextBuilder sites and the test fixtures/assertions. The arbitrary-passthrough
42 and bot 0 stay literal.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

SVSim.UnitTests/BattleNode/Sessions/BattleSessionDispatchConcurrencyTests.cs

@@ -64,13 +64,13 @@ public class BattleSessionDispatchConcurrencyTests
         SelfDeckCardIds: Enumerable.Range(1, 30).Select(_ => 100_011_010L).ToList(),
         ClassId: "3", CharaId: "3", CardMasterName: "card_master_node_10015",
         CountryCode: "KOR", UserName: "PlayerA", SleeveId: "3000011",
-        EmblemId: "701441011", DegreeId: "300003", FieldId: 43, IsOfficial: 0, BattleType: 11);
+        EmblemId: "701441011", DegreeId: "300003", FieldId: 43, IsOfficial: 0, BattleModeId: BattleModes.TakeTwo);
 
     private static MatchContext CtxB() => new(
         SelfDeckCardIds: Enumerable.Range(1, 30).Select(_ => 200_011_010L).ToList(),
         ClassId: "5", CharaId: "5", CardMasterName: "card_master_node_10015",
         CountryCode: "JPN", UserName: "PlayerB", SleeveId: "3000022",
-        EmblemId: "701441022", DegreeId: "300004", FieldId: 44, IsOfficial: 0, BattleType: 11);
+        EmblemId: "701441022", DegreeId: "300004", FieldId: 44, IsOfficial: 0, BattleModeId: BattleModes.TakeTwo);
 
     /// <summary>Tracks the peak number of dispatches in flight at once. Records the count under a
     /// short lock, then holds (outside the lock) to widen the overlap window so a serialization bug

SVSim.UnitTests/BattleNode/Sessions/BattleSessionDispatchTests.cs

@@ -894,7 +894,7 @@ public class BattleSessionDispatchTests
         SelfDeckCardIds: Array.Empty<long>(),
         ClassId: "0", CharaId: "0", CardMasterName: "card_master_node_10015",
         CountryCode: "", UserName: "Bot", SleeveId: "0",
-        EmblemId: "0", DegreeId: "0", FieldId: 0, IsOfficial: 0, BattleType: 0);
+        EmblemId: "0", DegreeId: "0", FieldId: 0, IsOfficial: 0, BattleModeId: 0);
 
     [Test]
     public void Bot_InitNetwork_acks_to_sender()
@@ -1051,21 +1051,21 @@ public class BattleSessionDispatchTests
         ClassId: "3", CharaId: "3", CardMasterName: "card_master_node_10015",
         CountryCode: "KOR", UserName: "PlayerA", SleeveId: "3000011",
         EmblemId: "701441011", DegreeId: "300003", FieldId: 43, IsOfficial: 0,
-        BattleType: 11);
+        BattleModeId: BattleModes.TakeTwo);
 
     private static MatchContext PlayerBCtx() => new(
         SelfDeckCardIds: Enumerable.Range(1, 30).Select(_ => 200_011_010L).ToList(),
         ClassId: "5", CharaId: "5", CardMasterName: "card_master_node_10015",
         CountryCode: "JPN", UserName: "PlayerB", SleeveId: "3000022",
         EmblemId: "701441022", DegreeId: "300004", FieldId: 44, IsOfficial: 0,
-        BattleType: 11);
+        BattleModeId: BattleModes.TakeTwo);
 
     private static MatchContext FixtureCtx() => new(
         SelfDeckCardIds: Enumerable.Range(1, 30).Select(_ => 100_011_010L).ToList(),
         ClassId: "1", CharaId: "1", CardMasterName: "card_master_node_10015",
         CountryCode: "KOR", UserName: "Player", SleeveId: "3000011",
         EmblemId: "701441011", DegreeId: "300003", FieldId: 43, IsOfficial: 0,
-        BattleType: 11);
+        BattleModeId: BattleModes.TakeTwo);
 
     private static MsgEnvelope NewEnvelope(NetworkBattleUri uri) =>
         new(uri, ViewerId: 1, Uuid: "u", Bid: null, RetryAttempt: 0,

SVSim.UnitTests/BattleNode/Sessions/BattleSessionStateTests.cs

@@ -24,7 +24,7 @@ public class BattleSessionStateTests
     private static MatchContext Ctx(params long[] deck) => new(
         SelfDeckCardIds: deck, ClassId: "1", CharaId: "1", CardMasterName: "cm",
         CountryCode: "KOR", UserName: "P", SleeveId: "0", EmblemId: "0", DegreeId: "0",
-        FieldId: 0, IsOfficial: 0, BattleType: 11);
+        FieldId: 0, IsOfficial: 0, BattleModeId: BattleModes.TakeTwo);
 
     [Test]
     public void GetOrSeedDeckMap_maps_idx_1based_to_the_shuffled_order()

SVSim.UnitTests/BattleNode/Sessions/BattleSessionTerminateCascadeTests.cs

@@ -54,5 +54,5 @@ public class BattleSessionTerminateCascadeTests
         SelfDeckCardIds: Array.Empty<long>(),
         ClassId: "1", CharaId: "1", CardMasterName: "card_master_node_10015",
         CountryCode: "JP", UserName: "Test", SleeveId: "0",
-        EmblemId: "0", DegreeId: "0", FieldId: 0, IsOfficial: 0, BattleType: 11);
+        EmblemId: "0", DegreeId: "0", FieldId: 0, IsOfficial: 0, BattleModeId: BattleModes.TakeTwo);
 }

SVSim.UnitTests/BattleNode/Sessions/InMemoryBattleSessionStoreTests.cs

@@ -48,5 +48,5 @@ public class InMemoryBattleSessionStoreTests
         ClassId: "1", CharaId: "1", CardMasterName: "card_master_node_10015",
         CountryCode: "KOR", UserName: "Player", SleeveId: "3000011",
         EmblemId: "701441011", DegreeId: "300003", FieldId: 43, IsOfficial: 0,
-        BattleType: 11);
+        BattleModeId: BattleModes.TakeTwo);
 }

SVSim.UnitTests/BattleNode/Sessions/Participants/RealParticipantHandEventTests.cs

@@ -150,5 +150,5 @@ public class RealParticipantHandEventTests
         ClassId: "1", CharaId: "1", CardMasterName: "card_master_node_10015",
         CountryCode: "KOR", UserName: "Player", SleeveId: "3000011",
         EmblemId: "701441011", DegreeId: "300003", FieldId: 43, IsOfficial: 0,
-        BattleType: 11);
+        BattleModeId: BattleModes.TakeTwo);
 }

SVSim.UnitTests/BattleNode/Sessions/Participants/RealParticipantTests.cs

@@ -174,7 +174,7 @@ public class RealParticipantTests
         ClassId: "1", CharaId: "1", CardMasterName: "card_master_node_10015",
         CountryCode: "KOR", UserName: "Player", SleeveId: "3000011",
         EmblemId: "701441011", DegreeId: "300003", FieldId: 43, IsOfficial: 0,
-        BattleType: 11);
+        BattleModeId: BattleModes.TakeTwo);
 
     private static MsgEnvelope NewEnvelope(NetworkBattleUri uri) =>
         new(uri, ViewerId: 1, Uuid: "u", Bid: null, RetryAttempt: 0,