SVSim/SVSimServer
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

test(battle-node): drop dead ViewerId const + refresh stale coverage doc

Browse Source 
Follow-up cleanup to the two-client PvP conformance drive. The class-level
ViewerId const is no longer referenced (both remaining `ViewerId:` sites are
the MsgEnvelope named ctor arg, passing `vid`/literal 1), and the Coverage
doc-comment still described "a single Scripted session" — refresh it to the
two-client PvP reality. No behavior change; tests 2/2 green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
gamer147
2026-06-03 19:37:29 -04:00
parent a916afe924
commit 3feb535072
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
SVSim.UnitTests/BattleNode/Integration/CaptureConformanceTests.cs
View File

@@ -31,19 +31,18 @@ namespace SVSim.UnitTests.BattleNode.Integration;
/// <c>BattleFinish</c> frame is played immediately whether or not it carries a <c>playSeq</c>). /// <c>BattleFinish</c> frame is played immediately whether or not it carries a <c>playSeq</c>).
/// The check is on *body shape*.</para> /// The check is on *body shape*.</para>
/// ///
/// <para><b>Coverage:</b> a single Scripted session emits all ten server-authored URIs /// <para><b>Coverage:</b> a two-client PvP session emits all ten server-authored URIs
/// (<c>InitNetwork, Matched, BattleStart, Deal, Swap, Ready, TurnStart, TurnEnd, Judge, /// (<c>InitNetwork, Matched, BattleStart, Deal, Swap, Ready, TurnStart, TurnEnd, Judge,
/// BattleFinish</c>). PvP uses the same <see cref="SVSim.BattleNode.Lifecycle.ScriptedLifecycle"/> /// BattleFinish</c>). PvP authors the handshake/mulligan frames through the same shared
/// builders for the handshake/mulligan frames, so this transitively covers the PvP handshake shape /// <see cref="SVSim.BattleNode.Lifecycle.ScriptedLifecycle"/> builders, and the turn cycle
/// too. Forwarded frames (<c>PlayActions / TurnEndActions / ChatStamp / TurnEndFinal</c>) relay the /// (<c>TurnStart/TurnEnd/Judge</c>) falls out of the real two-client handover. Forwarded frames
/// (<c>PlayActions / TurnEndActions / ChatStamp / TurnEndFinal</c>) relay the
/// client's own bytes verbatim, so their shape is the client's contract, not ours — out of scope /// client's own bytes verbatim, so their shape is the client's contract, not ours — out of scope
/// here.</para> /// here.</para>
/// </summary> /// </summary>
[TestFixture] [TestFixture]
public class CaptureConformanceTests public class CaptureConformanceTests
{ {
private const long ViewerId = 906243102L;
// Top-level keys that are envelope/transport, not body shape. Excluded from the comparison // Top-level keys that are envelope/transport, not body shape. Excluded from the comparison
// at the root level only (nested objects never contain these). // at the root level only (nested objects never contain these).
private static readonly HashSet<string> IgnoredEnvelopeKeys = new() private static readonly HashSet<string> IgnoredEnvelopeKeys = new()