From 3feb5350723e90c5e29f3a332a2d91803d7e381c Mon Sep 17 00:00:00 2001
From: gamer147 <gamer147@gmail.com>
Date: Wed, 3 Jun 2026 19:37:29 -0400
Subject: [PATCH] test(battle-node): drop dead ViewerId const + refresh stale
 coverage doc
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Follow-up cleanup to the two-client PvP conformance drive. The class-level
ViewerId const is no longer referenced (both remaining `ViewerId:` sites are
the MsgEnvelope named ctor arg, passing `vid`/literal 1), and the Coverage
doc-comment still described "a single Scripted session" — refresh it to the
two-client PvP reality. No behavior change; tests 2/2 green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---
 .../BattleNode/Integration/CaptureConformanceTests.cs | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/SVSim.UnitTests/BattleNode/Integration/CaptureConformanceTests.cs b/SVSim.UnitTests/BattleNode/Integration/CaptureConformanceTests.cs
index fc780b3..35234ec 100644
--- a/SVSim.UnitTests/BattleNode/Integration/CaptureConformanceTests.cs
+++ b/SVSim.UnitTests/BattleNode/Integration/CaptureConformanceTests.cs
@@ -31,19 +31,18 @@ namespace SVSim.UnitTests.BattleNode.Integration;
 /// <c>BattleFinish</c> frame is played immediately whether or not it carries a <c>playSeq</c>).
 /// The check is on *body shape*.</para>
 ///
-/// <para><b>Coverage:</b> a single Scripted session emits all ten server-authored URIs
+/// <para><b>Coverage:</b> a two-client PvP session emits all ten server-authored URIs
 /// (<c>InitNetwork, Matched, BattleStart, Deal, Swap, Ready, TurnStart, TurnEnd, Judge,
-/// BattleFinish</c>). PvP uses the same <see cref="SVSim.BattleNode.Lifecycle.ScriptedLifecycle"/>
-/// builders for the handshake/mulligan frames, so this transitively covers the PvP handshake shape
-/// too. Forwarded frames (<c>PlayActions / TurnEndActions / ChatStamp / TurnEndFinal</c>) relay the
+/// BattleFinish</c>). PvP authors the handshake/mulligan frames through the same shared
+/// <see cref="SVSim.BattleNode.Lifecycle.ScriptedLifecycle"/> builders, and the turn cycle
+/// (<c>TurnStart/TurnEnd/Judge</c>) falls out of the real two-client handover. Forwarded frames
+/// (<c>PlayActions / TurnEndActions / ChatStamp / TurnEndFinal</c>) relay the
 /// client's own bytes verbatim, so their shape is the client's contract, not ours — out of scope
 /// here.</para>
 /// </summary>
 [TestFixture]
 public class CaptureConformanceTests
 {
-    private const long ViewerId = 906243102L;
-
     // Top-level keys that are envelope/transport, not body shape. Excluded from the comparison
     // at the root level only (nested objects never contain these).
     private static readonly HashSet<string> IgnoredEnvelopeKeys = new()