SVSim/SVSimServer
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix(deck-builder): wire key is cardID/phantomCardID, not snake_case

Browse Source 
Client's LitJson serializer emits the C# property name verbatim — the
SetParameter param classes in Wizard/GenerateDeckCodeTask.cs use cardID /
phantomCardID, and the matching Parse() reads jsonData["cardID"]. Snake-case
keys bound to empty in msgpack deserialize, the controller saw 0 cards, and
returned INVALID_DECK — surfaced as a blank deck code in the in-game UI.

Repro lived in data_dumps/traffic.ndjson #19-20. Existing tests pass through
the same JsonPropertyName on both serialize and deserialize, so they happily
round-tripped any consistent key — adding a wire-shape regression test that
posts the literal client JSON would be the right way to catch this class of
bug in the future (out of scope here).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
gamer147
2026-05-28 09:25:17 -04:00
parent 5aac24d2b9
commit 36dd25826b
2 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
SVSim.EmulatedEntrypoint/Models/Dtos/Requests/DeckBuilder/GenerateDeckCodeRequest.cs
View File

@@ -28,12 +28,17 @@ public class GenerateDeckCodeRequest
[Key("deck_format")]
public int DeckFormat { get; set; }
[JsonPropertyName("card_id")]
[Key("card_id")]
// Wire key is camelCase mid-word capital — verified in data_dumps/traffic.ndjson live
// capture (`"cardID":[...]`). The client's LitJson serializer emits the C# property name
// verbatim, and the param classes in Wizard/GenerateDeckCodeTask.cs use `cardID` /
// `phantomCardID`. Snake-case would silently bind to empty and the controller would emit
// INVALID_DECK; that was the 2026-05-28 "blank code in the deck builder UI" symptom.
[JsonPropertyName("cardID")]
[Key("cardID")]
public List<long> CardID { get; set; } = new();
[JsonPropertyName("phantom_card_id")]
[Key("phantom_card_id")]
[JsonPropertyName("phantomCardID")]
[Key("phantomCardID")]
public List<long>? PhantomCardID { get; set; }
[JsonPropertyName("rotation_id")]

6
SVSim.EmulatedEntrypoint/Models/Dtos/Responses/DeckBuilder/GetDeckFromCodeResponse.cs
View File

@@ -46,7 +46,9 @@ public class DeckPayload
[Key("rotation_id")]
public object RotationId { get; set; } = 0;
[JsonPropertyName("card_id")]
[Key("card_id")]
// Wire key is camelCase mid-word capital to mirror the client's `cardID` parser
// (Wizard/GetDeckDataFromCodeTask.cs:44 reads `jsonData["cardID"]`).
[JsonPropertyName("cardID")]
[Key("cardID")]
public List<long> CardID { get; set; } = new();
}