feat(matching): move BotRoster from hardcoded fixture to DB-backed seed
Phase 3 shipped the AI rank battle bot pool as a hardcoded 8-entry list inlined in SVSim.EmulatedEntrypoint/Matching/BotRoster.cs — editing meant recompiling. Per PLAN.md 2026-06-02 item (d), move it to a Bootstrap importer so the roster lives in seeds/bot-roster.json and the DB. Shape mirrors PracticeOpponent end-to-end: - BotRosterEntry (SVSim.Database/Models) — PK = AiId via the Id passthrough pattern. DbSet<BotRosterEntry> BotRoster on SVSimDbContext. - AddBotRoster migration (DDL only, per migrations-are-DDL-only rule). - seeds/bot-roster.json — 8 rows preserving the current prod-verified cosmetic ids (sleeve 704141010 / emblem 400001100 / degree 120027 / field 5) and series-1 ai_ids from rm_ai_setting.csv (1111..1181). - BotRosterSeed POCO + BotRosterImporter (idempotent upsert keyed by AiId, leaves seed-missing rows intact). Wired into SVSim.Bootstrap/Program.cs next to PracticeOpponentImporter. - IGlobalsRepository.GetBotRoster() + impl. IBotRoster.Pick → PickAsync because BotRoster now depends on the transient IGlobalsRepository. RankBattleController awaits the new signature. The deterministic hash-on-ctx invariant (same ctx → same bot, so /ai_<fmt>/start retries pick the same opponent) is preserved. DI: AddSingleton<IBotRoster> → AddTransient (matches IGlobalsRepository's lifetime). Test fixture's SeedGlobalsAsync also runs the importer so RankBattleControllerTests + the rewritten BotRosterTests both see seeded rows. Tests: 931 → 936 passing. Existing 3 BotRosterTests reshaped for the DB backing + 1 new "throws on empty roster" guard; 4 new BotRosterImporterTests mirror PracticeOpponentImporterTests (round-trip / idempotent / seed-missing-row-intact / ai_id=0 skip). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
@@ -1,6 +1,9 @@
|
||||
using Microsoft.Extensions.DependencyInjection;
|
||||
using NUnit.Framework;
|
||||
using SVSim.BattleNode.Bridge;
|
||||
using SVSim.Database.Repositories.Globals;
|
||||
using SVSim.EmulatedEntrypoint.Matching;
|
||||
using SVSim.UnitTests.Infrastructure;
|
||||
|
||||
namespace SVSim.UnitTests.Matching;
|
||||
|
||||
@@ -13,11 +16,21 @@ public class BotRosterTests
|
||||
CountryCode: "JP", UserName: userName, SleeveId: "0",
|
||||
EmblemId: "0", DegreeId: "0", FieldId: 0, IsOfficial: 0, BattleType: 11);
|
||||
|
||||
[Test]
|
||||
public void Pick_returns_a_bot_with_valid_ai_id_from_rm_ai_setting()
|
||||
private static async Task<BotRoster> NewRosterAsync(SVSimTestFactory factory)
|
||||
{
|
||||
var roster = new BotRoster();
|
||||
var bot = roster.Pick(Ctx("PlayerA", "1"));
|
||||
await factory.SeedGlobalsAsync();
|
||||
var scope = factory.Services.CreateScope();
|
||||
var globals = scope.ServiceProvider.GetRequiredService<IGlobalsRepository>();
|
||||
return new BotRoster(globals);
|
||||
}
|
||||
|
||||
[Test]
|
||||
public async Task PickAsync_returns_a_bot_with_valid_ai_id_from_rm_ai_setting()
|
||||
{
|
||||
using var factory = new SVSimTestFactory();
|
||||
var roster = await NewRosterAsync(factory);
|
||||
|
||||
var bot = await roster.PickAsync(Ctx("PlayerA", "1"));
|
||||
|
||||
// Series-1 enemy_ai_id values from data_dumps/client-assets/rm_ai_setting.csv —
|
||||
// one per class (1=Forest, 2=Sword, 3=Rune, 4=Dragon, 5=Shadow, 6=Blood, 7=Haven, 8=Portal).
|
||||
@@ -26,10 +39,12 @@ public class BotRosterTests
|
||||
}
|
||||
|
||||
[Test]
|
||||
public void Pick_returns_bot_with_class_metadata_set()
|
||||
public async Task PickAsync_returns_bot_with_class_metadata_set()
|
||||
{
|
||||
var roster = new BotRoster();
|
||||
var bot = roster.Pick(Ctx("PlayerA", "1"));
|
||||
using var factory = new SVSimTestFactory();
|
||||
var roster = await NewRosterAsync(factory);
|
||||
|
||||
var bot = await roster.PickAsync(Ctx("PlayerA", "1"));
|
||||
|
||||
Assert.That(bot.ClassId, Is.InRange(1, 8));
|
||||
Assert.That(bot.CharaId, Is.InRange(1, 8));
|
||||
@@ -38,14 +53,28 @@ public class BotRosterTests
|
||||
}
|
||||
|
||||
[Test]
|
||||
public void Pick_is_deterministic_per_match_context()
|
||||
public async Task PickAsync_is_deterministic_per_match_context()
|
||||
{
|
||||
var roster = new BotRoster();
|
||||
using var factory = new SVSimTestFactory();
|
||||
var roster = await NewRosterAsync(factory);
|
||||
var ctx = Ctx("PlayerA", "3");
|
||||
|
||||
var a = roster.Pick(ctx);
|
||||
var b = roster.Pick(ctx);
|
||||
var a = await roster.PickAsync(ctx);
|
||||
var b = await roster.PickAsync(ctx);
|
||||
|
||||
Assert.That(a, Is.EqualTo(b), "Same ctx → same bot, so mid-flight retries get the same opponent.");
|
||||
}
|
||||
|
||||
[Test]
|
||||
public async Task PickAsync_throws_when_roster_empty()
|
||||
{
|
||||
// Empty DB (no SeedGlobalsAsync call) → no rows → invariant violated.
|
||||
using var factory = new SVSimTestFactory();
|
||||
var scope = factory.Services.CreateScope();
|
||||
var globals = scope.ServiceProvider.GetRequiredService<IGlobalsRepository>();
|
||||
var roster = new BotRoster(globals);
|
||||
|
||||
Assert.That(async () => await roster.PickAsync(Ctx("PlayerA", "1")),
|
||||
Throws.InvalidOperationException);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user