refactor: type reward_type columns as UserGoodsType enum

Replace bare `int RewardType` on 12 catalog/reward entities and GrantedReward
with the existing UserGoodsType enum. Verified against the decompiled client:
every wire reward_type decodes through the single Wizard.UserGoods.Type enum, so
one enum is correct across all endpoint families (item_type is a separate
Item.Type axis, left untouched). EF stores the enum as the same int column, so
there is no migration.

- Importers cast seed int -> UserGoodsType at the ingest boundary.
- New GrantedReward.ToRewardList() extension replaces 8 copy-pasted
  GrantedReward -> RewardListEntry projections.
- Fix 3 .ToString() sites that would otherwise emit enum names ("Crystal")
  instead of the int wire value ("2").
- Wire DTOs keep int; the enum is widened to int at the wire boundary only.

Build green; 962/962 tests pass.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
gamer147
2026-06-03 07:50:49 -04:00
parent fb1e91cdf1
commit 05d8169012
60 changed files with 179 additions and 154 deletions

View File

@@ -65,7 +65,7 @@ public class BattlePassRewardImporterTests
db.BattlePassRewards.Add(new SVSim.Database.Models.BattlePassRewardEntry
{
Id = 230_099, // MakeId(23, Normal=0, 99) == 23*10_000 + 0*1_000 + 99
SeasonId = 23, Track = BattlePassTrack.Normal, Level = 99, RewardType = 9,
SeasonId = 23, Track = BattlePassTrack.Normal, Level = 99, RewardType = (UserGoodsType)9,
RewardDetailId = 0, RewardNumber = 9999, IsAppealExclusion = false,
});
await db.SaveChangesAsync();
@@ -93,7 +93,7 @@ public class BattlePassRewardImporterTests
});
db.BattlePassRewards.Add(new SVSim.Database.Models.BattlePassRewardEntry
{
SeasonId = 22, Track = BattlePassTrack.Normal, Level = 1, RewardType = 9,
SeasonId = 22, Track = BattlePassTrack.Normal, Level = 1, RewardType = (UserGoodsType)9,
RewardDetailId = 0, RewardNumber = 100, IsAppealExclusion = false,
});
await db.SaveChangesAsync();