conco/FictionArchive
1
0
Fork 0
Code Issues 16 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

Add Image Support #5

New Issue
Closed
opened 2025-11-14 20:31:50 +00:00 by conco · 1 comment
conco commented 2025-11-14 20:31:50 +00:00
Owner
Copy Link

Add support for handling, downloading and serving images where they would be expected.

Add support for handling, downloading and serving images where they would be expected.
conco added the enhancement label 2025-11-14 20:31:50 +00:00
conco commented 2025-11-20 18:35:35 +00:00
Author
Owner
Copy Link

Thinking we do this with Garage (S3 implementation)
SourceAdapter downloads novel/chapter, picks out images, those go into respective metadata result
NovelService raises a request to have them uplaoded and saves the request
new ImageService
Processes requests, go into s3, produce public link, raise statusupdate
NovelService matches to saved request, replaces image URL with public link as needed

Private, timed links would probably require frontend stitching of requests (novelservice for novel/chapter, then imageservice to get links, update respective areas).

Maybe extrapolate out image replacement to a sourceadapter responsibility?

Thinking we do this with Garage (S3 implementation) SourceAdapter downloads novel/chapter, picks out images, those go into respective metadata result NovelService raises a request to have them uplaoded and saves the request new ImageService Processes requests, go into s3, produce public link, raise statusupdate NovelService matches to saved request, replaces image URL with public link as needed Private, timed links would probably require frontend stitching of requests (novelservice for novel/chapter, then imageservice to get links, update respective areas). Maybe extrapolate out image replacement to a sourceadapter responsibility?
conco added this to the Phase 2 project 2025-11-22 06:17:07 +00:00
conco moved this to To Do in Phase 2 on 2025-11-22 06:53:54 +00:00
conco moved this to In Progress in Phase 2 on 2025-11-22 13:10:22 +00:00
conco closed this issue 2025-11-24 02:17:10 +00:00
conco moved this to Done in Phase 2 on 2025-11-24 02:17:18 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 source
New novel source
 wontfix
This won't be fixed
No Label enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project Phase 2
Assignees
Clear assignees
conco
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: conco/FictionArchive#5
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?