addeb021d2
Six distinct fixes accumulated over live-test iterations against four bids (654473755566, 806245601092, 283192092460, 131549100204, 799755786270) — together they take the shadow engine from "throws on the first non-mulligan play" to "survives a full PvP battle, only weird-edge-case Unity touches still left to whack". 1. Engine StableRandom seed aligned with clients' Matched.seed (BattleSession.EnsureEngineSetup, NodeNativeBattleHarness.Create). Clients seed _stableRandom with BattleSeeds.Stable(masterSeed) (the value the node ships in Matched.seed); we were passing the RAW masterSeed to engine.Setup, so every StableRandom call diverged from call #1 onward — every turn-1+ draw picked a different deck position than the clients. Verified Stable(1184631275)=1543475792 matches the wire on bid 654473755566. 2. SeedDeck advances cardTotalNum to deck.Count+1 + pins BattleStartDeckCardList. Mirrors SBattleLoad.InitPlayer's tail (SBattleLoad.cs:1292). Without it, skill-generated tokens auto-assigned Index 0,1,... and COLLIDED with deck-loaded indices 1..40 — silent until something addressed the deck card with the colliding Index (Hoverboarder at deck idx 1 + a token at engine Index 1 made GetBattleCardIdx's SingleOrDefault throw on bid 806245601092). 3. BattleCardView.GameObject lazily non-null in the shim (ViewUiTouchStubs.cs). The IsRecovery card-create delegate (NetworkBattleManagerBase.cs:379) passes null cardGameObject; Skill_metamorphose.cs:147 in the in-play branch then NRE'd on `metamorphosedCard.BattleCardView.GameObject.transform.rotation = identity`, a purely cosmetic touch with no game-state implication. Bid 283192092460: Petrification on a board follower. 4. TranslateChoiceKeyAction unwraps wrapped selectCard on shadow ingest (SessionBattleEngine.cs, sibling to TranslateTargetOwners). Live sender-send wires Choice plays as selectCard:{cardId:[...], open:0}; engine's ConvertToListInt does `value as List<object>` — a Dict casts to null and foreach NREs. The receiver's swallow-all catch (NetworkBattleReceiver.cs:1255) logs to Debug.LogError + LocalLog — both shimmed/no-op'd headlessly — and returns false, but Receive calls ReceivedMessage with checkBreakData:false so the false isn't propagated. The play continues with choiceIdList=[], the chosen branch never resolves, the played card stays in hand; a later targeted play (A's bounce on B's "board" idx 20) then can't find the target → NRE on null in ActionProcessor.PlayCard:407. Bid 131549100204: B's Resonance + A's bounce. Opponent-relay path is unaffected — node strips selectCard from broadcasts. 5. HeadlessHandViewStub overrides HandUnfocus/HandFocus/FocusRearrangeHandHand to return NullVfx. CreateHandControl returns null in headless; the base methods unconditionally deref `_handControl.SetHandState(...)`. A follower with a when_spell_play Heal trigger fired on its leader for amount 0 — even a 0-heal drives ApplyHealing → CreatePullHandInVfx → HandUnfocus → NRE. Bid 799755786270: two consecutive spell plays both crashed this stack. Added InternalsVisibleTo("SVSim.BattleEngine.Tests") so the shim-level regression tests can pin the no-op contracts directly. Plus the previous-session fixes carried in this same uncommitted state (see docs/superpowers/plans/2026-06-07-shadow-engine-desync-handoff.md): - doesPlayerGoFirst:true + mgr.IsFirst:true (turn-1 draw count correct per seat) - RecoveryOperationCollection.PlayHandCardOperation routes all type:30 through PlaySkillSelectHandCardOperation (skips the two-phase user-select guard that aborts targeted spells in recovery) - ShadowFeed + ToRawBody: server-generated typed bodies (DealBody, etc.) converted to RawBody before engine.Receive (`env.Body as RawBody` returned null for typed bodies) - Ready idxChangeSeed seeds A's XorShift via the receiver; B's seed is injected via SeedOppoIdxChange (BattleSeeds.IdxChange + viewerId) - ReadySpin defaulted to 0 (was 243) — non-zero double-cranks the shadow which ingests BOTH sides' Ready frames on one stream Test counts: SVSim.UnitTests 1054/1054, SVSim.BattleEngine.Tests 34/34. Open: known-residual Unity touches are individual whack-a-mole now (per-card skill edge cases), not the structural divergences fixed here. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
38 lines
2.1 KiB
C#
38 lines
2.1 KiB
C#
namespace SVSim.BattleNode.Lifecycle;
|
||
|
||
/// <summary>
|
||
/// Default frame constants templated from TK2 prod captures, shared by the
|
||
/// server-authored battle-frame builders. Every value here originated in a real prod
|
||
/// frame in <c>data_dumps/captures/battle-traffic_tk2_regular.ndjson</c>; pulling them
|
||
/// out of <see cref="ServerBattleFrames"/> makes the magic numerics navigable. The shared effect
|
||
/// seed and the deck-shuffle/idxChangeSeed are now derived per-battle from a master seed (see
|
||
/// <see cref="BattleSeeds"/>) — only animation/UI constants remain here.
|
||
/// </summary>
|
||
internal static class BattleFrameDefaults
|
||
{
|
||
// From frame[5] (BattleStart). Hardcoded; see spec §Deferred plumbing — sourcing these
|
||
// from real per-viewer state needs a TK2 rank/battle-point tracker.
|
||
public const string PlayerRank = "10";
|
||
public const string PlayerBattlePoint = "6270";
|
||
|
||
// Ready-frame spin. Prod shipped 243 (obfuscation base — the spin-rng audit proved ~99% of the
|
||
// magnitude is non-gameplay). Our node is authority for BOTH clients; they each crank this on
|
||
// their own shared _stableRandom, but the shadow engine ingests BOTH sides' Ready frames on ONE
|
||
// stream — so a non-zero value double-cranks the shadow (243×2 = 486 vs each client's 243),
|
||
// desynchronizing every subsequent StableRandom draw. Zero eliminates the offset; both clients
|
||
// and the shadow all start at stream position 0.
|
||
public const int ReadySpin = 0;
|
||
|
||
/// <summary>
|
||
/// Server-pushed Judge frame spin value. Prod varies per push (55, 175, 73, ...) — it's
|
||
/// an animation seed, not a stateful value. Fixed at 100 here for test stability;
|
||
/// the client's <c>JudgeOperation</c> doesn't read it.
|
||
/// </summary>
|
||
public const int OpponentJudgeSpin = 100;
|
||
|
||
/// <summary>Spin value the PvP relay stamps on the Judge / OpponentTurnStart handover frames
|
||
/// in the deterministic-turn slice. 0 = no animation seed; per-turn spin is deferred
|
||
/// (see the real-spin design). The client self-generates its turn-open and doesn't read it.</summary>
|
||
public const int DeterministicTurnSpin = 0;
|
||
}
|