Files
SVSimServer/SVSim.UnitTests/Controllers/ArenaColosseumBattleControllerTests.cs
gamer147 cbee0f9a50 feat(arena-colosseum): playable bracket + rank-match promotion (phase 2)
Closes 4 more arena-colosseum spec shapes (6/16 → 10/16): the dual-prefix
battle URLs (colosseum_battle/* and colosseum_rank_battle/*) for both
do_matching and per-match finish, plus the bracket-end /finish + /retire
pair on /arena_colosseum.

* ColosseumProgressionService: pure-logic decisions for win-threshold
  advancement, 3008 promotion trigger, and per-round reward bundles.
  Extends ColosseumRoundsConfig with FinishRewards/RetireRewards per
  round + a top-level ChampionRewards list.
* MatchContextBuilder.BuildForColosseumAsync: lifts the registered deck
  via IDeckRepository (NOT viewer-graph) per project_ef_nav_include_pitfall.
* ArenaColosseumBattleController: dual route prefixes off one controller
  via explicit absolute [HttpPost("/...")] routes — does NOT extend
  SVSimController's [Route("[controller]")]. Same pattern as FreeBattle.
  URL-vs-IsRankMatching mismatch returns 400 with a phase-mismatch error;
  no-deck triggers the standard 3001 matchmaking-illegal state. 3008
  flips run.IsRankMatching exactly once via the progression service.
* /arena_colosseum/finish + /retire share FinishResponse (rewards +
  reward_list + colosseum_status). Champion finish appends ChampionRewards
  and surfaces colosseum_status.is_champion = true. Both delete the run
  row after granting via IInventoryTransaction.GrantAsync.
* DI: ModePolicy entries for "colosseum_battle" and "colosseum_rank_battle".
* Tests: 8 progression-service unit tests (pure logic), 5 battle-controller
  HTTP tests, 5 bracket-terminate HTTP tests, 2 full-bracket E2E walks
  (champion path + retire mid-round). Full suite: 1331/1331.
2026-06-13 12:32:56 -04:00

157 lines
6.4 KiB
C#

using System.Net;
using System.Net.Http.Json;
using System.Text.Json;
using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.DependencyInjection;
using SVSim.Database;
using SVSim.Database.Enums;
using SVSim.Database.Models;
using SVSim.UnitTests.Infrastructure;
namespace SVSim.UnitTests.Controllers;
/// <summary>
/// Per-match battle URL coverage — verifies the dual <c>colosseum_battle/*</c> +
/// <c>colosseum_rank_battle/*</c> dispatch matches <c>run.IsRankMatching</c>, that
/// <c>battle/finish</c> bumps the per-round counters, and that the 3008 promotion
/// trigger flips the run's rank flag.
/// </summary>
public class ArenaColosseumBattleControllerTests
{
private static readonly object Envelope =
new { viewer_id = "0", steam_id = 0, steam_session_ticket = "" };
private static async Task SeedRunAsync(SVSimTestFactory factory, long viewerId, bool isRankMatching = false)
{
using var scope = factory.Services.CreateScope();
var db = scope.ServiceProvider.GetRequiredService<SVSimDbContext>();
db.ViewerArenaColosseumRuns.Add(new ViewerArenaColosseumRun
{
ViewerId = viewerId,
EntryId = 1001,
SeasonId = 42,
RoundId = 1,
DeckFormat = Format.Rotation,
MaxBattleCountThisRound = 5,
BreakthroughNumberThisRound = 4,
IsRankMatching = isRankMatching,
RegisteredDeckNoListJson = "[3]",
});
await db.SaveChangesAsync();
}
[Test]
public async Task DoMatching_pre_rank_rejects_when_run_is_rank_matching()
{
using var factory = new SVSimTestFactory();
var vid = await factory.SeedViewerAsync();
await SeedRunAsync(factory, vid, isRankMatching: true);
await factory.SeedDeckAsync(vid, Format.Rotation, number: 3);
using var client = factory.CreateAuthenticatedClient(vid);
var resp = await client.PostAsync("/colosseum_battle/do_matching", JsonContent.Create(Envelope));
Assert.That(resp.StatusCode, Is.EqualTo(HttpStatusCode.BadRequest));
var body = await resp.Content.ReadAsStringAsync();
StringAssert.Contains("colosseum_url_phase_mismatch", body);
}
[Test]
public async Task DoMatching_post_rank_rejects_when_run_is_pre_rank()
{
using var factory = new SVSimTestFactory();
var vid = await factory.SeedViewerAsync();
await SeedRunAsync(factory, vid, isRankMatching: false);
await factory.SeedDeckAsync(vid, Format.Rotation, number: 3);
using var client = factory.CreateAuthenticatedClient(vid);
var resp = await client.PostAsync("/colosseum_rank_battle/do_matching", JsonContent.Create(Envelope));
Assert.That(resp.StatusCode, Is.EqualTo(HttpStatusCode.BadRequest));
var body = await resp.Content.ReadAsStringAsync();
StringAssert.Contains("colosseum_url_phase_mismatch", body);
}
[Test]
public async Task DoMatching_returns_3001_when_no_deck_registered()
{
using var factory = new SVSimTestFactory();
var vid = await factory.SeedViewerAsync();
using (var scope = factory.Services.CreateScope())
{
var db = scope.ServiceProvider.GetRequiredService<SVSimDbContext>();
db.ViewerArenaColosseumRuns.Add(new ViewerArenaColosseumRun
{
ViewerId = vid,
EntryId = 1001,
SeasonId = 42,
RoundId = 1,
DeckFormat = Format.Rotation,
RegisteredDeckNoListJson = "[]",
});
await db.SaveChangesAsync();
}
using var client = factory.CreateAuthenticatedClient(vid);
var resp = await client.PostAsync("/colosseum_battle/do_matching", JsonContent.Create(Envelope));
Assert.That(resp.StatusCode, Is.EqualTo(HttpStatusCode.OK));
var body = await resp.Content.ReadAsStringAsync();
using var doc = JsonDocument.Parse(body);
Assert.That(doc.RootElement.GetProperty("matching_state").GetInt32(), Is.EqualTo(3001));
}
[Test]
public async Task BattleFinish_win_advances_counters_and_appends_result_list()
{
using var factory = new SVSimTestFactory();
var vid = await factory.SeedViewerAsync();
await SeedRunAsync(factory, vid);
using var client = factory.CreateAuthenticatedClient(vid);
var req = new
{
battle_result = 1, is_retire = 0, class_id = 1,
total_turn = 5, evolve_count = 1, enemy_evolve_count = 0,
recovery_data = "",
viewer_id = "0", steam_id = 0, steam_session_ticket = "",
};
var resp = await client.PostAsync("/colosseum_battle/finish", JsonContent.Create(req));
Assert.That(resp.StatusCode, Is.EqualTo(HttpStatusCode.OK));
using var scope = factory.Services.CreateScope();
var db = scope.ServiceProvider.GetRequiredService<SVSimDbContext>();
var run = await db.ViewerArenaColosseumRuns.FirstAsync(r => r.ViewerId == vid);
Assert.That(run.WinCount, Is.EqualTo(1));
Assert.That(run.LossCount, Is.EqualTo(0));
Assert.That(run.BattleCountThisRound, Is.EqualTo(1));
Assert.That(run.ResultListJson, Is.EqualTo("[1]"));
}
[Test]
public async Task BattleFinish_retire_does_not_advance_counters()
{
using var factory = new SVSimTestFactory();
var vid = await factory.SeedViewerAsync();
await SeedRunAsync(factory, vid);
using var client = factory.CreateAuthenticatedClient(vid);
var req = new
{
battle_result = 2, is_retire = 1, class_id = 1,
total_turn = 3, evolve_count = 0, enemy_evolve_count = 0,
recovery_data = "",
viewer_id = "0", steam_id = 0, steam_session_ticket = "",
};
var resp = await client.PostAsync("/colosseum_battle/finish", JsonContent.Create(req));
Assert.That(resp.StatusCode, Is.EqualTo(HttpStatusCode.OK));
using var scope = factory.Services.CreateScope();
var db = scope.ServiceProvider.GetRequiredService<SVSimDbContext>();
var run = await db.ViewerArenaColosseumRuns.FirstAsync(r => r.ViewerId == vid);
Assert.That(run.WinCount, Is.EqualTo(0));
Assert.That(run.LossCount, Is.EqualTo(0));
Assert.That(run.BattleCountThisRound, Is.EqualTo(0),
"is_retire=1 must not bump the per-round battle counter");
}
}