Files
SVSimServer/SVSim.BattleEngine/Engine/Wizard/AIPolishConvertedExpression.cs
gamer147 2d9a6eea4b engine cleanup passes 4-7 + multi-instancing ambient rip
Squashes 146 commits from battle-engine-extraction. Net: 2,045 files changed,
+11,896 / -158,687 lines. Ships engine passes 4-7 (dead-code cull, view-layer
stub, receive-path shrink) plus the Phase-5 AsyncLocal ambient deletion that
turns concurrent battles into a type-system property rather than a scope
contract.

## What landed

**Passes 4-7 (chunks 1-34):** Extended the Phase-4 const-false collapse into a
cascading cull across the skill graph, view layer, and receive-path periphery.
Six mode flags (IsWatchBattle/IsReplayBattle/IsAdmin/IsAdminWatch/IsPuzzleQuest/
IsAINetwork) became `const false`, every guarded block deleted. Field*.cs
subclass ctors + BackGroundBase + ObjectChecker culled to no-ops. Mulligan
family reworked to take a mgr param through IMulliganMgr.InitMulligan.
Emotion/Recovery/Resource clusters null-stubbed. Prediction/OperationSimulator/
skill filters converted from static ambient reads to per-mgr reads via
SkillPrm.ownerCard.SelfBattlePlayer.BattleMgr / ins.BattleMgr / this.BattleMgr.

**Phase-5 ambient rip (chunks 35-47):** Deleted BattleAmbient / BattleAmbient-
Context / TestBattleScope in full. Every per-battle mutable slot now lives on
the mgr instance itself:
  mgr.InstanceIsForecast / InstanceIsRandomDraw / InstanceRecoveryInfo /
  InstanceViewerId / InstanceNetworkAgent / GameMgr
BattleManagerBase.GetIns() returns null unconditionally; the residual static
flags + 3 façades (Certification.ViewerId, Data.BattleRecoveryInfo,
ToolboxGame.RealTimeNetworkAgent) are null-tolerant defaults kept for the
handful of engine-internal readers that still reference their types. Zero
BattleAmbient references anywhere in engine + node + tests.

Added pre-seeded GameMgr ctor overload threaded through the mgr chain
(BattleManagerBase → SingleBattleMgr / NetworkBattleManagerBase → NetworkStandard-
BattleMgr → HeadlessBattleMgr / HeadlessNetworkBattleMgr). Fixtures build a
GameMgr, seed it via HeadlessEngineEnv.SeedCharaIds/SeedNetUser, and pass it
to the mgr's ctor — no ambient reach.

Node side (SVSim.BattleNode/SessionBattleEngine): _ctx replaced with a plain
GameMgr field; 34 `using var _ambient = BattleAmbient.Enter(_ctx)` scope wraps
ripped from every accessor and mutator; EngineGlobalInit.WirePerSessionGameMgr
takes GameMgr as a param and runs from SessionBattleEngine.SetupInternal
BEFORE mgr construction.

Test side: TestBattleScope deleted; 18 fixture [SetUp]s migrated to
`HeadlessEngineEnv.EnsureProcessGlobals()`; MultiInstanceEngineTests rewritten
around per-mgr construction (GetIns() → null is the pinned invariant).

## Regression fixes

- **chunk-48** (MulliganCtrl): chunk-35's `= null` stubs on card lookups broke
  the live receive-driven Deal path (BattlePlayerBase.DrawCard NRE'd downstream
  of NetworkPlayerMulliganCtrl.StartMulliganVfx). Restored the three lookups
  via `_battlePlayer.BattleMgr.GetBattleCardIdx`. Engine tests were satisfied
  by the WireMulliganPhase seam; unit tests exposed the live-path gap.

## Ship state

- SVSim.BattleEngine.Tests: 56/56 pass, 2 skip
- SVSim.UnitTests: 1554/1554 pass (was 1523/31-fail before chunk 48)
- Solution build: 0 source warnings (40 pre-existing NU1902 MessagePack CVEs
  in SVSim.EmulatedEntrypoint, unrelated)
- Sequential PVP smoke: verified live (two back-to-back battles, no regression
  on cleanup/spinup)
- Concurrent PVP smoke: verified live

Adds tools/engine-port/ClosureAnalyzer/ — the Roslyn transitive-type-closure
analyzer needed to make future cascade cleanup safe (per feedback memory
"Engine cleanup needs closure tool" from the 2026-06-28 pass-3 failure).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-07-03 19:18:54 -04:00

320 lines
8.7 KiB
C#

using System.Collections.Generic;
using System.Linq;
namespace Wizard;
public class AIPolishConvertedExpression
{
private readonly AIScriptTokenFuncType[] EvalFuncList = new AIScriptTokenFuncType[22]
{
AIScriptTokenFuncType.EVAL_ALL_DAMAGE,
AIScriptTokenFuncType.EVAL_TARGETING_DAMAGE,
AIScriptTokenFuncType.EVAL_TARGETING_AND_RANDOM_MULTI_DAMAGE,
AIScriptTokenFuncType.EVAL_ALL_DESTROY,
AIScriptTokenFuncType.EVAL_ALL_BOUNCE,
AIScriptTokenFuncType.EVAL_TARGETING_BOUNCE,
AIScriptTokenFuncType.EVAL_TARGETING_BANISH,
AIScriptTokenFuncType.EVAL_RANDOM_BANISH,
AIScriptTokenFuncType.EVAL_ALL_BANISH,
AIScriptTokenFuncType.EVAL_ALL_METAMORPHOSE,
AIScriptTokenFuncType.EVAL_TARGETING_METAMORPHOSE,
AIScriptTokenFuncType.EVAL_ALL_BUFF,
AIScriptTokenFuncType.EVAL_RANDOM_BUFF,
AIScriptTokenFuncType.EVAL_TARGETING_DESTROY,
AIScriptTokenFuncType.EVAL_TARGETING_HEAL,
AIScriptTokenFuncType.EVAL_ALL_HEAL,
AIScriptTokenFuncType.EVAL_RANDOM_BOUNCE,
AIScriptTokenFuncType.EVAL_RANDOM_DESTROY,
AIScriptTokenFuncType.EVAL_RANDOM_METAMORPHOSE,
AIScriptTokenFuncType.EVAL_RANDOM_MULTI_DAMAGE,
AIScriptTokenFuncType.EVAL_RANDOM_MULTI_SELECT_DAMAGE,
AIScriptTokenFuncType.EVAL_DIVIDED_DAMAGE
};
public List<AIScriptTokenBase> TokenList { get; private set; }
public int Hash { get; private set; }
public bool IsMultiplyMarked { get; private set; }
public AIPolishConvertedExpression(string text, bool isMultiplyMarked = false)
{
IsMultiplyMarked = isMultiplyMarked;
TokenList = CreateExpression(text);
Hash = text.GetHashCode();
}
public int EvalID()
{
if (TokenList == null || TokenList.Count != 1)
{
return 0;
}
if (!(TokenList[0] is AIScriptIDToken))
{
return 0;
}
return (TokenList[0] as AIScriptIDToken).ID;
}
public List<int> GetReferringIDLists()
{
List<int> list = null;
for (int i = 0; i < TokenList.Count; i++)
{
AIScriptTokenBase aIScriptTokenBase = TokenList[i];
if (aIScriptTokenBase is AIScriptIDToken)
{
if (list == null)
{
list = new List<int>();
}
list.Add(((AIScriptIDToken)aIScriptTokenBase).ID);
}
}
return list;
}
public string EvalText()
{
if (TokenList == null || TokenList.Count != 1)
{
return "";
}
if (TokenList[0] is AIScriptTextToken aIScriptTextToken)
{
return aIScriptTextToken.Text;
}
return "";
}
public float EvalArg(AIVirtualCard tagOwner, List<int> playPtn, AIVirtualField field, AISituationInfo situation = null)
{
if (TokenList == null || TokenList.Count <= 0)
{
return 0f;
}
return GetFloatValue(tagOwner, situation, playPtn, field);
}
public bool CheckCondition(AIVirtualCard tagOwner, List<int> playPtn, AIVirtualField field, AISituationInfo situation)
{
if (TokenList == null || TokenList.Count <= 0)
{
return true;
}
return GetFloatValue(tagOwner, situation, playPtn, field) > 0f;
}
public bool IsZeroOrNone()
{
if (TokenList == null || TokenList.Count <= 0)
{
return true;
}
if (TokenList.Count > 1)
{
return false;
}
AIScriptTokenBase aIScriptTokenBase = TokenList[0];
if (aIScriptTokenBase is AIScriptArgumentToken { ArgumentType: AIScriptTokenArgType.NONE } || aIScriptTokenBase is AIScriptNumericToken { Value: 0f })
{
return true;
}
return false;
}
public bool IsMathematicExpress()
{
if (TokenList == null || TokenList.Count <= 0)
{
return false;
}
if (TokenList.Count > 1)
{
return true;
}
AIScriptTokenBase aIScriptTokenBase = TokenList[0];
if (!(aIScriptTokenBase is AIScriptNumericToken))
{
return aIScriptTokenBase is AIScriptVariableToken;
}
return true;
}
public bool IsCertainArgumentTypeExpress(AIScriptTokenArgType argType)
{
if (TokenList == null || TokenList.Count <= 0 || TokenList.Count > 1)
{
return false;
}
if (TokenList[0] is AIScriptArgumentToken aIScriptArgumentToken && aIScriptArgumentToken.ArgumentType == argType)
{
return true;
}
return false;
}
private float GetFloatValue(AIVirtualCard tagOwner, AISituationInfo situation, List<int> playPtn, AIVirtualField field)
{
if (TokenList == null || TokenList.Count <= 0)
{
return 0f;
}
return AIScriptExpressionCalculator.CalculateExpression(TokenList, playPtn, field, tagOwner, situation);
}
private List<AIScriptTokenBase> CreateExpression(string expression)
{
if (expression == "")
{
return null;
}
List<AIScriptTokenBase> list = CreateScriptTokenList(expression);
if (list == null || list.Count <= 0)
{
return null;
}
if (list.Count == 1 && list[0] is AIScriptNumericToken)
{
return list;
}
return _ConvertExprToIPolish(list);
}
private List<AIScriptTokenBase> CreateScriptTokenList(string text)
{
List<AIScriptTokenBase> list = new List<AIScriptTokenBase>();
string[] array = text.Split(' ');
bool flag = false;
string[] array2 = array;
foreach (string text2 in array2)
{
if (!(text2 == ""))
{
AIScriptTokenBase aIScriptTokenBase = AIScriptParser.ConvertWordToToken(text2);
if (aIScriptTokenBase != null)
{
list.Add(aIScriptTokenBase);
}
else
{
flag = true;
}
}
}
return list;
}
private List<AIScriptTokenBase> _ConvertExprToIPolish(List<AIScriptTokenBase> expression)
{
List<AIScriptTokenBase> list = new List<AIScriptTokenBase>();
Stack<AIScriptTokenBase> stack = new Stack<AIScriptTokenBase>();
AIScriptFunctionToken aIScriptFunctionToken = null;
for (int i = 0; i < expression.Count; i++)
{
AIScriptTokenBase aIScriptTokenBase = expression[i];
if (aIScriptTokenBase is AIScriptNumericToken || aIScriptTokenBase is AIScriptArgumentToken || aIScriptTokenBase is AIScriptVariableToken || aIScriptTokenBase is AIScriptIDToken)
{
list.Add(aIScriptTokenBase);
continue;
}
if (aIScriptTokenBase is AIScriptOperatorSymbolToken)
{
if (aIScriptTokenBase.Type == AIScriptTokenType.COMMA)
{
while (stack.Count > 0)
{
AIScriptTokenBase aIScriptTokenBase2 = stack.Pop();
if (aIScriptTokenBase2 is AIScriptOperatorSymbolToken && aIScriptTokenBase2.Type == AIScriptTokenType.LEFT_BLACKET)
{
break;
}
if (aIScriptTokenBase2 == aIScriptFunctionToken)
{
aIScriptFunctionToken = stack.LastOrDefault((AIScriptTokenBase t) => t is AIScriptFunctionToken) as AIScriptFunctionToken;
}
list.Add(aIScriptTokenBase2);
}
aIScriptFunctionToken.ArgCount++;
stack.Push(new AIScriptOperatorSymbolToken(AIScriptTokenType.LEFT_BLACKET));
continue;
}
if (aIScriptTokenBase.Type == AIScriptTokenType.LEFT_BLACKET)
{
stack.Push(aIScriptTokenBase);
continue;
}
if (aIScriptTokenBase.Type == AIScriptTokenType.RIGHT_BLACKET)
{
while (stack.Count > 0)
{
AIScriptTokenBase aIScriptTokenBase3 = stack.Pop();
if (aIScriptTokenBase3 is AIScriptOperatorSymbolToken && aIScriptTokenBase3.Type == AIScriptTokenType.LEFT_BLACKET)
{
break;
}
if (aIScriptTokenBase3 == aIScriptFunctionToken)
{
aIScriptFunctionToken = stack.LastOrDefault((AIScriptTokenBase t) => t is AIScriptFunctionToken) as AIScriptFunctionToken;
}
list.Add(aIScriptTokenBase3);
}
continue;
}
}
if (aIScriptTokenBase is AIScriptFunctionToken)
{
aIScriptFunctionToken = aIScriptTokenBase as AIScriptFunctionToken;
aIScriptFunctionToken.ArgCount = 1;
}
if (stack.Count <= 0)
{
stack.Push(aIScriptTokenBase);
continue;
}
while (stack.Count > 0)
{
AIScriptTokenBase aIScriptTokenBase4 = stack.Peek();
if (aIScriptTokenBase4.Type == AIScriptTokenType.LEFT_BLACKET || aIScriptTokenBase4.Priority < aIScriptTokenBase.Priority)
{
break;
}
if (aIScriptTokenBase4 == aIScriptFunctionToken)
{
aIScriptFunctionToken = stack.LastOrDefault((AIScriptTokenBase t) => t is AIScriptFunctionToken) as AIScriptFunctionToken;
}
list.Add(stack.Pop());
}
stack.Push(aIScriptTokenBase);
}
while (stack.Count > 0)
{
list.Add(stack.Pop());
}
return list;
}
public AIScriptCalculationToken CreateCalculationToken()
{
return new AIScriptCalculationToken(TokenList);
}
public bool IsHoldingEVAL()
{
if (TokenList == null)
{
return false;
}
for (int i = 0; i < TokenList.Count; i++)
{
AIScriptTokenBase aIScriptTokenBase = TokenList[i];
if (aIScriptTokenBase is AIScriptFunctionToken && EvalFuncList.Contains(((AIScriptFunctionToken)aIScriptTokenBase).FuncType))
{
return true;
}
}
return false;
}
}