Files
SVSimServer/SVSim.BattleEngine/Engine/ClassSkinPlate.cs
gamer147 2d9a6eea4b engine cleanup passes 4-7 + multi-instancing ambient rip
Squashes 146 commits from battle-engine-extraction. Net: 2,045 files changed,
+11,896 / -158,687 lines. Ships engine passes 4-7 (dead-code cull, view-layer
stub, receive-path shrink) plus the Phase-5 AsyncLocal ambient deletion that
turns concurrent battles into a type-system property rather than a scope
contract.

## What landed

**Passes 4-7 (chunks 1-34):** Extended the Phase-4 const-false collapse into a
cascading cull across the skill graph, view layer, and receive-path periphery.
Six mode flags (IsWatchBattle/IsReplayBattle/IsAdmin/IsAdminWatch/IsPuzzleQuest/
IsAINetwork) became `const false`, every guarded block deleted. Field*.cs
subclass ctors + BackGroundBase + ObjectChecker culled to no-ops. Mulligan
family reworked to take a mgr param through IMulliganMgr.InitMulligan.
Emotion/Recovery/Resource clusters null-stubbed. Prediction/OperationSimulator/
skill filters converted from static ambient reads to per-mgr reads via
SkillPrm.ownerCard.SelfBattlePlayer.BattleMgr / ins.BattleMgr / this.BattleMgr.

**Phase-5 ambient rip (chunks 35-47):** Deleted BattleAmbient / BattleAmbient-
Context / TestBattleScope in full. Every per-battle mutable slot now lives on
the mgr instance itself:
  mgr.InstanceIsForecast / InstanceIsRandomDraw / InstanceRecoveryInfo /
  InstanceViewerId / InstanceNetworkAgent / GameMgr
BattleManagerBase.GetIns() returns null unconditionally; the residual static
flags + 3 façades (Certification.ViewerId, Data.BattleRecoveryInfo,
ToolboxGame.RealTimeNetworkAgent) are null-tolerant defaults kept for the
handful of engine-internal readers that still reference their types. Zero
BattleAmbient references anywhere in engine + node + tests.

Added pre-seeded GameMgr ctor overload threaded through the mgr chain
(BattleManagerBase → SingleBattleMgr / NetworkBattleManagerBase → NetworkStandard-
BattleMgr → HeadlessBattleMgr / HeadlessNetworkBattleMgr). Fixtures build a
GameMgr, seed it via HeadlessEngineEnv.SeedCharaIds/SeedNetUser, and pass it
to the mgr's ctor — no ambient reach.

Node side (SVSim.BattleNode/SessionBattleEngine): _ctx replaced with a plain
GameMgr field; 34 `using var _ambient = BattleAmbient.Enter(_ctx)` scope wraps
ripped from every accessor and mutator; EngineGlobalInit.WirePerSessionGameMgr
takes GameMgr as a param and runs from SessionBattleEngine.SetupInternal
BEFORE mgr construction.

Test side: TestBattleScope deleted; 18 fixture [SetUp]s migrated to
`HeadlessEngineEnv.EnsureProcessGlobals()`; MultiInstanceEngineTests rewritten
around per-mgr construction (GetIns() → null is the pinned invariant).

## Regression fixes

- **chunk-48** (MulliganCtrl): chunk-35's `= null` stubs on card lookups broke
  the live receive-driven Deal path (BattlePlayerBase.DrawCard NRE'd downstream
  of NetworkPlayerMulliganCtrl.StartMulliganVfx). Restored the three lookups
  via `_battlePlayer.BattleMgr.GetBattleCardIdx`. Engine tests were satisfied
  by the WireMulliganPhase seam; unit tests exposed the live-path gap.

## Ship state

- SVSim.BattleEngine.Tests: 56/56 pass, 2 skip
- SVSim.UnitTests: 1554/1554 pass (was 1523/31-fail before chunk 48)
- Solution build: 0 source warnings (40 pre-existing NU1902 MessagePack CVEs
  in SVSim.EmulatedEntrypoint, unrelated)
- Sequential PVP smoke: verified live (two back-to-back battles, no regression
  on cleanup/spinup)
- Concurrent PVP smoke: verified live

Adds tools/engine-port/ClosureAnalyzer/ — the Roslyn transitive-type-closure
analyzer needed to make future cascade cleanup safe (per feedback memory
"Engine cleanup needs closure tool" from the 2026-06-28 pass-3 failure).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-07-03 19:18:54 -04:00

191 lines
6.6 KiB
C#

using System;
using Cute;
using UnityEngine;
using Wizard;
using Wizard.Scripts.Network.Data.TaskData.SkinPurchase;
public class ClassSkinPlate : MonoBehaviour
{
private readonly Vector3 POS_VIEW_SINGLE_PRODUCT_NAME = new Vector3(13f, -52f, 0f);
private readonly Vector3 POS_VIEW_MULTI_PRODUCT_NAME = new Vector3(0f, -52f, 0f);
[SerializeField]
private UIEventListener _eventListenerSkinImage;
[SerializeField]
private UISprite _spritePlateBG;
[SerializeField]
private UILabel _labelFree;
[SerializeField]
private UILabel _labelCostCrystal;
[SerializeField]
private UILabel _labelCostRupy;
[SerializeField]
private UILabel _labelCostTicket;
[SerializeField]
private UIButton m_BtnBuy;
[SerializeField]
private UILabel m_LabelBuy;
[SerializeField]
private UILabel m_LabelPurchased;
[SerializeField]
private UILabel _LabelProductName;
[SerializeField]
private UITexture _uiClassSkinTexture;
[SerializeField]
private UITexture _uiClassSkinTextureLarge;
[SerializeField]
private UISprite _spriteClassColorIcon;
[SerializeField]
private UITexture _leaderSkinTicketIcon;
public SkinProductInfo ProductInfo { get; private set; }
public SkinSeriesPurchaseInfo SeriesInfo { get; private set; }
public void SetMultiData(SkinSeriesPurchaseInfo seriesInfo, EventDelegate onPushBuyBtnCallback = null, Action onTapSkinImage = null)
{
SetBuyButtonToGrey(isGrey: false);
bool isLargeImage = Data.Master.LeaderSkinSeriesIdDic[seriesInfo.series_id].IsLargeImage;
ProductInfo = null;
SeriesInfo = seriesInfo;
Texture mainTexture = Toolbox.ResourcesManager.LoadObject<Texture>(Toolbox.ResourcesManager.GetAssetTypePath(seriesInfo.saleInfo.path, ResourcesManager.AssetLoadPathType.ShopClassSkin, isfetch: true));
if (isLargeImage)
{
_uiClassSkinTexture.gameObject.SetActive(value: false);
_uiClassSkinTextureLarge.gameObject.SetActive(value: true);
_uiClassSkinTextureLarge.mainTexture = mainTexture;
_spritePlateBG.width = 411;
int maxLength = (Global.IsAlphabetLanguage() ? 39 : 20);
_LabelProductName.text = ShopCommonUtility.TrimProductName(seriesInfo.saleInfo.name, maxLength);
}
else
{
_uiClassSkinTexture.gameObject.SetActive(value: true);
_uiClassSkinTextureLarge.gameObject.SetActive(value: false);
_uiClassSkinTexture.mainTexture = mainTexture;
_spritePlateBG.width = 357;
_LabelProductName.text = ShopCommonUtility.TrimProductName(seriesInfo.saleInfo.name);
}
_LabelProductName.transform.localPosition = POS_VIEW_MULTI_PRODUCT_NAME;
_LabelProductName.effectStyle = UILabel.Effect.None;
_spriteClassColorIcon.gameObject.SetActive(value: false);
m_BtnBuy.onClick.Clear();
m_BtnBuy.onClick.Add(onPushBuyBtnCallback);
_eventListenerSkinImage.onClick = null;
_eventListenerSkinImage.onClick = delegate
{
onTapSkinImage.Call();
};
if (seriesInfo.saleInfo.costTicketItemId.HasValue)
{
_leaderSkinTicketIcon.mainTexture = Toolbox.ResourcesManager.LoadObject<Texture>(ShopCommonUtility.GetTicketIconPath(seriesInfo.saleInfo.costTicketItemId.Value.ToString(), isFetch: true));
}
if (seriesInfo.is_completed && seriesInfo._rewardStatus != SkinSeriesPurchaseInfo.RewardStatus.not_got)
{
_labelCostCrystal.gameObject.SetActive(value: false);
_labelCostRupy.gameObject.SetActive(value: false);
_labelFree.gameObject.SetActive(value: false);
_labelCostTicket.gameObject.SetActive(value: false);
}
else
{
ShopCommonUtility.SetCostInfo(seriesInfo.saleInfo, _labelCostCrystal, _labelCostRupy, _labelFree, _labelCostTicket);
}
_SetMultiBuyButton(seriesInfo);
}
public void SetBuyButtonToGrey(bool isGrey)
{
UIManager.SetObjectToGrey(m_BtnBuy.gameObject, isGrey);
}
public void SetData(SkinProductInfo productInfo, EventDelegate onPushBuyBtnCallback = null, Action onTapSkinImage = null)
{
SeriesInfo = null;
ProductInfo = productInfo;
ClassCharacterMasterData charaPrmBySkinId = null; // Pre-Phase-5b: no chara master headless
_LabelProductName.transform.localPosition = POS_VIEW_SINGLE_PRODUCT_NAME;
int maxLength = (Global.IsAlphabetLanguage() ? 35 : 15);
_LabelProductName.text = ShopCommonUtility.TrimProductName(productInfo.saleInfo.name, maxLength);
ClassCharaPrm.SetClassLabelSetting(_LabelProductName, charaPrmBySkinId.ClassColorId);
_uiClassSkinTextureLarge.gameObject.SetActive(value: false);
_uiClassSkinTexture.gameObject.SetActive(value: true);
_uiClassSkinTexture.mainTexture = Toolbox.ResourcesManager.LoadObject<Texture>(Toolbox.ResourcesManager.GetAssetTypePath(productInfo.saleInfo.path, ResourcesManager.AssetLoadPathType.ClassCharaSkinThumbnail, isfetch: true));
_spritePlateBG.width = 357;
_spriteClassColorIcon.gameObject.SetActive(value: true);
_spriteClassColorIcon.spriteName = ClassCharaPrm.GetIconSpriteName(charaPrmBySkinId.clan);
m_BtnBuy.onClick.Clear();
m_BtnBuy.onClick.Add(onPushBuyBtnCallback);
_eventListenerSkinImage.onClick = null;
_eventListenerSkinImage.onClick = delegate
{
onTapSkinImage.Call();
};
if (productInfo.IsEnableBuyTicket)
{
_leaderSkinTicketIcon.mainTexture = Toolbox.ResourcesManager.LoadObject<Texture>(ShopCommonUtility.GetTicketIconPath(productInfo.saleInfo.costTicketItemId.Value.ToString(), isFetch: true));
}
ShopCommonUtility.SetCostInfo(productInfo.saleInfo, _labelCostCrystal, _labelCostRupy, _labelFree, _labelCostTicket);
_SetBuyButton(productInfo);
}
private void _SetBuyButton(SkinProductInfo productInfo)
{
if (!productInfo.is_purchased)
{
m_BtnBuy.gameObject.SetActive(value: true);
m_BtnBuy.isEnabled = true;
m_LabelPurchased.gameObject.SetActive(value: false);
if (productInfo.saleInfo.isFree)
{
m_LabelBuy.text = Data.SystemText.Get("Shop_0099");
}
else
{
m_LabelBuy.text = Data.SystemText.Get("Shop_0095");
}
}
else
{
m_BtnBuy.gameObject.SetActive(value: false);
m_LabelPurchased.gameObject.SetActive(value: true);
}
}
private void _SetMultiBuyButton(SkinSeriesPurchaseInfo seriesInfo)
{
if (seriesInfo.is_completed && seriesInfo._rewardStatus != SkinSeriesPurchaseInfo.RewardStatus.not_got)
{
m_BtnBuy.gameObject.SetActive(value: false);
m_LabelPurchased.gameObject.SetActive(value: true);
return;
}
m_BtnBuy.gameObject.SetActive(value: true);
m_BtnBuy.isEnabled = true;
m_LabelPurchased.gameObject.SetActive(value: false);
if (seriesInfo.saleInfo.isFree)
{
m_LabelBuy.text = Data.SystemText.Get("Shop_0099");
}
else
{
m_LabelBuy.text = Data.SystemText.Get("Shop_0095");
}
}
}