Squashes 146 commits from battle-engine-extraction. Net: 2,045 files changed, +11,896 / -158,687 lines. Ships engine passes 4-7 (dead-code cull, view-layer stub, receive-path shrink) plus the Phase-5 AsyncLocal ambient deletion that turns concurrent battles into a type-system property rather than a scope contract. ## What landed **Passes 4-7 (chunks 1-34):** Extended the Phase-4 const-false collapse into a cascading cull across the skill graph, view layer, and receive-path periphery. Six mode flags (IsWatchBattle/IsReplayBattle/IsAdmin/IsAdminWatch/IsPuzzleQuest/ IsAINetwork) became `const false`, every guarded block deleted. Field*.cs subclass ctors + BackGroundBase + ObjectChecker culled to no-ops. Mulligan family reworked to take a mgr param through IMulliganMgr.InitMulligan. Emotion/Recovery/Resource clusters null-stubbed. Prediction/OperationSimulator/ skill filters converted from static ambient reads to per-mgr reads via SkillPrm.ownerCard.SelfBattlePlayer.BattleMgr / ins.BattleMgr / this.BattleMgr. **Phase-5 ambient rip (chunks 35-47):** Deleted BattleAmbient / BattleAmbient- Context / TestBattleScope in full. Every per-battle mutable slot now lives on the mgr instance itself: mgr.InstanceIsForecast / InstanceIsRandomDraw / InstanceRecoveryInfo / InstanceViewerId / InstanceNetworkAgent / GameMgr BattleManagerBase.GetIns() returns null unconditionally; the residual static flags + 3 façades (Certification.ViewerId, Data.BattleRecoveryInfo, ToolboxGame.RealTimeNetworkAgent) are null-tolerant defaults kept for the handful of engine-internal readers that still reference their types. Zero BattleAmbient references anywhere in engine + node + tests. Added pre-seeded GameMgr ctor overload threaded through the mgr chain (BattleManagerBase → SingleBattleMgr / NetworkBattleManagerBase → NetworkStandard- BattleMgr → HeadlessBattleMgr / HeadlessNetworkBattleMgr). Fixtures build a GameMgr, seed it via HeadlessEngineEnv.SeedCharaIds/SeedNetUser, and pass it to the mgr's ctor — no ambient reach. Node side (SVSim.BattleNode/SessionBattleEngine): _ctx replaced with a plain GameMgr field; 34 `using var _ambient = BattleAmbient.Enter(_ctx)` scope wraps ripped from every accessor and mutator; EngineGlobalInit.WirePerSessionGameMgr takes GameMgr as a param and runs from SessionBattleEngine.SetupInternal BEFORE mgr construction. Test side: TestBattleScope deleted; 18 fixture [SetUp]s migrated to `HeadlessEngineEnv.EnsureProcessGlobals()`; MultiInstanceEngineTests rewritten around per-mgr construction (GetIns() → null is the pinned invariant). ## Regression fixes - **chunk-48** (MulliganCtrl): chunk-35's `= null` stubs on card lookups broke the live receive-driven Deal path (BattlePlayerBase.DrawCard NRE'd downstream of NetworkPlayerMulliganCtrl.StartMulliganVfx). Restored the three lookups via `_battlePlayer.BattleMgr.GetBattleCardIdx`. Engine tests were satisfied by the WireMulliganPhase seam; unit tests exposed the live-path gap. ## Ship state - SVSim.BattleEngine.Tests: 56/56 pass, 2 skip - SVSim.UnitTests: 1554/1554 pass (was 1523/31-fail before chunk 48) - Solution build: 0 source warnings (40 pre-existing NU1902 MessagePack CVEs in SVSim.EmulatedEntrypoint, unrelated) - Sequential PVP smoke: verified live (two back-to-back battles, no regression on cleanup/spinup) - Concurrent PVP smoke: verified live Adds tools/engine-port/ClosureAnalyzer/ — the Roslyn transitive-type-closure analyzer needed to make future cascade cleanup safe (per feedback memory "Engine cleanup needs closure tool" from the 2026-06-28 pass-3 failure). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
109 lines
3.7 KiB
C#
109 lines
3.7 KiB
C#
namespace Wizard;
|
|
|
|
public class DeckConventionUpdateTask : BaseTask
|
|
{
|
|
public class DeckConventionUpdateTaskParam : BaseParam
|
|
{
|
|
public string tournament_id;
|
|
|
|
public int deck_no;
|
|
|
|
public int class_id;
|
|
|
|
public int leader_skin_id;
|
|
|
|
public bool is_random_leader_skin;
|
|
|
|
public int[] leader_skin_id_list;
|
|
|
|
public long sleeve_id;
|
|
|
|
public string deck_name;
|
|
|
|
public int is_delete;
|
|
|
|
public string rotation_id;
|
|
|
|
public int[] card_id_array;
|
|
}
|
|
|
|
public class DeckConventionUpdateTaskParamWithSubClass : BaseParam
|
|
{
|
|
public string tournament_id;
|
|
|
|
public int deck_no;
|
|
|
|
public int class_id;
|
|
|
|
public int sub_class_id;
|
|
|
|
public int leader_skin_id;
|
|
|
|
public bool is_random_leader_skin;
|
|
|
|
public int[] leader_skin_id_list;
|
|
|
|
public long sleeve_id;
|
|
|
|
public string deck_name;
|
|
|
|
public int is_delete;
|
|
|
|
public int[] card_id_array;
|
|
}
|
|
|
|
private ConventionDeckList _deckList;
|
|
|
|
public DeckConventionUpdateTask()
|
|
{
|
|
base.type = ApiType.Type.DeckUpdateConvention;
|
|
}
|
|
|
|
public void SetParameter(int deck_no, int class_id, int leader_skin_id, bool isRandomLeaderSkin, int[] leaderSkinIdList, long sleeve_id, string deck_name, bool is_delete, int[] card_id_array, string rotationId, ConventionDeckList deckList)
|
|
{
|
|
_deckList = deckList;
|
|
DeckConventionUpdateTaskParam deckConventionUpdateTaskParam = new DeckConventionUpdateTaskParam();
|
|
deckConventionUpdateTaskParam.tournament_id = _deckList.Conventioninfo.Id;
|
|
deckConventionUpdateTaskParam.deck_no = deck_no;
|
|
deckConventionUpdateTaskParam.class_id = class_id;
|
|
deckConventionUpdateTaskParam.leader_skin_id = leader_skin_id;
|
|
deckConventionUpdateTaskParam.is_random_leader_skin = isRandomLeaderSkin;
|
|
deckConventionUpdateTaskParam.leader_skin_id_list = leaderSkinIdList;
|
|
deckConventionUpdateTaskParam.sleeve_id = sleeve_id;
|
|
deckConventionUpdateTaskParam.deck_name = deck_name;
|
|
deckConventionUpdateTaskParam.is_delete = (is_delete ? 1 : 0);
|
|
deckConventionUpdateTaskParam.card_id_array = card_id_array;
|
|
deckConventionUpdateTaskParam.rotation_id = (string.IsNullOrEmpty(rotationId) ? string.Empty : rotationId);
|
|
base.Params = deckConventionUpdateTaskParam;
|
|
}
|
|
|
|
public void SetParameterWithSubClass(int deck_no, int class_id, int subClassId, int leader_skin_id, bool isRandomLeaderSkin, int[] leaderSkinIdList, long sleeve_id, string deck_name, bool is_delete, int[] card_id_array, ConventionDeckList deckList)
|
|
{
|
|
_deckList = deckList;
|
|
DeckConventionUpdateTaskParamWithSubClass deckConventionUpdateTaskParamWithSubClass = new DeckConventionUpdateTaskParamWithSubClass();
|
|
deckConventionUpdateTaskParamWithSubClass.tournament_id = _deckList.Conventioninfo.Id;
|
|
deckConventionUpdateTaskParamWithSubClass.deck_no = deck_no;
|
|
deckConventionUpdateTaskParamWithSubClass.class_id = class_id;
|
|
deckConventionUpdateTaskParamWithSubClass.sub_class_id = subClassId;
|
|
deckConventionUpdateTaskParamWithSubClass.leader_skin_id = leader_skin_id;
|
|
deckConventionUpdateTaskParamWithSubClass.is_random_leader_skin = isRandomLeaderSkin;
|
|
deckConventionUpdateTaskParamWithSubClass.leader_skin_id_list = leaderSkinIdList;
|
|
deckConventionUpdateTaskParamWithSubClass.sleeve_id = sleeve_id;
|
|
deckConventionUpdateTaskParamWithSubClass.deck_name = deck_name;
|
|
deckConventionUpdateTaskParamWithSubClass.is_delete = (is_delete ? 1 : 0);
|
|
deckConventionUpdateTaskParamWithSubClass.card_id_array = card_id_array;
|
|
base.Params = deckConventionUpdateTaskParamWithSubClass;
|
|
}
|
|
|
|
protected override int Parse()
|
|
{
|
|
int num = base.Parse();
|
|
if (num != 1)
|
|
{
|
|
return num;
|
|
}
|
|
_deckList.ParseDeckListJson(base.ResponseData["data"]["user_deck_list"]);
|
|
return num;
|
|
}
|
|
}
|