Files
SVSimServer/SVSim.UnitTests/Services/ArenaTwoPickServiceEntryTests.cs
gamer147 6381e4da51 fix(tk2): match original SV (5-battle cap, no loss limit)
User clarified: the 0..7 win reward tiers came from Shadowverse Worlds
Beyond (sequel), not the original game we're emulating. Original SV's
Take Two caps at 5 total battles played and has no loss limit (verified
on prod: queueing continues with 2+ losses).

- arena-two-pick-rewards.json: drop 6w + 7w tiers (12 rows remain).
- ArenaTwoPickConfig: remove MaxLosses property.
- ArenaTwoPickService: termination is now battlesPlayed >= maxBattles
  (5 from MAX(reward.WinCount)). RecordBattleResult no longer flips
  IsSelectCompleted on the 2nd loss.
- ResolveMaxBattleCountAsync empty-catalog default 7 → 5.
- Tests updated for the new counts (16 → 12 rows, max 7 → 5).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-31 12:47:43 -04:00

200 lines
8.6 KiB
C#

using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.DependencyInjection;
using SVSim.Bootstrap.Importers;
using SVSim.Database;
using SVSim.Database.Enums;
using SVSim.Database.Models;
using SVSim.Database.Repositories.Globals;
using SVSim.Database.Repositories.Viewer;
using SVSim.Database.Services;
using SVSim.EmulatedEntrypoint.Services;
using SVSim.UnitTests.Infrastructure;
namespace SVSim.UnitTests.Services;
public class ArenaTwoPickServiceEntryTests
{
private const long TicketItemId = 1;
/// <summary>Minimal stub — EntryAsync never calls pool methods.</summary>
private sealed class NullCardPoolService : IArenaTwoPickCardPoolService
{
public List<CandidatePair> GeneratePickSetsForTurn(int classId, int turn, long startingPairId, IRandom rng)
=> throw new NotSupportedException("pool not used in EntryAsync");
}
/// <summary>Minimal fake that exposes only <see cref="IsFreeplay"/>.</summary>
private sealed class FakeEntitlements : IViewerEntitlements
{
public bool IsFreeplay { get; init; }
public long EffectiveBalance(SVSim.Database.Models.Viewer viewer, SpendCurrency currency) => 0;
public bool OwnsCard(SVSim.Database.Models.Viewer viewer, long cardId) => IsFreeplay;
public bool OwnsCosmetic(SVSim.Database.Models.Viewer viewer, CosmeticType type, int id) => IsFreeplay;
public Task<IReadOnlyList<OwnedCardEntry>> EffectiveOwnedCardsAsync(SVSim.Database.Models.Viewer viewer, CancellationToken ct = default)
=> Task.FromResult<IReadOnlyList<OwnedCardEntry>>(new List<OwnedCardEntry>());
public Task<EffectiveCosmetics> EffectiveCosmeticsAsync(SVSim.Database.Models.Viewer viewer, CancellationToken ct = default)
=> throw new NotSupportedException();
}
private static async Task<(SVSimDbContext db, IArenaTwoPickService svc, long viewerId)> SetupAsync(
int ticketCount, bool freeplay = false, ulong crystals = 0, ulong rupees = 0)
{
var factory = new SVSimTestFactory();
var scope = factory.Services.CreateScope();
var db = scope.ServiceProvider.GetRequiredService<SVSimDbContext>();
await db.Database.EnsureCreatedAsync();
var ticketItem = new ItemEntry { Id = (int)TicketItemId, Name = "TK2 Ticket" };
db.Items.Add(ticketItem);
var viewer = new SVSim.Database.Models.Viewer
{
Id = 99, DisplayName = "X",
Currency = new ViewerCurrency { Crystals = crystals, Rupees = rupees },
};
viewer.Items.Add(new OwnedItemEntry { Item = ticketItem, Count = ticketCount });
db.Viewers.Add(viewer);
await db.SaveChangesAsync();
var grants = scope.ServiceProvider.GetRequiredService<RewardGrantService>();
var config = scope.ServiceProvider.GetRequiredService<IGameConfigService>();
// Seed reward catalog so GetMaxWinCountAsync returns 7.
await new ArenaTwoPickRewardImporter()
.ImportAsync(db, Path.Combine(AppContext.BaseDirectory, "Data", "seeds"));
var svc = new ArenaTwoPickService(
new ArenaTwoPickRunRepository(db),
new ArenaTwoPickRewardRepository(db),
new NullCardPoolService(),
config,
scope.ServiceProvider.GetRequiredService<IViewerRepository>(),
grants,
new FakeEntitlements { IsFreeplay = freeplay },
new SystemRandom(seed: 1234),
db,
scope.ServiceProvider.GetRequiredService<ICurrencySpendService>());
return (db, svc, viewer.Id);
}
[Test]
public async Task EntryAsync_with_ticket_debits_one_and_creates_run_in_class_select_state()
{
var (db, svc, viewerId) = await SetupAsync(ticketCount: 5);
await using var _ = db;
var dto = await svc.EntryAsync(viewerId, consumeItemType: 3);
Assert.That(dto.EntryInfo.Id, Is.GreaterThan(0));
Assert.That(dto.EntryInfo.MaxBattleCount, Is.EqualTo(5));
Assert.That(dto.CandidateClassIds.Count, Is.EqualTo(3));
Assert.That(dto.RewardList.Count, Is.EqualTo(1));
Assert.That(dto.RewardList[0].RewardType, Is.EqualTo(4));
Assert.That(dto.RewardList[0].RewardId, Is.EqualTo(TicketItemId));
Assert.That(dto.RewardList[0].RewardNum, Is.EqualTo(4), "post-state ticket count");
var run = await db.ViewerArenaTwoPickRuns.FirstAsync(r => r.ViewerId == viewerId);
Assert.That(run.ClassId, Is.EqualTo(0));
Assert.That(run.MaxBattleCount, Is.EqualTo(5));
// Re-read viewer to verify ticket was debited.
var updated = await db.Viewers.Include(v => v.Items).ThenInclude(i => i.Item).FirstAsync(v => v.Id == viewerId);
var item = updated.Items.First(i => i.Item.Id == (int)TicketItemId);
Assert.That(item.Count, Is.EqualTo(4));
}
[Test]
public async Task EntryAsync_without_ticket_throws_insufficient_ticket()
{
var (db, svc, viewerId) = await SetupAsync(ticketCount: 0);
await using var _ = db;
var ex = Assert.ThrowsAsync<ArenaTwoPickException>(() => svc.EntryAsync(viewerId, 3));
Assert.That(ex!.ErrorCode, Is.EqualTo("insufficient_ticket"));
Assert.That(await db.ViewerArenaTwoPickRuns.AnyAsync(), Is.False);
}
[Test]
public async Task EntryAsync_in_freeplay_skips_debit_and_emits_unchanged_count()
{
var (db, svc, viewerId) = await SetupAsync(ticketCount: 0, freeplay: true);
await using var _ = db;
var dto = await svc.EntryAsync(viewerId, 3);
Assert.That(dto.RewardList[0].RewardNum, Is.EqualTo(0), "unchanged in freeplay");
var run = await db.ViewerArenaTwoPickRuns.FirstAsync();
Assert.That(run, Is.Not.Null);
}
[Test]
public async Task EntryAsync_while_run_active_throws_already_in_progress()
{
var (db, svc, viewerId) = await SetupAsync(ticketCount: 5);
await using var _ = db;
await svc.EntryAsync(viewerId, 3);
var ex = Assert.ThrowsAsync<ArenaTwoPickException>(() => svc.EntryAsync(viewerId, 3));
Assert.That(ex!.ErrorCode, Is.EqualTo("arena_two_pick_already_in_progress"));
}
[Test]
public async Task EntryAsync_with_crystals_debits_150_and_emits_reward_list_with_post_state_crystal_balance()
{
var (db, svc, viewerId) = await SetupAsync(ticketCount: 0, crystals: 500);
await using var _ = db;
var dto = await svc.EntryAsync(viewerId, consumeItemType: 1);
Assert.That(dto.RewardList.Count, Is.EqualTo(1));
Assert.That(dto.RewardList[0].RewardType, Is.EqualTo((int)SVSim.Database.Enums.UserGoodsType.Crystal));
Assert.That(dto.RewardList[0].RewardId, Is.EqualTo(0));
Assert.That(dto.RewardList[0].RewardNum, Is.EqualTo(350), "post-state = 500 - 150");
var updated = await db.Viewers.Include(v => v.Currency).FirstAsync(v => v.Id == viewerId);
Assert.That((long)updated.Currency!.Crystals, Is.EqualTo(350));
}
[Test]
public async Task EntryAsync_with_rupies_debits_150_and_emits_reward_list_with_post_state_rupy_balance()
{
var (db, svc, viewerId) = await SetupAsync(ticketCount: 0, rupees: 500);
await using var _ = db;
var dto = await svc.EntryAsync(viewerId, consumeItemType: 4);
Assert.That(dto.RewardList.Count, Is.EqualTo(1));
Assert.That(dto.RewardList[0].RewardType, Is.EqualTo((int)SVSim.Database.Enums.UserGoodsType.Rupy));
Assert.That(dto.RewardList[0].RewardId, Is.EqualTo(0));
Assert.That(dto.RewardList[0].RewardNum, Is.EqualTo(350), "post-state = 500 - 150");
var updated = await db.Viewers.Include(v => v.Currency).FirstAsync(v => v.Id == viewerId);
Assert.That((long)updated.Currency!.Rupees, Is.EqualTo(350));
}
[Test]
public async Task EntryAsync_free_entry_emits_empty_reward_list_and_creates_run()
{
var (db, svc, viewerId) = await SetupAsync(ticketCount: 0);
await using var _ = db;
var dto = await svc.EntryAsync(viewerId, consumeItemType: 5);
Assert.That(dto.RewardList, Is.Empty, "free entry emits no fee entry");
var run = await db.ViewerArenaTwoPickRuns.FirstAsync(r => r.ViewerId == viewerId);
Assert.That(run, Is.Not.Null);
}
[Test]
public async Task EntryAsync_with_invalid_consume_item_type_throws()
{
var (db, svc, viewerId) = await SetupAsync(ticketCount: 5);
await using var _ = db;
var ex = Assert.ThrowsAsync<ArenaTwoPickException>(() => svc.EntryAsync(viewerId, consumeItemType: 99));
Assert.That(ex!.ErrorCode, Is.EqualTo("invalid_consume_item_type"));
Assert.That(await db.ViewerArenaTwoPickRuns.AnyAsync(), Is.False);
}
}