24f9b2240e
Phase 3 shipped the AI rank battle bot pool as a hardcoded 8-entry list inlined in SVSim.EmulatedEntrypoint/Matching/BotRoster.cs — editing meant recompiling. Per PLAN.md 2026-06-02 item (d), move it to a Bootstrap importer so the roster lives in seeds/bot-roster.json and the DB. Shape mirrors PracticeOpponent end-to-end: - BotRosterEntry (SVSim.Database/Models) — PK = AiId via the Id passthrough pattern. DbSet<BotRosterEntry> BotRoster on SVSimDbContext. - AddBotRoster migration (DDL only, per migrations-are-DDL-only rule). - seeds/bot-roster.json — 8 rows preserving the current prod-verified cosmetic ids (sleeve 704141010 / emblem 400001100 / degree 120027 / field 5) and series-1 ai_ids from rm_ai_setting.csv (1111..1181). - BotRosterSeed POCO + BotRosterImporter (idempotent upsert keyed by AiId, leaves seed-missing rows intact). Wired into SVSim.Bootstrap/Program.cs next to PracticeOpponentImporter. - IGlobalsRepository.GetBotRoster() + impl. IBotRoster.Pick → PickAsync because BotRoster now depends on the transient IGlobalsRepository. RankBattleController awaits the new signature. The deterministic hash-on-ctx invariant (same ctx → same bot, so /ai_<fmt>/start retries pick the same opponent) is preserved. DI: AddSingleton<IBotRoster> → AddTransient (matches IGlobalsRepository's lifetime). Test fixture's SeedGlobalsAsync also runs the importer so RankBattleControllerTests + the rewritten BotRosterTests both see seeded rows. Tests: 931 → 936 passing. Existing 3 BotRosterTests reshaped for the DB backing + 1 new "throws on empty roster" guard; 4 new BotRosterImporterTests mirror PracticeOpponentImporterTests (round-trip / idempotent / seed-missing-row-intact / ai_id=0 skip). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
40 lines
1.5 KiB
C#
40 lines
1.5 KiB
C#
using SVSim.Database.Common;
|
|
|
|
namespace SVSim.Database.Models;
|
|
|
|
/// <summary>
|
|
/// One row per AI bot opponent the rank-battle AI-fallback path can pick. Populated
|
|
/// from seeds/bot-roster.json by SVSim.Bootstrap.BotRosterImporter.
|
|
///
|
|
/// The Id (= AiId) MUST match a row in the client's baked-in master CSV
|
|
/// <c>data_dumps/client-assets/rm_ai_setting.csv</c>; if it doesn't, the client's
|
|
/// <c>RankMatchAISettingList.GetSettingData(aiId)</c> throws
|
|
/// <c>InvalidOperationException</c> at battle-start.
|
|
///
|
|
/// Cosmetic ids (sleeve / emblem / degree / field) MUST resolve in
|
|
/// <c>SBattleLoad.LoadOpponentAssets</c>; placeholder 1s left the client hanging on
|
|
/// "Waiting for opponent". Prod-verified values come from the Scripted bot fixture.
|
|
/// </summary>
|
|
public class BotRosterEntry : BaseEntity<int>
|
|
{
|
|
/// <summary>Client AI catalog id (rm_ai_setting.csv enemy_ai_id). Also the PK.</summary>
|
|
public int AiId { get => Id; set => Id = value; }
|
|
|
|
public string CountryCode { get; set; } = string.Empty;
|
|
public string UserName { get; set; } = string.Empty;
|
|
|
|
public int SleeveId { get; set; }
|
|
public int EmblemId { get; set; }
|
|
public int DegreeId { get; set; }
|
|
public int FieldId { get; set; }
|
|
public int IsOfficial { get; set; }
|
|
|
|
public int ClassId { get; set; }
|
|
public int CharaId { get; set; }
|
|
|
|
public int Rank { get; set; }
|
|
public int BattlePoint { get; set; }
|
|
public int IsMasterRank { get; set; }
|
|
public int MasterPoint { get; set; }
|
|
}
|