c8e4bda6af
Anonymous /admin/import_viewer was safe locally but exposed viewer-import surface whenever the server was reachable off-box. Gate it on a shared secret carried in X-Admin-Secret, sourced from Admin:ImportSecret in appsettings (override via ADMIN__IMPORTSECRET env var). Fails closed: an unconfigured deployment 401s every request (with a logged warning) instead of leaving the endpoint open. Implementation is a plain IAuthorizationFilter attribute (RequireAdminSecret) that runs before model binding — short-circuits the ImportViewerRequest deserialize on unauthorized calls. Compare uses CryptographicOperations.FixedTimeEquals to avoid timing signal. A companion Swagger IOperationFilter registers an ApiKey security definition and attaches the requirement ONLY to actions carrying the attribute, so the Swagger UI shows an Authorize dialog for admin endpoints without decorating ordinary game routes with a padlock. Tests: existing 27 AdminController tests routed through a new SVSimTestFactory.CreateAdminClient() helper that bakes the header from appsettings.Testing.json; added two negative-path tests (missing_secret_header, wrong_secret) — 29/29 passing. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
18 lines
672 B
C#
18 lines
672 B
C#
namespace SVSim.EmulatedEntrypoint.Configuration;
|
|
|
|
/// <summary>
|
|
/// Config for the /admin/* util endpoints. Bound from the "Admin" section of appsettings.
|
|
/// </summary>
|
|
public class AdminOptions
|
|
{
|
|
public const string SectionName = "Admin";
|
|
|
|
/// <summary>
|
|
/// Shared secret required in the <c>X-Admin-Secret</c> header on protected admin endpoints
|
|
/// (see <see cref="Infrastructure.RequireAdminSecretAttribute"/>). Empty / whitespace means
|
|
/// the endpoint is disabled — the filter fails closed so an unconfigured deployment never
|
|
/// exposes the admin surface.
|
|
/// </summary>
|
|
public string ImportSecret { get; set; } = string.Empty;
|
|
}
|