Files
SVSimServer/SVSim.BattleEngine/Engine/Cute/CustomPreference.cs
gamer147 2d9a6eea4b engine cleanup passes 4-7 + multi-instancing ambient rip
Squashes 146 commits from battle-engine-extraction. Net: 2,045 files changed,
+11,896 / -158,687 lines. Ships engine passes 4-7 (dead-code cull, view-layer
stub, receive-path shrink) plus the Phase-5 AsyncLocal ambient deletion that
turns concurrent battles into a type-system property rather than a scope
contract.

## What landed

**Passes 4-7 (chunks 1-34):** Extended the Phase-4 const-false collapse into a
cascading cull across the skill graph, view layer, and receive-path periphery.
Six mode flags (IsWatchBattle/IsReplayBattle/IsAdmin/IsAdminWatch/IsPuzzleQuest/
IsAINetwork) became `const false`, every guarded block deleted. Field*.cs
subclass ctors + BackGroundBase + ObjectChecker culled to no-ops. Mulligan
family reworked to take a mgr param through IMulliganMgr.InitMulligan.
Emotion/Recovery/Resource clusters null-stubbed. Prediction/OperationSimulator/
skill filters converted from static ambient reads to per-mgr reads via
SkillPrm.ownerCard.SelfBattlePlayer.BattleMgr / ins.BattleMgr / this.BattleMgr.

**Phase-5 ambient rip (chunks 35-47):** Deleted BattleAmbient / BattleAmbient-
Context / TestBattleScope in full. Every per-battle mutable slot now lives on
the mgr instance itself:
  mgr.InstanceIsForecast / InstanceIsRandomDraw / InstanceRecoveryInfo /
  InstanceViewerId / InstanceNetworkAgent / GameMgr
BattleManagerBase.GetIns() returns null unconditionally; the residual static
flags + 3 façades (Certification.ViewerId, Data.BattleRecoveryInfo,
ToolboxGame.RealTimeNetworkAgent) are null-tolerant defaults kept for the
handful of engine-internal readers that still reference their types. Zero
BattleAmbient references anywhere in engine + node + tests.

Added pre-seeded GameMgr ctor overload threaded through the mgr chain
(BattleManagerBase → SingleBattleMgr / NetworkBattleManagerBase → NetworkStandard-
BattleMgr → HeadlessBattleMgr / HeadlessNetworkBattleMgr). Fixtures build a
GameMgr, seed it via HeadlessEngineEnv.SeedCharaIds/SeedNetUser, and pass it
to the mgr's ctor — no ambient reach.

Node side (SVSim.BattleNode/SessionBattleEngine): _ctx replaced with a plain
GameMgr field; 34 `using var _ambient = BattleAmbient.Enter(_ctx)` scope wraps
ripped from every accessor and mutator; EngineGlobalInit.WirePerSessionGameMgr
takes GameMgr as a param and runs from SessionBattleEngine.SetupInternal
BEFORE mgr construction.

Test side: TestBattleScope deleted; 18 fixture [SetUp]s migrated to
`HeadlessEngineEnv.EnsureProcessGlobals()`; MultiInstanceEngineTests rewritten
around per-mgr construction (GetIns() → null is the pinned invariant).

## Regression fixes

- **chunk-48** (MulliganCtrl): chunk-35's `= null` stubs on card lookups broke
  the live receive-driven Deal path (BattlePlayerBase.DrawCard NRE'd downstream
  of NetworkPlayerMulliganCtrl.StartMulliganVfx). Restored the three lookups
  via `_battlePlayer.BattleMgr.GetBattleCardIdx`. Engine tests were satisfied
  by the WireMulliganPhase seam; unit tests exposed the live-path gap.

## Ship state

- SVSim.BattleEngine.Tests: 56/56 pass, 2 skip
- SVSim.UnitTests: 1554/1554 pass (was 1523/31-fail before chunk 48)
- Solution build: 0 source warnings (40 pre-existing NU1902 MessagePack CVEs
  in SVSim.EmulatedEntrypoint, unrelated)
- Sequential PVP smoke: verified live (two back-to-back battles, no regression
  on cleanup/spinup)
- Concurrent PVP smoke: verified live

Adds tools/engine-port/ClosureAnalyzer/ — the Roslyn transitive-type-closure
analyzer needed to make future cascade cleanup safe (per feedback memory
"Engine cleanup needs closure tool" from the 2026-06-28 pass-3 failure).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-07-03 19:18:54 -04:00

165 lines
3.4 KiB
C#

using Wizard;
// TODO(engine-cleanup-pass2): 37 of 39 methods unrun in baseline
// Type: Cute.CustomPreference
// See data_dumps/reports/engine-cleanup/live-methods.baseline.txt
namespace Cute;
public class CustomPreference
{
public enum eSchemeType
{
Http,
Https,
File,
Node,
StreamingAssets
}
public enum PlatformType
{
NONE }
public enum SmallResourceStatus
{
}
private static string nodeServerScheme = "ws://";
private static string directoryRoot = "dl/";
private static string _applicationServerUrl = "";
private static string _resourceServerUrl = "";
private static string _deckBuilderServerUrl = "";
public static string _localePref = "Eng";
private static string _languagePref = "Eng";
private static string _languageSoundPref = "Eng";
private static string _assetbundleurl = "";
private static string _manifestsuburl = "";
private static string _soundurl = "";
private static string _movieurl = "";
private static string _manifestUrl = "";
private static eSchemeType _schemeType = eSchemeType.Http;
private static eSchemeType _schemeCDNType = eSchemeType.Http;
private static bool _isLocalAssetBundles = false;
public static bool IsNormalResource => !IsSmallResource;
public static bool IsSmallResource => PlayerPrefsCache.Instance.GetValue(PlayerPrefsWrapper.SMALL_RESOURCE_STATUS) == 2;
public static string GetApplicationServerURL()
{
return GetScheme() + _applicationServerUrl;
}
public static string GetResourceServerURL()
{
return GetCDNScheme() + _resourceServerUrl;
}
public static string GetDeckBuilderServerURL()
{
return GetScheme() + _deckBuilderServerUrl;
}
public static int GetPlatform()
{
return 4;
}
public static string GetAssetBundleURL()
{
return _assetbundleurl;
}
public static string GetManifestURL()
{
return _manifestUrl;
}
public static string GetSubManifestURL()
{
if (_isLocalAssetBundles)
{
_manifestsuburl = GetResourceServerURL() + Utility.GetRuntimePlatform() + "/";
}
else
{
_manifestsuburl = GetResourceServerURL() + directoryRoot + "Manifest/" + GetVersionFolderName() + GetSoundMovieLanguageFolderName() + Utility.GetRuntimePlatform() + "/";
}
return _manifestsuburl;
}
public static string GetSoundResourceURL()
{
return _soundurl;
}
public static string GetMoiveResourceURL()
{
return _movieurl;
}
public static string GetScheme()
{
return _schemeType switch
{
eSchemeType.Http => "http://",
eSchemeType.Https => "https://",
eSchemeType.File => "file:///",
eSchemeType.Node => nodeServerScheme,
eSchemeType.StreamingAssets => "file:///",
_ => "http://",
};
}
public static string GetCDNScheme()
{
return _schemeCDNType switch
{
eSchemeType.Http => "http://",
eSchemeType.Https => "https://",
_ => "http://",
};
}
public static string GetVersionFolderName()
{
return Toolbox.SavedataManager.GetResourceVersion() + "/";
}
public static string GetTextLanguage()
{
return GetResourceLanguage();
}
public static string GetResourceLanguage()
{
return _languagePref;
}
public static string GetSoundMovieLanguageFolderName()
{
return _languageSoundPref + "/";
}
public static string GetSoundMovieLanguage()
{
return _languageSoundPref;
}
}