Files
SVSimServer/SVSim.BattleEngine/Shim/View/HeadlessHandViewStub.cs
gamer147 e96cc3363c refactor(battlenode): guard generated iface-impl against regen + stub visibility (M-HC-0 review)
- _IfaceImpl.g.cs: extend header to warn about hand-edits; tag all bare
  // HEADLESS-FIX lines with their milestone (M13 on GetSideLogControl ×2)
  so `grep HEADLESS-FIX` reliably surfaces every block before a regen.
- HeadlessHandViewStub / HeadlessPlayQueueViewStub: narrow from public to
  internal sealed — both stubs are consumed only within SVSim.BattleEngine
  (via the generated partial impls); no public surface exposes the concrete
  type, so internal is correct and aligns with HeadlessIconAnimations.
- SessionBattleEngine.SeedMulliganInfoControl: add one-line comment on the
  GetComponent<MulliganInfoControl>() call explaining the shim's lazy
  materialisation behaviour (otherwise reads like a guaranteed NRE).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-06 20:20:34 -04:00

29 lines
1.6 KiB
C#

// AUTHORED SHIM (not copied). A non-null no-op HandViewBase the headless emit path needs.
//
// On the OperateMgr/network play path, BattlePlayerBase.SetupActionProcessorEvent subscribes an
// OnBeforePlayCard handler that calls BattleView.HandView.RemoveCardFromView (BattlePlayerBase.cs:1422) —
// a pure presentation-layer hand-card removal. The m1_stub_gen generated IBattlePlayerView.HandView getter
// returns default! (null), so the call NREs. The direct-ActionProcessor solo oracles never hit this
// (SetupActionProcessorEvent is OperateMgr-only). Seed a single shared no-op HandViewBase whose card-view
// list is non-null so RemoveCardFromView is a safe no-op (the played card is never in this view's list, so
// the abstract RearrangeHand is never reached). Nothing here touches game state.
using UnityEngine;
namespace Wizard.Battle.View
{
internal sealed class HeadlessHandViewStub : HandViewBase
{
// Shared instance the generated IBattlePlayerView.HandView getters return headless.
public static readonly HeadlessHandViewStub Instance = new HeadlessHandViewStub();
// Base param ctor initializes the protected _battleCardViewList (the default ctor leaves it null,
// which RemoveCardFromView would NRE on). CreateHandControl is overridden to a null no-op below.
public HeadlessHandViewStub() : base(null, null) { }
protected override void RearrangeHand(float rearrangeTime, bool isNewReplayMoveTurn = false) { }
protected override HandControl CreateHandControl(GameObject handGameObject, BattleCamera battleCamera) => null;
}
}