Squashes 146 commits from battle-engine-extraction. Net: 2,045 files changed, +11,896 / -158,687 lines. Ships engine passes 4-7 (dead-code cull, view-layer stub, receive-path shrink) plus the Phase-5 AsyncLocal ambient deletion that turns concurrent battles into a type-system property rather than a scope contract. ## What landed **Passes 4-7 (chunks 1-34):** Extended the Phase-4 const-false collapse into a cascading cull across the skill graph, view layer, and receive-path periphery. Six mode flags (IsWatchBattle/IsReplayBattle/IsAdmin/IsAdminWatch/IsPuzzleQuest/ IsAINetwork) became `const false`, every guarded block deleted. Field*.cs subclass ctors + BackGroundBase + ObjectChecker culled to no-ops. Mulligan family reworked to take a mgr param through IMulliganMgr.InitMulligan. Emotion/Recovery/Resource clusters null-stubbed. Prediction/OperationSimulator/ skill filters converted from static ambient reads to per-mgr reads via SkillPrm.ownerCard.SelfBattlePlayer.BattleMgr / ins.BattleMgr / this.BattleMgr. **Phase-5 ambient rip (chunks 35-47):** Deleted BattleAmbient / BattleAmbient- Context / TestBattleScope in full. Every per-battle mutable slot now lives on the mgr instance itself: mgr.InstanceIsForecast / InstanceIsRandomDraw / InstanceRecoveryInfo / InstanceViewerId / InstanceNetworkAgent / GameMgr BattleManagerBase.GetIns() returns null unconditionally; the residual static flags + 3 façades (Certification.ViewerId, Data.BattleRecoveryInfo, ToolboxGame.RealTimeNetworkAgent) are null-tolerant defaults kept for the handful of engine-internal readers that still reference their types. Zero BattleAmbient references anywhere in engine + node + tests. Added pre-seeded GameMgr ctor overload threaded through the mgr chain (BattleManagerBase → SingleBattleMgr / NetworkBattleManagerBase → NetworkStandard- BattleMgr → HeadlessBattleMgr / HeadlessNetworkBattleMgr). Fixtures build a GameMgr, seed it via HeadlessEngineEnv.SeedCharaIds/SeedNetUser, and pass it to the mgr's ctor — no ambient reach. Node side (SVSim.BattleNode/SessionBattleEngine): _ctx replaced with a plain GameMgr field; 34 `using var _ambient = BattleAmbient.Enter(_ctx)` scope wraps ripped from every accessor and mutator; EngineGlobalInit.WirePerSessionGameMgr takes GameMgr as a param and runs from SessionBattleEngine.SetupInternal BEFORE mgr construction. Test side: TestBattleScope deleted; 18 fixture [SetUp]s migrated to `HeadlessEngineEnv.EnsureProcessGlobals()`; MultiInstanceEngineTests rewritten around per-mgr construction (GetIns() → null is the pinned invariant). ## Regression fixes - **chunk-48** (MulliganCtrl): chunk-35's `= null` stubs on card lookups broke the live receive-driven Deal path (BattlePlayerBase.DrawCard NRE'd downstream of NetworkPlayerMulliganCtrl.StartMulliganVfx). Restored the three lookups via `_battlePlayer.BattleMgr.GetBattleCardIdx`. Engine tests were satisfied by the WireMulliganPhase seam; unit tests exposed the live-path gap. ## Ship state - SVSim.BattleEngine.Tests: 56/56 pass, 2 skip - SVSim.UnitTests: 1554/1554 pass (was 1523/31-fail before chunk 48) - Solution build: 0 source warnings (40 pre-existing NU1902 MessagePack CVEs in SVSim.EmulatedEntrypoint, unrelated) - Sequential PVP smoke: verified live (two back-to-back battles, no regression on cleanup/spinup) - Concurrent PVP smoke: verified live Adds tools/engine-port/ClosureAnalyzer/ — the Roslyn transitive-type-closure analyzer needed to make future cascade cleanup safe (per feedback memory "Engine cleanup needs closure tool" from the 2026-06-28 pass-3 failure). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
66 lines
1.5 KiB
C#
66 lines
1.5 KiB
C#
using System.Collections.Generic;
|
|
|
|
namespace Wizard;
|
|
|
|
public static class NetworkDefine
|
|
{
|
|
public enum MAINTENANCE_TYPE
|
|
{
|
|
PROFILE_MAINTENANCE = 2001,
|
|
GIFT_MAINTENANCE = 2003,
|
|
SHOP_CARDPACK_MAINTENANCE = 2007,
|
|
SHOP_BUILDDECK_MAINTENANCE = 2032,
|
|
SHOP_SLEEVE_MAINTENANCE = 2008,
|
|
SHOP_SKIN_MAINTENANCE = 2024,
|
|
SHOP_ITEM_MAINTENANCE = 2037,
|
|
MISSION_MAINTENANCE = 2010,
|
|
ROOM_BATTLE_MAINTENANCE = 2014,
|
|
STORY_MAINTENANCE = 2015,
|
|
CARD_MAINTENANCE = 2018,
|
|
DECK_MAINTENANCE = 2019,
|
|
ROOM_TWOPICK_MAINTENANCE = 2029,
|
|
ROOM_ALL_MAINTENANCE = 2030,
|
|
ROOM_WATCHING_MAINTENANCE = 2031,
|
|
FREEBATTLE_UNLIMITED = 2044,
|
|
FREEBATTLE_ROTATION = 2045,
|
|
RANKBATTLE_UNLIMITED = 2046,
|
|
RANKBATTLE_ROTATION = 2047,
|
|
ROOM_ROTATION = 2049,
|
|
COLOSSEUM = 2050,
|
|
GUILD_MAINTENANCE = 2054,
|
|
ARENA_SEALED_BATTLE_MAINTENANCE = 2056,
|
|
FREEBATTLE_PREROTATION = 2065,
|
|
BATTLE_PASS = 2070,
|
|
AUTO_DECK_CREATE = 2080,
|
|
FREEBATTLE_CROSSOVER = 2084,
|
|
RANKBATTLE_CROSSOVER = 2085,
|
|
FREEBATTLE_MYROTATION = 2093,
|
|
BOSS_RUSH = 2096,
|
|
REPLAY_ALL = 2034,
|
|
NEWREPLAY_ALL = 2097,
|
|
NEWREPLAY_EXCLUDE_ROTATION = 2098,
|
|
NEWREPLAY_RECORD = 2099,
|
|
FREEBATTLE_AVATAR = 2103}
|
|
|
|
public enum ServerBattleType
|
|
{
|
|
Practice = 1,
|
|
Story = 2,
|
|
Free = 3,
|
|
Rank = 4,
|
|
OpenRoom = 6,
|
|
TwoPick = 11,
|
|
RoomTwoPick = 13,
|
|
Colosseum = 21,
|
|
ColosseumTwoPick = 22,
|
|
Quest = 37,
|
|
Sealed = 32,
|
|
Gathering = 34,
|
|
OfflineEvent = 40,
|
|
Competition = 42,
|
|
BossRushQuest = 45,
|
|
SecretBossQuest = 46,
|
|
CompetitionTwoPick = 47
|
|
}
|
|
}
|