Files
SVSimServer/SVSim.BattleEngine/Engine/Wizard/AIDataLibrary.cs
gamer147 2d9a6eea4b engine cleanup passes 4-7 + multi-instancing ambient rip
Squashes 146 commits from battle-engine-extraction. Net: 2,045 files changed,
+11,896 / -158,687 lines. Ships engine passes 4-7 (dead-code cull, view-layer
stub, receive-path shrink) plus the Phase-5 AsyncLocal ambient deletion that
turns concurrent battles into a type-system property rather than a scope
contract.

## What landed

**Passes 4-7 (chunks 1-34):** Extended the Phase-4 const-false collapse into a
cascading cull across the skill graph, view layer, and receive-path periphery.
Six mode flags (IsWatchBattle/IsReplayBattle/IsAdmin/IsAdminWatch/IsPuzzleQuest/
IsAINetwork) became `const false`, every guarded block deleted. Field*.cs
subclass ctors + BackGroundBase + ObjectChecker culled to no-ops. Mulligan
family reworked to take a mgr param through IMulliganMgr.InitMulligan.
Emotion/Recovery/Resource clusters null-stubbed. Prediction/OperationSimulator/
skill filters converted from static ambient reads to per-mgr reads via
SkillPrm.ownerCard.SelfBattlePlayer.BattleMgr / ins.BattleMgr / this.BattleMgr.

**Phase-5 ambient rip (chunks 35-47):** Deleted BattleAmbient / BattleAmbient-
Context / TestBattleScope in full. Every per-battle mutable slot now lives on
the mgr instance itself:
  mgr.InstanceIsForecast / InstanceIsRandomDraw / InstanceRecoveryInfo /
  InstanceViewerId / InstanceNetworkAgent / GameMgr
BattleManagerBase.GetIns() returns null unconditionally; the residual static
flags + 3 façades (Certification.ViewerId, Data.BattleRecoveryInfo,
ToolboxGame.RealTimeNetworkAgent) are null-tolerant defaults kept for the
handful of engine-internal readers that still reference their types. Zero
BattleAmbient references anywhere in engine + node + tests.

Added pre-seeded GameMgr ctor overload threaded through the mgr chain
(BattleManagerBase → SingleBattleMgr / NetworkBattleManagerBase → NetworkStandard-
BattleMgr → HeadlessBattleMgr / HeadlessNetworkBattleMgr). Fixtures build a
GameMgr, seed it via HeadlessEngineEnv.SeedCharaIds/SeedNetUser, and pass it
to the mgr's ctor — no ambient reach.

Node side (SVSim.BattleNode/SessionBattleEngine): _ctx replaced with a plain
GameMgr field; 34 `using var _ambient = BattleAmbient.Enter(_ctx)` scope wraps
ripped from every accessor and mutator; EngineGlobalInit.WirePerSessionGameMgr
takes GameMgr as a param and runs from SessionBattleEngine.SetupInternal
BEFORE mgr construction.

Test side: TestBattleScope deleted; 18 fixture [SetUp]s migrated to
`HeadlessEngineEnv.EnsureProcessGlobals()`; MultiInstanceEngineTests rewritten
around per-mgr construction (GetIns() → null is the pinned invariant).

## Regression fixes

- **chunk-48** (MulliganCtrl): chunk-35's `= null` stubs on card lookups broke
  the live receive-driven Deal path (BattlePlayerBase.DrawCard NRE'd downstream
  of NetworkPlayerMulliganCtrl.StartMulliganVfx). Restored the three lookups
  via `_battlePlayer.BattleMgr.GetBattleCardIdx`. Engine tests were satisfied
  by the WireMulliganPhase seam; unit tests exposed the live-path gap.

## Ship state

- SVSim.BattleEngine.Tests: 56/56 pass, 2 skip
- SVSim.UnitTests: 1554/1554 pass (was 1523/31-fail before chunk 48)
- Solution build: 0 source warnings (40 pre-existing NU1902 MessagePack CVEs
  in SVSim.EmulatedEntrypoint, unrelated)
- Sequential PVP smoke: verified live (two back-to-back battles, no regression
  on cleanup/spinup)
- Concurrent PVP smoke: verified live

Adds tools/engine-port/ClosureAnalyzer/ — the Roslyn transitive-type-closure
analyzer needed to make future cascade cleanup safe (per feedback memory
"Engine cleanup needs closure tool" from the 2026-06-28 pass-3 failure).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-07-03 19:18:54 -04:00

172 lines
4.2 KiB
C#

using System.Collections.Generic;
namespace Wizard;
public class AIDataLibrary
{
private readonly AIDeckData _basicDic;
private readonly AIDeckData _commonDic;
private readonly AIDeckData _allyCommonDic;
private readonly Dictionary<string, AIDeckData> _deckDic;
private readonly AIStyleData _commonStyle;
private readonly Dictionary<string, AIStyleData> _deckStyleDic;
private AISetUpData setupInfoBuf;
private readonly Dictionary<string, AIEmoteSet> emoteDic;
public AISetUpData SetupInfoBuf => setupInfoBuf;
public AIDataLibrary()
{
_basicDic = new AIDeckData();
_commonDic = new AIDeckData();
_allyCommonDic = new AIDeckData();
_commonStyle = new AIStyleData();
_deckStyleDic = new Dictionary<string, AIStyleData>();
_deckDic = new Dictionary<string, AIDeckData>();
emoteDic = new Dictionary<string, AIEmoteSet>();
}
public void Clear()
{
_basicDic.Clear();
_commonDic.Clear();
_allyCommonDic.Clear();
_deckDic.Clear();
_commonStyle.Clear();
_deckStyleDic.Clear();
emoteDic.Clear();
}
public void SaveBattleSetUpInfo(int classID, AI_LOGIC_LV logicLv, string deckName, string styleName, string emoteName, bool useEmote, bool useInnerEmote, int enemyAiID, List<int> specialAbilityList)
{
setupInfoBuf = new AISetUpData(classID, logicLv, deckName, styleName, emoteName, useEmote, useInnerEmote, enemyAiID, specialAbilityList);
}
public AIStyleData CreateStyle(int enemyClassID, AIStyleData deckStyle)
{
AIStyleData aIStyleData = new AIStyleData(new List<AICategory>
{
AICategory.ALL,
AIPolicyData.ConvertClassIDToCategory(enemyClassID)
});
aIStyleData.MixInStyle(_commonStyle);
if (deckStyle != null)
{
aIStyleData.MixInStyle(deckStyle);
}
return aIStyleData;
}
public void RegisterBasicData(AICardDataAsset asset)
{
_basicDic.RegisterCardData(asset);
}
public bool RegisterCommonData(AICardDataAsset asset)
{
AICardData mergeData = _basicDic.SearchCardData(asset.CardID);
return _commonDic.RegisterCardData(asset, mergeData);
}
public bool RegisterAllyCommonData(AICardDataAsset asset)
{
AICardData mergeData = _basicDic.SearchCardData(asset.CardID);
return _allyCommonDic.RegisterCardData(asset, mergeData);
}
public void RegisterDeckToDeckDic(string deckName, List<AICardDataAsset> cardDataAssetList)
{
AIDeckData aIDeckData = new AIDeckData();
for (int i = 0; i < cardDataAssetList.Count; i++)
{
AICardDataAsset aICardDataAsset = cardDataAssetList[i];
int cardID = aICardDataAsset.CardID;
bool useCommon = aICardDataAsset.UseCommon;
AICardData mergeData = ((!useCommon) ? _basicDic.SearchCardData(cardID) : _allyCommonDic.SearchCardData(cardID));
aIDeckData.RegisterCardData(aICardDataAsset, mergeData, useCommon);
}
RegisterDeck(deckName, aIDeckData);
}
public bool RegisterDeck(string deckName, AIDeckData deck)
{
if (_deckDic.ContainsKey(deckName))
{
return false;
}
_deckDic.Add(deckName, deck);
return true;
}
public bool RegisterEmoteSet(string emoteSetName, AIEmoteSet emoteSet)
{
if (emoteDic.ContainsKey(emoteSetName))
{
return false;
}
emoteDic.Add(emoteSetName, emoteSet);
return true;
}
public AIDeckData SearchDeckData(string name)
{
if (!_deckDic.ContainsKey(name))
{
return null;
}
return _deckDic[name];
}
public AIStyleData SearchDeckStyle(string name)
{
if (!_deckStyleDic.ContainsKey(name))
{
return null;
}
return _deckStyleDic[name];
}
public AIEmoteSet SearchEmoteSet(string name)
{
if (!emoteDic.ContainsKey(name))
{
return null;
}
return emoteDic[name];
}
public AIDeckData GetCommonDic()
{
return _commonDic;
}
public AIDeckData GetAllyCommonDic()
{
return _allyCommonDic;
}
public void RegisterCommonStyle(List<AIPolicyDataAsset> assetList)
{
_commonStyle.CreateFromAsset(assetList);
}
public bool RegisterDeckStyle(string styleName, List<AIPolicyDataAsset> assetList)
{
if (_deckStyleDic.ContainsKey(styleName))
{
return false;
}
AIStyleData aIStyleData = new AIStyleData();
aIStyleData.CreateFromAsset(assetList);
_deckStyleDic.Add(styleName, aIStyleData);
return true;
}
}