Files
SVSimServer/SVSim.BattleNode
gamer147 2d32051cc0 refactor(battlenode): key dispatch on OpponentIsAckOnly, drop per-frame BattleType switch
Behavior-identical; 231 BattleNode tests green with ZERO test changes.

The 10 handler arms no longer switch on BattleType:
- 4 Bot arms gate on the new FrameDispatchContext.OpponentIsAckOnly
  (Other is not IHasHandshakePhase) — the participant property the audit asked for.
- 6 relay arms drop the Type == Pvp guard; it was redundant with BothSidesAfterReady()
  (only a two-real-player session has both handshake phases). Its doc now records that.
- FrameDispatchContext.Type removed (+ the Type = Type in BuildContext). BattleSession.Type
  stays for the session-level drop cascade.

Zero test churn because the stubs already encode the split: FakeRealParticipant/ProbeParticipant
implement IHasHandshakePhase, the bot stub FakeParticipant doesn't, and NewBotSession uses it as
the opponent.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-05 08:20:56 -04:00
..

SVSim.BattleNode

Socket.IO node-server emulation for in-battle real-time traffic — the second of prod's 4-server topology. Handles Matched / BattleStart / Deal / per-action PlayActions / Echo / TurnEnd between a client and a server-side opponent, for TK2 PvP and AI rank battles.

Documentation lives in the outer repo

This project's canonical reference is a single hub doc in the outer SVSim repo (this directory is an inner git repo, so the doc isn't tracked alongside the code):

docs/battle-node.md (from the SVSim root) — architecture, the dispatch matrix by battle type, connect handshake + crypto, BattleFinish wire-result semantics, SIO/EIO event coverage, reliability (pubSeq/playSeq/Gungnir), wire-format gotchas, where-to-extend, the manual smoke walkthrough, and the consolidated open-items list.

Relative path from here: ../../../docs/battle-node.md.

Detailed per-URI wire shapes are in docs/api-spec/in-battle/; the hub links into them.

Keep docs/battle-node.md updated in the same change whenever you alter node behavior.