Files
SVSimServer/SVSim.EmulatedEntrypoint/Controllers/ArenaColosseumBattleController.cs
gamer147 cbee0f9a50 feat(arena-colosseum): playable bracket + rank-match promotion (phase 2)
Closes 4 more arena-colosseum spec shapes (6/16 → 10/16): the dual-prefix
battle URLs (colosseum_battle/* and colosseum_rank_battle/*) for both
do_matching and per-match finish, plus the bracket-end /finish + /retire
pair on /arena_colosseum.

* ColosseumProgressionService: pure-logic decisions for win-threshold
  advancement, 3008 promotion trigger, and per-round reward bundles.
  Extends ColosseumRoundsConfig with FinishRewards/RetireRewards per
  round + a top-level ChampionRewards list.
* MatchContextBuilder.BuildForColosseumAsync: lifts the registered deck
  via IDeckRepository (NOT viewer-graph) per project_ef_nav_include_pitfall.
* ArenaColosseumBattleController: dual route prefixes off one controller
  via explicit absolute [HttpPost("/...")] routes — does NOT extend
  SVSimController's [Route("[controller]")]. Same pattern as FreeBattle.
  URL-vs-IsRankMatching mismatch returns 400 with a phase-mismatch error;
  no-deck triggers the standard 3001 matchmaking-illegal state. 3008
  flips run.IsRankMatching exactly once via the progression service.
* /arena_colosseum/finish + /retire share FinishResponse (rewards +
  reward_list + colosseum_status). Champion finish appends ChampionRewards
  and surfaces colosseum_status.is_champion = true. Both delete the run
  row after granting via IInventoryTransaction.GrantAsync.
* DI: ModePolicy entries for "colosseum_battle" and "colosseum_rank_battle".
* Tests: 8 progression-service unit tests (pure logic), 5 battle-controller
  HTTP tests, 5 bracket-terminate HTTP tests, 2 full-bracket E2E walks
  (champion path + retire mid-round). Full suite: 1331/1331.
2026-06-13 12:32:56 -04:00

176 lines
7.0 KiB
C#

using System.Text.Json;
using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Mvc;
using SVSim.BattleNode.Bridge;
using SVSim.Database.Repositories.Viewer;
using SVSim.EmulatedEntrypoint.Constants;
using SVSim.EmulatedEntrypoint.Matching;
using SVSim.EmulatedEntrypoint.Models.Dtos.ArenaColosseum;
using SVSim.EmulatedEntrypoint.Security;
using SVSim.EmulatedEntrypoint.Security.SteamSessionAuthentication;
using SVSim.EmulatedEntrypoint.Services;
using SVSim.EmulatedEntrypoint.Services.ArenaColosseum;
namespace SVSim.EmulatedEntrypoint.Controllers;
/// <summary>
/// Per-match URLs for the Colosseum bracket — the dual <c>colosseum_battle/*</c> +
/// <c>colosseum_rank_battle/*</c> route family. Does NOT extend <see cref="SVSimController"/>'s
/// <c>[Route("[controller]")]</c> because we need explicit absolute routes for two prefixes
/// off one controller (same pattern as <see cref="FreeBattleController"/>).
/// <para>
/// The URL is the bracket-phase signal per do-matching.md §"server-side bidirectional
/// mapping"; <see cref="ViewerArenaColosseumRun.IsRankMatching"/> flips to true once the
/// node has signalled <c>matching_state == 3008</c> on a prior <c>do_matching</c>.
/// </para>
/// </summary>
[ApiController]
[Authorize(AuthenticationSchemes = SteamAuthenticationConstants.SchemeName)]
public sealed class ArenaColosseumBattleController : ControllerBase
{
/// <summary>Per FinishTaskBase.IsEffectiveErrorCode — code 3502 ("battle already finished")
/// is tolerated as a non-error retry, parsed the same as 1.</summary>
private const int BattleAlreadyFinishedResultCode = 3502;
private readonly IMatchContextBuilder _ctxBuilder;
private readonly IMatchingResolver _resolver;
private readonly IArenaColosseumRunRepository _runs;
private readonly IColosseumProgressionService _progression;
private readonly ILogger<ArenaColosseumBattleController> _log;
public ArenaColosseumBattleController(
IMatchContextBuilder ctxBuilder,
IMatchingResolver resolver,
IArenaColosseumRunRepository runs,
IColosseumProgressionService progression,
ILogger<ArenaColosseumBattleController> log)
{
_ctxBuilder = ctxBuilder;
_resolver = resolver;
_runs = runs;
_progression = progression;
_log = log;
}
private bool TryGetViewerId(out long viewerId)
{
viewerId = 0;
var claim = User.Claims.FirstOrDefault(c => c.Type == ShadowverseClaimTypes.ViewerIdClaim)?.Value;
return claim is not null && long.TryParse(claim, out viewerId);
}
[HttpPost("/colosseum_battle/do_matching")]
public Task<IActionResult> DoMatchingPreRank(
[FromBody] ColosseumDoMatchingRequestDto req, CancellationToken ct)
=> DoMatchingInternal(isRankUrl: false, req, ct);
[HttpPost("/colosseum_rank_battle/do_matching")]
public Task<IActionResult> DoMatchingPostRank(
[FromBody] ColosseumDoMatchingRequestDto req, CancellationToken ct)
=> DoMatchingInternal(isRankUrl: true, req, ct);
[HttpPost("/colosseum_battle/finish")]
public Task<IActionResult> FinishPreRank(
[FromBody] ColosseumBattleFinishRequestDto req, CancellationToken ct)
=> FinishInternal(isRankUrl: false, req, ct);
[HttpPost("/colosseum_rank_battle/finish")]
public Task<IActionResult> FinishPostRank(
[FromBody] ColosseumBattleFinishRequestDto req, CancellationToken ct)
=> FinishInternal(isRankUrl: true, req, ct);
private async Task<IActionResult> DoMatchingInternal(
bool isRankUrl, ColosseumDoMatchingRequestDto req, CancellationToken ct)
{
if (!TryGetViewerId(out var vid)) return Unauthorized();
var run = await _runs.GetByViewerIdAsync(vid);
if (run is null)
{
return BadRequest(new { error = "arena_colosseum_no_active_run" });
}
if (isRankUrl != run.IsRankMatching)
{
return BadRequest(new
{
error = "colosseum_url_phase_mismatch",
is_rank_matching = run.IsRankMatching,
requested_rank_url = isRankUrl,
});
}
MatchContext ctx;
try
{
ctx = await _ctxBuilder.BuildForColosseumAsync(vid);
}
catch (InvalidOperationException ex)
{
_log.LogWarning(ex,
"Colosseum BuildForColosseumAsync failed for viewer {Vid}; returning 3001.", vid);
return Ok(new Models.Dtos.FreeBattle.DoMatchingResponseDto
{
MatchingState = 3001,
NodeServerUrl = "",
});
}
var mode = isRankUrl ? "colosseum_rank_battle" : "colosseum_battle";
var resolution = await _resolver.ResolveAsync(mode, new BattlePlayer(vid, ctx), ct);
// Promotion: server flips IsRankMatching once on the 3008 signal. Subsequent battle
// URLs must use the rank prefix. (Plan §"matching_state == 3008 is the promotion trigger".)
if (_progression.ShouldPromoteToRankMatching(run, resolution.MatchingState))
{
run.IsRankMatching = true;
await _runs.UpsertAsync(run);
}
return Ok(new Models.Dtos.FreeBattle.DoMatchingResponseDto
{
MatchingState = resolution.MatchingState,
BattleId = resolution.BattleId,
NodeServerUrl = resolution.NodeServerUrl,
});
}
private async Task<IActionResult> FinishInternal(
bool isRankUrl, ColosseumBattleFinishRequestDto req, CancellationToken ct)
{
if (!TryGetViewerId(out var vid)) return Unauthorized();
var run = await _runs.GetByViewerIdAsync(vid);
if (run is null)
{
return BadRequest(new { error = "arena_colosseum_no_active_run" });
}
// Match-result tracking: 1 = win, 2 = loss, 0 = draw/abort. Record_list mirrors
// ColosseumTopTask.battle_results.result_list (1=win, 0=loss). is_retire surfaces
// as a non-counted result — does not advance the bracket.
bool counts = req.IsRetire == 0;
if (counts)
{
bool isWin = req.BattleResult == 1;
run.BattleCountThisRound += 1;
if (isWin) run.WinCount += 1;
else run.LossCount += 1;
var resultList = ParseIntList(run.ResultListJson);
resultList.Add(isWin ? 1 : 0);
run.ResultListJson = JsonSerializer.Serialize(resultList);
await _runs.UpsertAsync(run);
}
// result_code 3502 ("battle already finished") is the idempotent-retry tolerance per
// FinishTaskBase.IsEffectiveErrorCode. Server emits standard data; the translation
// middleware sets the wire result_code via data_headers from the response envelope.
return Ok(new ColosseumBattleFinishResponseDto { BattleResult = req.BattleResult });
}
private static List<int> ParseIntList(string json) =>
string.IsNullOrEmpty(json)
? new()
: JsonSerializer.Deserialize<List<int>>(json) ?? new();
}