24180d5b4b
Quality pass from the 2026-06-04 BattleNode review (audit in the outer
repo). All changes are behavior-preserving — identical wire bytes,
verified by the full 1008-test suite staying green.
- Name scattered magic numbers: crypto key/IV lengths, outbound-sequencer
base, WS receive buffer / EIO ping / SID length, polite-close timeout,
upgrade-credential keys, battle-id digit math, deterministic-turn spin.
- resultCode = 1 -> (int)ReceiveNodeResultCode.Success across body records.
- Pong "3" -> EngineIoPacketType.Pong; remove dead NoOpBotParticipant.Touch
(replace with #pragma warning disable CS0067).
- Wire-flag enums, serialized as numbers via JsonNumberEnumConverter:
turnState -> TurnState{First,Second}, isSelf -> CardOwner{Opponent,Self},
open -> ChoiceVisibility{Hidden,Open}.
- isOfficial / isInvoke -> bool / bool? via new NumericBoolJsonConverter
(reads/writes 0/1; TDD'd). Scoped to the BattleNode wire boundary only;
MatchContext and the HTTP/AI-start path stay int (AI-start uses -1 as a
sentinel, so it is not boolean).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
35 lines
1.3 KiB
C#
35 lines
1.3 KiB
C#
using SVSim.BattleNode.Lifecycle;
|
|
using SVSim.BattleNode.Protocol;
|
|
|
|
namespace SVSim.BattleNode.Sessions.Dispatch.Handlers;
|
|
|
|
internal sealed class LoadedHandler : IFrameHandler
|
|
{
|
|
public IReadOnlyList<DispatchRoute> Handle(FrameDispatchContext ctx)
|
|
{
|
|
// case 3: Bot — silent (client populates opponent state from AIBattleStart HTTP data).
|
|
if (ctx.Type == BattleType.Bot && ctx.SenderPhase == BattleSessionPhase.AwaitingLoaded)
|
|
{
|
|
ctx.SenderPhase = BattleSessionPhase.AwaitingSwap;
|
|
return Array.Empty<DispatchRoute>();
|
|
}
|
|
|
|
// case 6: general — BattleStart (per-perspective) + Deal to the sender.
|
|
if (ctx.SenderPhase == BattleSessionPhase.AwaitingLoaded)
|
|
{
|
|
// A goes first deterministically; B goes second.
|
|
var turnState = ReferenceEquals(ctx.From, ctx.A) ? TurnState.First : TurnState.Second;
|
|
var r = new List<DispatchRoute>
|
|
{
|
|
new(ctx.From, ServerBattleFrames.BuildBattleStart(
|
|
ctx.From.Context, ctx.Other.Context, ctx.From.ViewerId, turnState), false),
|
|
new(ctx.From, ServerBattleFrames.BuildDeal(), false),
|
|
};
|
|
ctx.SenderPhase = BattleSessionPhase.AwaitingSwap;
|
|
return r;
|
|
}
|
|
|
|
return Array.Empty<DispatchRoute>();
|
|
}
|
|
}
|