24180d5b4b
Quality pass from the 2026-06-04 BattleNode review (audit in the outer
repo). All changes are behavior-preserving — identical wire bytes,
verified by the full 1008-test suite staying green.
- Name scattered magic numbers: crypto key/IV lengths, outbound-sequencer
base, WS receive buffer / EIO ping / SID length, polite-close timeout,
upgrade-credential keys, battle-id digit math, deterministic-turn spin.
- resultCode = 1 -> (int)ReceiveNodeResultCode.Success across body records.
- Pong "3" -> EngineIoPacketType.Pong; remove dead NoOpBotParticipant.Touch
(replace with #pragma warning disable CS0067).
- Wire-flag enums, serialized as numbers via JsonNumberEnumConverter:
turnState -> TurnState{First,Second}, isSelf -> CardOwner{Opponent,Self},
open -> ChoiceVisibility{Hidden,Open}.
- isOfficial / isInvoke -> bool / bool? via new NumericBoolJsonConverter
(reads/writes 0/1; TDD'd). Scoped to the BattleNode wire boundary only;
MatchContext and the HTTP/AI-start path stay int (AI-start uses -1 as a
sentinel, so it is not boolean).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
41 lines
2.1 KiB
C#
41 lines
2.1 KiB
C#
using System.Text.Json.Serialization;
|
|
|
|
namespace SVSim.BattleNode.Protocol.Bodies;
|
|
|
|
public sealed record MatchedBody(
|
|
[property: JsonPropertyName("selfInfo")] MatchedSelfInfo SelfInfo,
|
|
[property: JsonPropertyName("oppoInfo")] MatchedOppoInfo OppoInfo,
|
|
[property: JsonPropertyName("selfDeck")] IReadOnlyList<DeckCardRef> SelfDeck,
|
|
[property: JsonPropertyName("resultCode")] int ResultCode = (int)ReceiveNodeResultCode.Success) : IMsgBody;
|
|
|
|
// Note: `country_code` is deliberately snake_case among camelCase siblings — that's what prod
|
|
// sends on this frame (verified against the TK2 capture). Do NOT "normalize" it to countryCode.
|
|
public sealed record MatchedSelfInfo(
|
|
[property: JsonPropertyName("country_code")] string CountryCode,
|
|
[property: JsonPropertyName("userName")] string UserName,
|
|
[property: JsonPropertyName("sleeveId")] string SleeveId,
|
|
[property: JsonPropertyName("emblemId")] string EmblemId,
|
|
[property: JsonPropertyName("degreeId")] string DegreeId,
|
|
[property: JsonPropertyName("fieldId")] int FieldId,
|
|
[property: JsonPropertyName("isOfficial")]
|
|
[property: JsonConverter(typeof(NumericBoolJsonConverter))] bool IsOfficial,
|
|
[property: JsonPropertyName("oppoId")] long OppoId,
|
|
[property: JsonPropertyName("seed")] long Seed);
|
|
|
|
public sealed record MatchedOppoInfo(
|
|
[property: JsonPropertyName("country_code")] string CountryCode,
|
|
[property: JsonPropertyName("userName")] string UserName,
|
|
[property: JsonPropertyName("sleeveId")] string SleeveId,
|
|
[property: JsonPropertyName("emblemId")] string EmblemId,
|
|
[property: JsonPropertyName("degreeId")] string DegreeId,
|
|
[property: JsonPropertyName("fieldId")] int FieldId,
|
|
[property: JsonPropertyName("isOfficial")]
|
|
[property: JsonConverter(typeof(NumericBoolJsonConverter))] bool IsOfficial,
|
|
[property: JsonPropertyName("oppoId")] long OppoId,
|
|
[property: JsonPropertyName("seed")] long Seed,
|
|
[property: JsonPropertyName("oppoDeckCount")] int OppoDeckCount);
|
|
|
|
public sealed record DeckCardRef(
|
|
[property: JsonPropertyName("idx")] int Idx,
|
|
[property: JsonPropertyName("cardId")] long CardId);
|