Files
SVSimServer/SVSim.BattleEngine/Engine/Wizard/SceneTransition.cs
gamer147 2d9a6eea4b engine cleanup passes 4-7 + multi-instancing ambient rip
Squashes 146 commits from battle-engine-extraction. Net: 2,045 files changed,
+11,896 / -158,687 lines. Ships engine passes 4-7 (dead-code cull, view-layer
stub, receive-path shrink) plus the Phase-5 AsyncLocal ambient deletion that
turns concurrent battles into a type-system property rather than a scope
contract.

## What landed

**Passes 4-7 (chunks 1-34):** Extended the Phase-4 const-false collapse into a
cascading cull across the skill graph, view layer, and receive-path periphery.
Six mode flags (IsWatchBattle/IsReplayBattle/IsAdmin/IsAdminWatch/IsPuzzleQuest/
IsAINetwork) became `const false`, every guarded block deleted. Field*.cs
subclass ctors + BackGroundBase + ObjectChecker culled to no-ops. Mulligan
family reworked to take a mgr param through IMulliganMgr.InitMulligan.
Emotion/Recovery/Resource clusters null-stubbed. Prediction/OperationSimulator/
skill filters converted from static ambient reads to per-mgr reads via
SkillPrm.ownerCard.SelfBattlePlayer.BattleMgr / ins.BattleMgr / this.BattleMgr.

**Phase-5 ambient rip (chunks 35-47):** Deleted BattleAmbient / BattleAmbient-
Context / TestBattleScope in full. Every per-battle mutable slot now lives on
the mgr instance itself:
  mgr.InstanceIsForecast / InstanceIsRandomDraw / InstanceRecoveryInfo /
  InstanceViewerId / InstanceNetworkAgent / GameMgr
BattleManagerBase.GetIns() returns null unconditionally; the residual static
flags + 3 façades (Certification.ViewerId, Data.BattleRecoveryInfo,
ToolboxGame.RealTimeNetworkAgent) are null-tolerant defaults kept for the
handful of engine-internal readers that still reference their types. Zero
BattleAmbient references anywhere in engine + node + tests.

Added pre-seeded GameMgr ctor overload threaded through the mgr chain
(BattleManagerBase → SingleBattleMgr / NetworkBattleManagerBase → NetworkStandard-
BattleMgr → HeadlessBattleMgr / HeadlessNetworkBattleMgr). Fixtures build a
GameMgr, seed it via HeadlessEngineEnv.SeedCharaIds/SeedNetUser, and pass it
to the mgr's ctor — no ambient reach.

Node side (SVSim.BattleNode/SessionBattleEngine): _ctx replaced with a plain
GameMgr field; 34 `using var _ambient = BattleAmbient.Enter(_ctx)` scope wraps
ripped from every accessor and mutator; EngineGlobalInit.WirePerSessionGameMgr
takes GameMgr as a param and runs from SessionBattleEngine.SetupInternal
BEFORE mgr construction.

Test side: TestBattleScope deleted; 18 fixture [SetUp]s migrated to
`HeadlessEngineEnv.EnsureProcessGlobals()`; MultiInstanceEngineTests rewritten
around per-mgr construction (GetIns() → null is the pinned invariant).

## Regression fixes

- **chunk-48** (MulliganCtrl): chunk-35's `= null` stubs on card lookups broke
  the live receive-driven Deal path (BattlePlayerBase.DrawCard NRE'd downstream
  of NetworkPlayerMulliganCtrl.StartMulliganVfx). Restored the three lookups
  via `_battlePlayer.BattleMgr.GetBattleCardIdx`. Engine tests were satisfied
  by the WireMulliganPhase seam; unit tests exposed the live-path gap.

## Ship state

- SVSim.BattleEngine.Tests: 56/56 pass, 2 skip
- SVSim.UnitTests: 1554/1554 pass (was 1523/31-fail before chunk 48)
- Solution build: 0 source warnings (40 pre-existing NU1902 MessagePack CVEs
  in SVSim.EmulatedEntrypoint, unrelated)
- Sequential PVP smoke: verified live (two back-to-back battles, no regression
  on cleanup/spinup)
- Concurrent PVP smoke: verified live

Adds tools/engine-port/ClosureAnalyzer/ — the Roslyn transitive-type-closure
analyzer needed to make future cascade cleanup safe (per feedback memory
"Engine cleanup needs closure tool" from the 2026-06-28 pass-3 failure).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-07-03 19:18:54 -04:00

404 lines
11 KiB
C#

using System;
using System.Collections.Generic;
using Cute;
using Wizard.Story;
using Wizary.StorySelectionWorld;
namespace Wizard;
public class SceneTransition
{
public class TransitionData
{
public struct SceneData
{
public UIManager.ViewScene _scene;
public string textId;
public SceneData(UIManager.ViewScene scene, string id)
{
_scene = scene;
textId = id;
}
}
private static readonly Dictionary<string, SceneData> _transitionDictScene = new Dictionary<string, SceneData>
{
{
"decks_list",
new SceneData(UIManager.ViewScene.DeckList, null)
},
{
"cards",
new SceneData(UIManager.ViewScene.CardAllList, null)
},
{
"arena",
new SceneData(UIManager.ViewScene.MyPage, null)
},
{
"2pick",
new SceneData(UIManager.ViewScene.MyPage, null)
},
{
"card_pack",
new SceneData(UIManager.ViewScene.Gacha, "Dia_BuyCard_001_Title")
},
{
"profile",
new SceneData(UIManager.ViewScene.Profile, null)
},
{
"supplies",
new SceneData(UIManager.ViewScene.MyPage, null)
},
{
"deck_pack",
new SceneData(UIManager.ViewScene.BuildDeckPurchasePage, "MyPage_0053")
},
{
"mission",
new SceneData(UIManager.ViewScene.Mission, null)
},
{
"story_leader_select",
new SceneData(UIManager.ViewScene.StorySelectPage, null)
},
{
"story_section_select",
new SceneData(UIManager.ViewScene.StorySelectionWorld, null)
},
{
"leader_skin",
new SceneData(UIManager.ViewScene.ClassSkinPurchasePage, "Common_0143")
},
{
"limited_story",
new SceneData(UIManager.ViewScene.StorySelectPage, null)
},
{
"buy_cards",
new SceneData(UIManager.ViewScene.MyPage, null)
},
{
"sleeve",
new SceneData(UIManager.ViewScene.CardSleevePurchasePage, "Mail_0034")
},
{
"colosseum",
new SceneData(UIManager.ViewScene.MyPage, null)
},
{
"quest",
new SceneData(UIManager.ViewScene.QuestSelectionPage, null)
},
{
"crossover",
new SceneData(UIManager.ViewScene.CrossoverPortal, null)
},
{
"bingo",
new SceneData(UIManager.ViewScene.Bingo, null)
},
{
"card_vote",
new SceneData(UIManager.ViewScene.NeutralPopularityVote, null)
},
{
"leader_skin_vote",
new SceneData(UIManager.ViewScene.LeaderPopularityVote, null)
},
{
"mypage_bg",
new SceneData(UIManager.ViewScene.MyPage, null)
},
{
"free_match",
new SceneData(UIManager.ViewScene.MyPage, null)
}
};
public UIManager.ViewScene Scene { get; private set; }
public UIManager.ChangeViewSceneParam Param { get; private set; }
public int? Status { get; set; }
public MyPageSub? Sub { get; private set; }
public KeyValuePair<string, int>? PlayerPref { get; private set; }
public int? UpdateFooter { get; private set; }
public TransitionData(string s)
{
Scene = _transitionDictScene[s]._scene;
Param = new UIManager.ChangeViewSceneParam();
if (s == null)
{
return;
}
switch (s)
{
case "free_match":
Param = CreateMyPageChangeParam(2, isCutCard: true);
Param.OnFinishChangeView = delegate
{
MyPageMenu.Instance.GoToFreeMatch();
};
break;
case "arena":
Param = CreateMyPageChangeParam(3, isCutCard: true);
break;
case "2pick":
Param = CreateMyPageChangeParam(3, isCutCard: true);
Param.OnFinishChangeView = delegate
{
MyPageMenu.Instance.GoToChallengeMenu();
};
break;
case "colosseum":
Sub = MyPageSub.Colosseum;
Param = CreateMyPageChangeParam(3, isCutCard: true);
Param.OnFinishChangeView = delegate
{
MyPageMenu.Instance.GoToColosseum();
};
break;
case "supplies":
Sub = MyPageSub.Supply;
Param = CreateMyPageChangeParam(5, isCutCard: true);
Param.OnFinishChangeView = delegate
{
MyPageMenu.Instance.GoToShopSupply();
};
break;
case "buy_cards":
Sub = MyPageSub.Gacha;
Param = CreateMyPageChangeParam(5, isCutCard: true);
Param.OnFinishChangeView = delegate
{
MyPageMenu.Instance.GoToShopCard();
};
break;
case "mypage_bg":
Param = CreateMyPageChangeParam(0, isCutCard: true);
Param.OnFinishChangeView = delegate
{
MyPageBGCustomDialog.Create(MyPageMenu.Instance.HomeMenu.OnDecideMyPageBG);
};
break;
case "leader_skin":
UpdateFooter = 5;
PlayerPref = PlayerPrefsWrapper.SCENE_TRANSITION_VIEW_SKIN_SERIES_ID;
break;
case "deck_pack":
UpdateFooter = 5;
PlayerPref = PlayerPrefsWrapper.SCENE_TRANSITION_VIEW_DECK_SERIES_ID;
break;
case "card_pack":
UpdateFooter = 5;
break;
case "sleeve":
UpdateFooter = 5;
PlayerPref = PlayerPrefsWrapper.SCENE_TRANSITION_VIEW_SLEEVE_SERIES_ID;
break;
case "limited_story":
Data.SelectedStoryInfo = new SelectedStoryInfo(StoryEntranceType.LimitedStory);
break;
case "story_section_select":
Data.SelectedStoryInfo = new SelectedStoryInfo(StoryEntranceType.AllStory);
break;
}
}
public static bool HasTransitionData(string s)
{
return _transitionDictScene.ContainsKey(s);
}
}
public enum MyPageSub
{
Colosseum,
Supply,
Gacha
}
private static void GoToMission(int status)
{
MissionInfoTask missionInfoTask = null; // Pre-Phase-5b: headless has no MissionInfoTask
missionInfoTask.SetParameter();
UIManager.GetInstance().StartCoroutine(Toolbox.NetworkManager.Connect(missionInfoTask, delegate
{
Mission.ChangeViewSceneTransitionMissionViewTab((Mission.MissionViewTab)status);
}));
}
public static bool IsMaintenance(TransitionData data)
{
NetworkDefine.MAINTENANCE_TYPE? mAINTENANCE_TYPE = null;
switch (data.Scene)
{
case UIManager.ViewScene.Gacha:
mAINTENANCE_TYPE = NetworkDefine.MAINTENANCE_TYPE.SHOP_CARDPACK_MAINTENANCE;
break;
case UIManager.ViewScene.Profile:
mAINTENANCE_TYPE = NetworkDefine.MAINTENANCE_TYPE.PROFILE_MAINTENANCE;
break;
case UIManager.ViewScene.CardAllList:
mAINTENANCE_TYPE = NetworkDefine.MAINTENANCE_TYPE.CARD_MAINTENANCE;
break;
case UIManager.ViewScene.DeckList:
mAINTENANCE_TYPE = NetworkDefine.MAINTENANCE_TYPE.DECK_MAINTENANCE;
break;
case UIManager.ViewScene.MyPage:
if (!data.Sub.HasValue)
{
break;
}
switch (data.Sub.Value)
{
case MyPageSub.Supply:
if (IsMaintenance(NetworkDefine.MAINTENANCE_TYPE.SHOP_SLEEVE_MAINTENANCE) && IsMaintenance(NetworkDefine.MAINTENANCE_TYPE.SHOP_SKIN_MAINTENANCE))
{
return IsMaintenance(NetworkDefine.MAINTENANCE_TYPE.SHOP_ITEM_MAINTENANCE);
}
return false;
case MyPageSub.Colosseum:
mAINTENANCE_TYPE = NetworkDefine.MAINTENANCE_TYPE.COLOSSEUM;
break;
case MyPageSub.Gacha:
mAINTENANCE_TYPE = NetworkDefine.MAINTENANCE_TYPE.SHOP_CARDPACK_MAINTENANCE;
break;
}
break;
case UIManager.ViewScene.BuildDeckPurchasePage:
mAINTENANCE_TYPE = NetworkDefine.MAINTENANCE_TYPE.SHOP_BUILDDECK_MAINTENANCE;
break;
case UIManager.ViewScene.Mission:
mAINTENANCE_TYPE = NetworkDefine.MAINTENANCE_TYPE.MISSION_MAINTENANCE;
break;
case UIManager.ViewScene.StorySelectPage:
case UIManager.ViewScene.StorySelectionWorld:
mAINTENANCE_TYPE = NetworkDefine.MAINTENANCE_TYPE.STORY_MAINTENANCE;
break;
case UIManager.ViewScene.ClassSkinPurchasePage:
mAINTENANCE_TYPE = NetworkDefine.MAINTENANCE_TYPE.SHOP_SKIN_MAINTENANCE;
break;
}
if (mAINTENANCE_TYPE.HasValue)
{
return IsMaintenance(mAINTENANCE_TYPE.Value);
}
return false;
}
public static bool IsMaintenance(NetworkDefine.MAINTENANCE_TYPE type)
{
if (Data.MaintenanceCodeList == null)
{
return false;
}
return Data.MaintenanceCodeList.Contains(type);
}
public static void ChangeScene(TransitionData data, Action onChange)
{
object sceneParam = null;
data.Param.OnChange = onChange;
data.Param.IsUpdateFooterMenuTexture = true;
if (data.Scene == UIManager.ViewScene.DeckList)
{
ChangeSceneToDeckList(data);
return;
}
if (data.UpdateFooter.HasValue)
{
data.Param.OnFinishChangeView = delegate
{
UIManager.GetInstance()._Footer.UpdateCurrentIndex(data.UpdateFooter.Value);
};
}
if (data.PlayerPref.HasValue && data.Status.HasValue)
{
PlayerPrefsWrapper.SetValue(data.PlayerPref.Value, data.Status.Value);
}
if (data.Scene == UIManager.ViewScene.Mission)
{
if (data.Status.HasValue)
{
GoToMission(data.Status.Value);
}
return;
}
if (data.Scene == UIManager.ViewScene.StorySelectPage)
{
// StorySelectPage removed (DEAD-COLD engine cleanup Task 12)
}
else if (data.Scene == UIManager.ViewScene.StorySelectionWorld && data.Status.HasValue)
{
StorySelectionWorldScene.RedirectSectionId = data.Status.Value;
}
if (data.Scene == UIManager.ViewScene.Gacha)
{
GachaUIParam gachaUIParam = new GachaUIParam();
if (data.Status.HasValue)
{
gachaUIParam.SetDefaultPackId(data.Status.Value);
}
sceneParam = gachaUIParam;
}
if (data.Scene == UIManager.ViewScene.CrossoverPortal)
{
sceneParam = CrossoverPortalParam.CreateParam(data.Status);
}
if (data.Scene == UIManager.ViewScene.ClassSkinPurchasePage && data.Status.HasValue)
{
ClassSkinPurchasePage.SetFirstDisplaySeries(data.Status.Value);
}
if (UIManager.GetInstance().GetCurrentScene() == UIManager.ViewScene.Battle)
{
Action<UIManager.ChangeViewSceneParam> paramCustomize = delegate(UIManager.ChangeViewSceneParam param)
{
if (onChange != null)
{
param.OnChange = (Action)Delegate.Combine(param.OnChange, onChange);
}
param.IsUpdateFooterMenuTexture = true;
};
/* Pre-Phase-5b: BattleCtrl.BattleEnd dropped (BattleControl stubbed chunk 7) */
}
else
{
UIManager.GetInstance().ChangeViewScene(data.Scene, data.Param, sceneParam);
}
}
private static void ChangeSceneToDeckList(TransitionData data)
{
DeckInfoTask task = new DeckInfoTask();
task.SetParameter(Format.All);
UIManager.GetInstance().StartCoroutine(Toolbox.NetworkManager.Connect(task, delegate
{
Format format = Format.Rotation;
if (!task.DeckGroupListData.IsExistDeckListByFormat(Format.Rotation) && task.DeckGroupListData.IsExistDeckListByFormat(Format.Unlimited))
{
format = Format.Unlimited;
}
DeckListUI.ChangeSceneToDeckList(format, data.Param);
}));
}
private static UIManager.ChangeViewSceneParam CreateMyPageChangeParam(int index, bool isCutCard)
{
return new UIManager.ChangeViewSceneParam
{
MyPageMenuIndex = index,
IsCutCardMotion = isCutCard,
IsUpdateFooterMenuTexture = true
};
}
}