Phase 3 shipped the AI rank battle bot pool as a hardcoded 8-entry list inlined in SVSim.EmulatedEntrypoint/Matching/BotRoster.cs — editing meant recompiling. Per PLAN.md 2026-06-02 item (d), move it to a Bootstrap importer so the roster lives in seeds/bot-roster.json and the DB. Shape mirrors PracticeOpponent end-to-end: - BotRosterEntry (SVSim.Database/Models) — PK = AiId via the Id passthrough pattern. DbSet<BotRosterEntry> BotRoster on SVSimDbContext. - AddBotRoster migration (DDL only, per migrations-are-DDL-only rule). - seeds/bot-roster.json — 8 rows preserving the current prod-verified cosmetic ids (sleeve 704141010 / emblem 400001100 / degree 120027 / field 5) and series-1 ai_ids from rm_ai_setting.csv (1111..1181). - BotRosterSeed POCO + BotRosterImporter (idempotent upsert keyed by AiId, leaves seed-missing rows intact). Wired into SVSim.Bootstrap/Program.cs next to PracticeOpponentImporter. - IGlobalsRepository.GetBotRoster() + impl. IBotRoster.Pick → PickAsync because BotRoster now depends on the transient IGlobalsRepository. RankBattleController awaits the new signature. The deterministic hash-on-ctx invariant (same ctx → same bot, so /ai_<fmt>/start retries pick the same opponent) is preserved. DI: AddSingleton<IBotRoster> → AddTransient (matches IGlobalsRepository's lifetime). Test fixture's SeedGlobalsAsync also runs the importer so RankBattleControllerTests + the rewritten BotRosterTests both see seeded rows. Tests: 931 → 936 passing. Existing 3 BotRosterTests reshaped for the DB backing + 1 new "throws on empty roster" guard; 4 new BotRosterImporterTests mirror PracticeOpponentImporterTests (round-trip / idempotent / seed-missing-row-intact / ai_id=0 skip). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
95 lines
3.3 KiB
C#
95 lines
3.3 KiB
C#
using Microsoft.EntityFrameworkCore;
|
|
using Microsoft.Extensions.DependencyInjection;
|
|
using SVSim.Bootstrap.Importers;
|
|
using SVSim.Database;
|
|
using SVSim.UnitTests.Infrastructure;
|
|
|
|
namespace SVSim.UnitTests.Importers;
|
|
|
|
public class BotRosterImporterTests
|
|
{
|
|
private static string SeedDir => Path.Combine(AppContext.BaseDirectory, "Data", "seeds");
|
|
|
|
[Test]
|
|
public async Task Imports_bots_from_seed_file()
|
|
{
|
|
using var factory = new SVSimTestFactory();
|
|
using var scope = factory.Services.CreateScope();
|
|
var db = scope.ServiceProvider.GetRequiredService<SVSimDbContext>();
|
|
|
|
await new BotRosterImporter().ImportAsync(db, SeedDir);
|
|
|
|
var bots = await db.BotRoster.OrderBy(b => b.Id).ToListAsync();
|
|
Assert.That(bots.Count, Is.GreaterThan(0), "seed file must contain bots");
|
|
Assert.That(bots.All(b => b.ClassId is >= 1 and <= 8), Is.True);
|
|
Assert.That(bots.All(b => !string.IsNullOrEmpty(b.UserName)), Is.True);
|
|
}
|
|
|
|
[Test]
|
|
public async Task Is_idempotent_on_rerun()
|
|
{
|
|
using var factory = new SVSimTestFactory();
|
|
using var scope = factory.Services.CreateScope();
|
|
var db = scope.ServiceProvider.GetRequiredService<SVSimDbContext>();
|
|
|
|
await new BotRosterImporter().ImportAsync(db, SeedDir);
|
|
int before = await db.BotRoster.CountAsync();
|
|
await new BotRosterImporter().ImportAsync(db, SeedDir);
|
|
int after = await db.BotRoster.CountAsync();
|
|
|
|
Assert.That(after, Is.EqualTo(before));
|
|
}
|
|
|
|
[Test]
|
|
public async Task Leaves_existing_rows_untouched_when_missing_from_seed()
|
|
{
|
|
using var factory = new SVSimTestFactory();
|
|
using var scope = factory.Services.CreateScope();
|
|
var db = scope.ServiceProvider.GetRequiredService<SVSimDbContext>();
|
|
|
|
const int legacyAiId = 99999;
|
|
db.BotRoster.Add(new SVSim.Database.Models.BotRosterEntry
|
|
{
|
|
Id = legacyAiId,
|
|
CountryCode = "ZZ",
|
|
UserName = "legacy",
|
|
SleeveId = 1,
|
|
EmblemId = 1,
|
|
DegreeId = 1,
|
|
FieldId = 1,
|
|
ClassId = 1,
|
|
CharaId = 1,
|
|
Rank = 1,
|
|
});
|
|
await db.SaveChangesAsync();
|
|
|
|
await new BotRosterImporter().ImportAsync(db, SeedDir);
|
|
|
|
var legacy = await db.BotRoster.FindAsync(legacyAiId);
|
|
Assert.That(legacy, Is.Not.Null, "seed-missing row must be left intact");
|
|
Assert.That(legacy!.UserName, Is.EqualTo("legacy"), "pre-existing values must not be wiped");
|
|
}
|
|
|
|
[Test]
|
|
public async Task Skips_rows_with_zero_ai_id()
|
|
{
|
|
using var factory = new SVSimTestFactory();
|
|
using var scope = factory.Services.CreateScope();
|
|
var db = scope.ServiceProvider.GetRequiredService<SVSimDbContext>();
|
|
|
|
string tmp = Path.Combine(Path.GetTempPath(), $"seed-{Guid.NewGuid()}");
|
|
Directory.CreateDirectory(tmp);
|
|
try
|
|
{
|
|
File.WriteAllText(Path.Combine(tmp, "bot-roster.json"),
|
|
"[{\"ai_id\":0,\"user_name\":\"junk\",\"class_id\":1}]");
|
|
|
|
await new BotRosterImporter().ImportAsync(db, tmp);
|
|
|
|
int count = await db.BotRoster.CountAsync();
|
|
Assert.That(count, Is.EqualTo(0), "rows with ai_id=0 must not be inserted");
|
|
}
|
|
finally { Directory.Delete(tmp, true); }
|
|
}
|
|
}
|