Files
SVSimServer/SVSim.Bootstrap/Importers/BotRosterImporter.cs
gamer147 24f9b2240e feat(matching): move BotRoster from hardcoded fixture to DB-backed seed
Phase 3 shipped the AI rank battle bot pool as a hardcoded 8-entry list
inlined in SVSim.EmulatedEntrypoint/Matching/BotRoster.cs — editing meant
recompiling. Per PLAN.md 2026-06-02 item (d), move it to a Bootstrap
importer so the roster lives in seeds/bot-roster.json and the DB.

Shape mirrors PracticeOpponent end-to-end:
- BotRosterEntry (SVSim.Database/Models) — PK = AiId via the Id passthrough
  pattern. DbSet<BotRosterEntry> BotRoster on SVSimDbContext.
- AddBotRoster migration (DDL only, per migrations-are-DDL-only rule).
- seeds/bot-roster.json — 8 rows preserving the current prod-verified
  cosmetic ids (sleeve 704141010 / emblem 400001100 / degree 120027 /
  field 5) and series-1 ai_ids from rm_ai_setting.csv (1111..1181).
- BotRosterSeed POCO + BotRosterImporter (idempotent upsert keyed by AiId,
  leaves seed-missing rows intact). Wired into SVSim.Bootstrap/Program.cs
  next to PracticeOpponentImporter.
- IGlobalsRepository.GetBotRoster() + impl.

IBotRoster.Pick → PickAsync because BotRoster now depends on the transient
IGlobalsRepository. RankBattleController awaits the new signature. The
deterministic hash-on-ctx invariant (same ctx → same bot, so /ai_<fmt>/start
retries pick the same opponent) is preserved.

DI: AddSingleton<IBotRoster> → AddTransient (matches IGlobalsRepository's
lifetime). Test fixture's SeedGlobalsAsync also runs the importer so
RankBattleControllerTests + the rewritten BotRosterTests both see seeded
rows.

Tests: 931 → 936 passing. Existing 3 BotRosterTests reshaped for the DB
backing + 1 new "throws on empty roster" guard; 4 new
BotRosterImporterTests mirror PracticeOpponentImporterTests
(round-trip / idempotent / seed-missing-row-intact / ai_id=0 skip).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-06-02 11:58:19 -04:00

63 lines
2.0 KiB
C#

using Microsoft.EntityFrameworkCore;
using SVSim.Bootstrap.Models.Seed;
using SVSim.Database;
using SVSim.Database.Models;
namespace SVSim.Bootstrap.Importers;
/// <summary>
/// Idempotent upsert of AI bot opponents from <c>seeds/bot-roster.json</c>.
/// Rows missing from the seed are LEFT INTACT (consistent with PracticeOpponentImporter;
/// a partial seed shouldn't silently delete entries).
/// </summary>
public class BotRosterImporter
{
public async Task<int> ImportAsync(SVSimDbContext context, string seedDir)
{
string path = Path.Combine(seedDir, "bot-roster.json");
var seed = SeedLoader.LoadList<BotRosterSeed>(path);
if (seed.Count == 0)
{
Console.WriteLine("[BotRosterImporter] No seed rows; skipping.");
return 0;
}
var existing = await context.BotRoster.ToDictionaryAsync(e => e.Id);
int created = 0, updated = 0;
foreach (var s in seed)
{
if (s.AiId == 0) continue;
var entry = existing.TryGetValue(s.AiId, out var ex)
? ex : new BotRosterEntry { Id = s.AiId };
entry.CountryCode = s.CountryCode;
entry.UserName = s.UserName;
entry.SleeveId = s.SleeveId;
entry.EmblemId = s.EmblemId;
entry.DegreeId = s.DegreeId;
entry.FieldId = s.FieldId;
entry.IsOfficial = s.IsOfficial;
entry.ClassId = s.ClassId;
entry.CharaId = s.CharaId;
entry.Rank = s.Rank;
entry.BattlePoint = s.BattlePoint;
entry.IsMasterRank = s.IsMasterRank;
entry.MasterPoint = s.MasterPoint;
if (ex is null)
{
context.BotRoster.Add(entry);
existing[s.AiId] = entry;
created++;
}
else updated++;
}
await context.SaveChangesAsync();
Console.WriteLine($"[BotRosterImporter] +{created}/~{updated}");
return created + updated;
}
}