SVSim/SVSimServer
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix(guild): final-review remediation — replay_detail flat, FK on leader, transaction wraps, _db extraction

Browse Source 
C1: replay_detail — flatten stored payload to data level. ChatReplayDetailTask.Parse() calls
new ReplayDetailInfo(data) which unguardedly accesses data[battleId], data[seed], data[vid1],
etc. Wrapping under replay_info key crashes the client. Controller now returns Ok(JsonElement)
directly so stored battle fields are at data root. Wire-shape test added.

C2: Guild.LeaderViewerId long to long?; add HasOne<Viewer> FK with OnDelete=SetNull; migration
AddGuildLeaderViewerIdFk; all consumers null-guarded with ?? 0L.

C3: BreakupAsync — wrap 6 destructive ops in IDbContextTransaction with InMemory fallback.

C4: CommitJoinAsync — wrap member-add + viewer-guildId-set + invite/request cleanup in
IDbContextTransaction with InMemory fallback. Chat event emitted after commit.

I1: GuildController — remove SVSimDbContext field; inject IViewerRepository + IGuildMemberRepository.
Add IGuildMemberRepository.GetViewerIdsInAGuildAsync (batch guild-membership check).
All _db.Viewers / _db.GuildMembers queries replaced with repo calls.

I2: GuildService — extract 3 _db.Viewers queries: GetEquippedEmblemIdAsync (CreateAsync),
LoadGuildProfileBatchAsync (ListOutgoingInvitesAsync + ListPendingJoinRequestsForMyGuildAsync).
Add GuildMemberProfile record with IsOfficialMarkDisplayed. GetEmblemListAsync for EmblemList.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
gamer147
2026-06-27 16:33:59 -04:00
parent 754b2ca466
commit ff77d5e5b6
14 changed files with 5378 additions and 136 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
SVSim.Database/Repositories/Guild/GuildMemberRepository.cs
View File

@@ -70,4 +70,15 @@ public sealed class GuildMemberRepository : IGuildMemberRepository
result[row.GuildId] = row.Count;
return result;
}
public async Task<HashSet<long>> GetViewerIdsInAGuildAsync(
IReadOnlyList<long> viewerIds, CancellationToken ct = default)
{
if (viewerIds.Count == 0) return new HashSet<long>();
var ids = await _db.GuildMembers
.Where(m => viewerIds.Contains(m.ViewerId))
.Select(m => m.ViewerId)
.ToListAsync(ct);
return new HashSet<long>(ids);
}
}

7
SVSim.Database/Repositories/Guild/IGuildMemberRepository.cs
View File

@@ -15,4 +15,11 @@ public interface IGuildMemberRepository
/// <summary>Returns a count of members per guild for the given guild ids. Used by Task 9 search.</summary>
Task<Dictionary<int, int>> CountBatchByGuildIdsAsync(IReadOnlyList<int> guildIds, CancellationToken ct = default);
/// <summary>
/// Batch-checks whether each viewer id in <paramref name="viewerIds"/> is currently in any guild.
/// Returns a set of viewer ids that ARE in a guild. Used by <c>/guild/friend_list</c> to set
/// <c>is_join_guild</c>.
/// </summary>
Task<HashSet<long>> GetViewerIdsInAGuildAsync(IReadOnlyList<long> viewerIds, CancellationToken ct = default);
}