refactor(calendar): expose AllTime via GameCalendarPeriods, not the concrete service

Move the "all-time" constant out of GameCalendarService (concrete) into a new
static class GameCalendarPeriods. Consumers using IGameCalendarService no
longer have to reach through the concrete class to name the lifetime bucket.

Migrates 5 callsites (mission progress/assembler, admin, item purchase, tests).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
gamer147
2026-07-04 12:59:24 -04:00
parent e1b38d5649
commit fa89c32110
6 changed files with 14 additions and 10 deletions

View File

@@ -629,7 +629,7 @@ public class AdminController : SVSimController
private static (string EventKey, string Period)? ResolveAchievementCounter(AchievementCatalogEntry catalog)
{
if (string.IsNullOrEmpty(catalog.EventType)) return null;
return (catalog.EventType!, GameCalendarService.AllTime);
return (catalog.EventType!, GameCalendarPeriods.AllTime);
}
/// <summary>