SVSim/SVSimServer
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

refactor: drop unused DailyLoginBonuses table + importer

Browse Source 
The captured shape ({"1":[], "3":[], "4":[]}) is the empty-period
wire echo; the client parser (LoadDetail.cs:553) only reads normal/total/
campaign. Table, entity, seed, and importer were never wired to a code path.

Replaced by config-section catalog + service in the follow-up commits.
This commit is contained in:
gamer147
2026-06-13 15:32:33 -04:00
parent ba7040580f
commit f707fb2ffb
13 changed files with 4 additions and 117 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
SVSim.UnitTests/Importers/LoadIndexImporterTests.cs
View File

@@ -8,7 +8,7 @@ namespace SVSim.UnitTests.Importers;
/// <summary>
/// Happy-path coverage for the load-index importer classes introduced in Stage 9B
/// (RotationConfig, MyRotation, AvatarAbility, ArenaSeason, DailyLoginBonus,
/// (RotationConfig, MyRotation, AvatarAbility, ArenaSeason,
/// PreReleaseInfo). Each test instantiates the importer in isolation and verifies it inserts
/// rows from the corresponding seed file under <c>Data/seeds/</c>.
/// Idempotency, edge cases, and per-importer detail tests live in dedicated *ImporterTests files (e.g. BattlePassImporterTests).
@@ -73,19 +73,6 @@ public class LoadIndexImporterTests
Assert.That(row!.FormatInfo, Is.Not.EqualTo("{}"), "format_info blob must be populated from seed");
}
[Test]
public async Task DailyLoginBonusImporter_writes_bonus_rows()
{
using var factory = new SVSimTestFactory();
using var scope = factory.Services.CreateScope();
var db = scope.ServiceProvider.GetRequiredService<SVSimDbContext>();
await new DailyLoginBonusImporter().ImportAsync(db, SeedDir);
Assert.That(await db.DailyLoginBonuses.CountAsync(), Is.GreaterThan(0),
"daily-login-bonus.json must produce rows");
}
[Test]
public async Task PreReleaseInfoImporter_writes_singleton()
{

1
SVSim.UnitTests/Infrastructure/SVSimTestFactory.cs
View File

@@ -266,7 +266,6 @@ internal class SVSimTestFactory : WebApplicationFactory<Program>
await new BattlePassImporter().ImportAsync(ctx, seedDir);
await new BattlePassSeasonImporter().ImportAsync(ctx, seedDir);
await new BattlePassRewardImporter().ImportAsync(ctx, seedDir);
await new DailyLoginBonusImporter().ImportAsync(ctx, seedDir);
await new PreReleaseInfoImporter().ImportAsync(ctx, seedDir);
await new CardListsImporter().ImportAsync(ctx, seedDir);
await new RotationFlagUpdater().UpdateAsync(ctx);

10
SVSim.UnitTests/Repositories/GlobalsRepositoryTests.cs
View File

@@ -80,16 +80,6 @@ public class GlobalsRepositoryTests
Assert.That(levels.Count, Is.EqualTo(100));
}
[Test]
public async Task GetDailyLoginBonus_returns_three_skeleton_entries()
{
var (factory, repo) = await SetupAsync();
using var _ = factory;
var bonuses = await repo.GetDailyLoginBonus();
Assert.That(bonuses.Count, Is.EqualTo(3),
"Prod capture has keys {1, 3, 4} with empty arrays — skeleton presence still seeded.");
}
[Test]
public async Task GetPreReleaseInfo_returns_singleton()
{