SVSim/SVSimServer
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

refactor: drop unused DailyLoginBonuses table + importer

Browse Source 
The captured shape ({"1":[], "3":[], "4":[]}) is the empty-period
wire echo; the client parser (LoadDetail.cs:553) only reads normal/total/
campaign. Table, entity, seed, and importer were never wired to a code path.

Replaced by config-section catalog + service in the follow-up commits.
This commit is contained in:
gamer147
2026-06-13 15:32:33 -04:00
parent ba7040580f
commit f707fb2ffb
13 changed files with 4 additions and 117 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
SVSim.EmulatedEntrypoint/Controllers/LoadController.cs
View File

@@ -229,10 +229,8 @@ public class LoadController : SVSimController
MaintenanceCards = (await _globalsRepository.GetMaintenanceCards())
.Select(e => e.Id).ToList(),
RedEtherOverrides = new List<RedEtherOverride>(),
// Optional per spec (load-index.md:247). Skeleton-seeded rows in DailyLoginBonuses table
// capture prod's empty-period shape ({"1":[], "3":[], "4":[]}); the spec-shaped DTO
// ({normal?, total?, campaign?[]}) carries nothing meaningful until an active campaign
// is captured.
// Optional per spec (load-index.md:247). Populated by ILoginBonusService (Task 6)
// when the viewer has an active bonus period.
DailyLoginBonus = null,
UserRankedMatches = new List<UserRankedMatches>(),
UserRankInfo = RankFormats.Select(f => new UserRankInfo

4
SVSim.EmulatedEntrypoint/Models/Dtos/Responses/IndexResponse.cs
View File

@@ -150,9 +150,7 @@ public class IndexResponse
/// <summary>
/// Spec: optional. Shape is {normal?, total?, campaign?[]} per common/types.ts.md DailyLoginBonus.
/// Until we have an active login-bonus campaign to surface in spec shape, omit. The skeleton
/// rows in DailyLoginBonuses table (prod sent {"1":[], "3":[], "4":[]}) preserve the capture
/// for archive but don't make it into the wire response.
/// Populated by ILoginBonusService when the viewer has an active bonus period; null otherwise.
/// </summary>
[JsonPropertyName("daily_login_bonus")]
[Key("daily_login_bonus")]