SVSim/SVSimServer
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix(tk2): honor consume_item_type (ticket/crystal/rupy/free) + correct entry ticket id

Browse Source 
- ArenaTwoPickConfig: add TicketItemId=1, TicketCost=1, CrystalCost=150, RupyCost=150 scalars
- ArenaTwoPickService.EntryAsync: switch on eARENA_PAY (1/3/4/5); crystal/rupy go through
  ICurrencySpendService.TrySpendAsync; ticket uses item id 1 (challenge ticket, not 80001);
  free entry returns empty reward_list; invalid type throws
- Tests: fix ticket id 80001→1 in entry/e2e; add 4 new path tests; update ctor (10th arg)
  across all 4 service test files; fix e2e retire assertion (reward ticket 80001 post-state=1)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
gamer147
2026-05-31 12:26:57 -04:00
parent 668779e8a4
commit dc19289818
7 changed files with 166 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
SVSim.UnitTests/Integration/ArenaTwoPickEndToEndTests.cs
View File

@@ -18,7 +18,7 @@ public class ArenaTwoPickEndToEndTests
using var factory = new SVSimTestFactory();
// Load globals: challenge-config (pool_card_set_ids includes 10015), item master
// (ticket 80001), and arena-two-pick rewards.
// (includes 80001, the run-end reward ticket), and arena-two-pick rewards.
await factory.SeedGlobalsAsync();
// Seed card set 10015 with one Bronze collectible card per class (1-8) + one neutral.
@@ -68,10 +68,10 @@ public class ArenaTwoPickEndToEndTests
db, Path.Combine(AppContext.BaseDirectory, "Data", "seeds"));
}
// Seed viewer with 5 TK2 tickets. SeedGlobalsAsync already loaded ItemEntry 80001.
// Seed viewer with 5 entry tickets (item id 1 = challenge ticket).
long viewerId = await factory.SeedViewerAsync();
await factory.SeedOwnedItemAsync(viewerId, itemId: 80001, count: 5,
itemName: "TK2 Ticket", itemType: 2);
await factory.SeedOwnedItemAsync(viewerId, itemId: 1, count: 5,
itemName: "TK2 Entry Ticket", itemType: 2);
// Capture starting Rupees so the retire assertion can compute expected post-state
// regardless of the default-grants config value (currently 50 000).
@@ -91,7 +91,7 @@ public class ArenaTwoPickEndToEndTests
Assert.That(top.StatusCode, Is.EqualTo(HttpStatusCode.OK));
StringAssert.Contains("\"entry_info\":null", await top.Content.ReadAsStringAsync());
// 2) /entry → deducts 1 ticket (post-state = 4), returns 3 candidate class ids.
// 2) /entry → deducts 1 entry ticket (id 1, post-state = 4), returns 3 candidate class ids.
var entry = await client.PostAsync("/arena_two_pick/entry",
JsonContent.Create(new { consume_item_type = 3, viewer_id = Vid, steam_id = Sid, steam_session_ticket = Stk }));
Assert.That(entry.StatusCode, Is.EqualTo(HttpStatusCode.OK),
@@ -129,8 +129,9 @@ public class ArenaTwoPickEndToEndTests
.GetProperty("id").GetString()!);
}
// 5) /retire at 0 wins → 1 ticket + 100 rupies from the seed table.
// Post-state: ticket = 4 (after debit) + 1 (grant) = 5; rupies = 0 + 100 = 100.
// 5) /retire at 0 wins → 1 ticket (80001) + 100 rupies from the seed table.
// Entry ticket (id 1): 5 - 1 debit = 4 remaining (not in reward_list).
// Reward ticket (id 80001): starts at 0, granted 1 → post-state = 1.
var retire = await client.PostAsync("/arena_two_pick/retire",
JsonContent.Create(new { viewer_id = Vid, steam_id = Sid, steam_session_ticket = Stk }));
Assert.That(retire.StatusCode, Is.EqualTo(HttpStatusCode.OK),
@@ -148,10 +149,10 @@ public class ArenaTwoPickEndToEndTests
Assert.That(rupyEntry.GetProperty("reward_num").GetString(), Is.EqualTo(expectedRupees),
$"post-state rupy = {startRupees} + 100");
// reward_type 4 = Item (ticket 80001); post-state = 4 (after debit) + 1 (grant) = 5.
// reward_type 4 = Item (reward ticket 80001); post-state = 0 (start) + 1 (grant) = 1.
var ticketEntry = rewardList.Single(r => r.GetProperty("reward_type").GetInt32() == 4);
Assert.That(ticketEntry.GetProperty("reward_num").GetString(), Is.EqualTo("5"),
"post-state ticket = 4 (after debit) + 1 (grant) = 5");
Assert.That(ticketEntry.GetProperty("reward_num").GetString(), Is.EqualTo("1"),
"post-state reward ticket (80001) = 0 + 1 grant = 1");
// 6) /top → entry_info:null again (run was deleted by /retire).
var topAgain = await client.PostAsync("/arena_two_pick/top",