SVSim/SVSimServer
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

refactor(battle-node): remove scripted-bot test-stub arms from dispatch handlers

Browse Source 
The IsScriptedBot(ctx.From) forwards in JudgeHandler/TurnStartHandler/TurnEndHandler
and the 'if Type==Scripted' raw-forward only ever fired for ScriptedBotParticipant
emissions; NoOpBot (Bot mode) never emits, so they are dead. Routing is now purely
PvP-vs-Bot. Drops the IsScriptedBot helper.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
gamer147
2026-06-03 20:00:41 -04:00
parent 963adbbd1b
commit ca9ad5db8f
4 changed files with 2 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
SVSim.BattleNode/Sessions/Dispatch/FrameDispatchContext.cs
View File

@@ -32,10 +32,4 @@ internal sealed class FrameDispatchContext
internal bool BothAfterReady() =>
(A as IHasHandshakePhase)?.Phase == BattleSessionPhase.AfterReady &&
(B as IHasHandshakePhase)?.Phase == BattleSessionPhase.AfterReady;
/// <summary>True for any participant carrying the synthetic opponent viewer id — i.e. a
/// <c>ScriptedBotParticipant</c> OR a <c>NoOpBotParticipant</c>. Callers that must exclude Bot
/// mode rely on a preceding <c>Type == BattleType.Bot</c> guard. Mirrors the legacy
/// IsRealForwardableFromScripted guard.</summary>
internal bool IsScriptedBot(IBattleParticipant p) => p.ViewerId == ScriptedLifecycle.FakeOpponentViewerId;
}